> On Jan. 14, 2013, 11:48 a.m., Thomas Lübking wrote:
> > In correspondance with 
> > http://mail.kde.org/pipermail/plasma-devel/2013-January/023423.html
> 
> Thomas Lübking wrote:
>     @Oliver
>     How do we proceed on this?
>     Whithout dpms working neither https://git.reviewboard.kde.org/r/108416/ 
> nor https://git.reviewboard.kde.org/r/108417/ make any sense at all, so do 
> you want to move this out of powerdevil altogether (towards solid) and not be 
> used before at all or just not be used in terms of 
> https://git.reviewboard.kde.org/r/108417/ or include it in 4.10 or 4.11?
>     
>     (As mentioned, i'm foreign here, so i'll stick to the preferences of the 
> maintainers and/or regular commiters - just cleaning up my git history ;-)

I need to put together a counter-proposal to 
https://git.reviewboard.kde.org/r/108417/ for a start. Review 108416 is likely 
to be useful in any case.


- Oliver


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106795/#review25438
-----------------------------------------------------------


On Oct. 11, 2012, 1:15 p.m., Oliver Henshaw wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/106795/
> -----------------------------------------------------------
> 
> (Updated Oct. 11, 2012, 1:15 p.m.)
> 
> 
> Review request for Solid.
> 
> 
> Description
> -------
> 
> Avoid race during button-triggered DPMS
> 
> core->onResumeFromSuspend calls SimulateUserActivity from the
> screensaver dbus interface. This seems to race with the subsequent call
> to DPMSForceLevel so that the screen re-wakes but 'xset -q' thinks it is
> off and timed dpms activation is disabled (this may be hardware dependent 
> - see https://bugzilla.redhat.com/show_bug.cgi?id=864074 for details.)
> 
> PowerDevil::Core::onResumeFromSuspend used to (optionally) lock the
> screen but this changed in a3b0089130145ad15173d1c14ab8a672b93aea65 -
> now the call is useless at best.
> 
> 
> Diffs
> -----
> 
>   powerdevil/daemon/actions/dpms/powerdevildpmsaction.cpp 
> a16bf7ee254b9a40c6f033c93e5ca63226469e6e 
> 
> Diff: http://git.reviewboard.kde.org/r/106795/diff/
> 
> 
> Testing
> -------
> 
> Set powerbutton to turn off screen and tested that it works.
> 
> 
> Thanks,
> 
> Oliver Henshaw
> 
>

_______________________________________________
Kde-hardware-devel mailing list
Kde-hardware-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-hardware-devel

Reply via email to