Re: [Kde-hardware-devel] Review Request 109384: Move advancedDiscDetect to daemon

2013-03-14 Thread Lukáš Tinkl
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109384/#review29184 --- Please also test with special media, like blank and audio CDs.

Re: [Kde-hardware-devel] Review Request 109384: Move advancedDiscDetect to daemon

2013-03-14 Thread Alexander Mezin
> On March 14, 2013, 10:40 a.m., Lukáš Tinkl wrote: > > Please also test with special media, like blank and audio CDs. Thanks for > > the work! I didn't touch code that handles other disk types, as only video disk detection caused problems. And I don't have audio cds, sorry. But other people t

Re: [Kde-hardware-devel] Review Request 109384: Move advancedDiscDetect to daemon

2013-03-14 Thread Dan Vrátil
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109384/#review29211 --- The code looks fine, thanks! There's another concern now, how

[Kde-hardware-devel] Review Request 109491: Set as active only Activated ActiveConfigs

2013-03-14 Thread Àlex Fiestas
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109491/ --- Review request for Solid. Description --- Only set as active the Acti

Re: [Kde-hardware-devel] Review Request 109384: Move advancedDiscDetect to daemon

2013-03-14 Thread Alexander Mezin
> On March 14, 2013, 3:02 p.m., Dan Vrátil wrote: > > The code looks fine, thanks! > > > > There's another concern now, however (something that I haven't thought > > about before, sorry!) - if the code now depends on kdelibs, we don't fit > > Tear 1 in KDE Frameworks anymore. The question is