---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111699/#review36528
---
I'm curious why this is needed, after all, your change just
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111707/#review36530
---
Ship it!
Ship It!
- Dario Freddi
On July 26, 2013, 2:58
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111717/
---
Review request for Solid and Lukáš Tinkl.
Description
---
With this
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111717/#review36532
---
Please do more testing with different media types (audio,
On July 26, 2013, 12:05 p.m., Lukáš Tinkl wrote:
I'm curious why this is needed, after all, your change just uses a
different mechanism to connect the signals
I'm not sure if the current code actually works, but it gives that error in
runtime so I think it is better to change it anyway.
On July 26, 2013, 2:07 a.m., Kurt Hindenburg wrote:
I think this commit is causing build failures on MacOSX - kdelibs/4.11
branch
[ 21%] Building CXX object
solid/solid/CMakeFiles/solid.dir/backends/iokit/iokitdevice.o
On July 26, 2013, 4:07 a.m., Kurt Hindenburg wrote:
I think this commit is causing build failures on MacOSX - kdelibs/4.11
branch
[ 21%] Building CXX object
solid/solid/CMakeFiles/solid.dir/backends/iokit/iokitdevice.o
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111719/
---
Review request for Solid, Kurt Hindenburg and Lukáš Tinkl.
Description
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109384/
---
(Updated July 26, 2013, 7:52 p.m.)
Status
--
This change has been
On July 26, 2013, 6:17 p.m., Lukáš Tinkl wrote:
Please do more testing with different media types (audio, video, blank),
otherwise the code looks good
Tested with blank media and video cd. Didn't notice any problems, video cd is
detected correctly.
- Alexander
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111719/#review36539
---
Ship it!
Ship It!
- Lukáš Tinkl
On July 26, 2013, 2:40
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111717/#review36540
---
Ship it!
Please backport to 4.11 and 4.10 branches, thx
-
On July 26, 2013, 6:17 p.m., Lukáš Tinkl wrote:
Please do more testing with different media types (audio, video, blank),
otherwise the code looks good
Alexander Mezin wrote:
Tested with blank media and video cd. Didn't notice any problems, video
cd is detected correctly.
I heard
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111719/#review36542
---
Thanks - it builds here on MacOSX
- Kurt Hindenburg
On July
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111719/
---
(Updated July 26, 2013, 1:02 p.m.)
Status
--
This change has been
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111719/#review36544
---
This review has been submitted with commit
On July 26, 2013, 1:02 p.m., Commit Hook wrote:
This review has been submitted with commit
b051ab6f2d3c6d16a91a429d57cf96af2e6b1fe1 by Kai Uwe Broulik to branch
master.
Were you going to put this in the 4.11 branch? I would hope it goes in before
the release.
- Kurt
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111707/#review36559
---
int lidAction() const; looks a bit weird as slot signature,
18 matches
Mail list logo
