Re: [Kde-hardware-devel] Review Request 122048: Don't suspend when closing the lid and an external monitor is connected

2015-01-14 Thread Heiko Tietze
On Jan. 14, 2015, 12:29 nachm., Sebastian Kügler wrote: I really like this feature. However, I think that UI wise, it looks a bit unpolished. It adds two checkboxes with long texts, that even I, being a domain expert, need some thinking to understand. I wonder if we should

Re: [Kde-hardware-devel] Review Request 122048: Don't suspend when closing the lid and an external monitor is connected

2015-01-14 Thread Daniel Vrátil
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122048/#review73999 --- +1, looks good to me - Daniel Vrátil On Jan. 14, 2015,

Re: [Kde-hardware-devel] Review Request 122048: Don't suspend when closing the lid and an external monitor is connected

2015-01-14 Thread Martin Klapetek
On Jan. 14, 2015, 1:29 p.m., Sebastian Kügler wrote: daemon/actions/bundled/handlebuttonevents.h, line 68 https://git.reviewboard.kde.org/r/122048/diff/1/?file=341828#file341828line68 Off-hand, I don't understand what these vars ar e doing by reading their name. Would be nice if

Re: [Kde-hardware-devel] Review Request 122048: Don't suspend when closing the lid and an external monitor is connected

2015-01-14 Thread Sebastian Kügler
On Jan. 14, 2015, 12:29 p.m., Sebastian Kügler wrote: I really like this feature. However, I think that UI wise, it looks a bit unpolished. It adds two checkboxes with long texts, that even I, being a domain expert, need some thinking to understand. I wonder if we should offer

Re: [Kde-hardware-devel] Review Request 122048: Don't suspend when closing the lid and an external monitor is connected

2015-01-14 Thread Kai Uwe Broulik
On Jan. 14, 2015, 12:29 nachm., Sebastian Kügler wrote: I really like this feature. However, I think that UI wise, it looks a bit unpolished. It adds two checkboxes with long texts, that even I, being a domain expert, need some thinking to understand. I wonder if we should