Re: [Kde-hardware-devel] Review Request 121915: Add lidClosedChanged signal to org.kde.Solid.PowerManagement

2015-01-20 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121915/#review74374 --- This has been submitted, right? - Kai Uwe Broulik On Jan.

Re: [Kde-hardware-devel] Review Request 122151: Invert the KJob::Exec check logic

2015-01-20 Thread Daniel Vrátil
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122151/#review74384 --- Could this be related to /r/122029? When KAuth failed to

Re: [Kde-hardware-devel] Review Request 121386: Port XRandrBacklight to XCB

2015-01-20 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121386/ --- (Updated Jan. 20, 2015, 6:44 nachm.) Review request for Solid and Martin

Re: [Kde-hardware-devel] Review Request 121386: Port XRandrBacklight to XCB

2015-01-20 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121386/#review74452 --- daemon/backends/upower/xrandrbrightness.cpp

Re: [Kde-hardware-devel] Review Request 121386: Port XRandrBacklight to XCB

2015-01-20 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121386/#review74453 --- Pretty ugly C stuff (fre...), suggestions on how to improve