Re: Review Request 128813: fix include dir in pri file

2016-09-01 Thread David Rosca
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128813/#review98821 --- Ship it! Ship It! - David Rosca On Sept. 1, 2016, 5:51

Re: [Kde-hardware-devel] Review Request 126390: [GCI] Fix some Clazy warnings

2015-12-16 Thread David Rosca
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126390/#review89623 --- Ship it! Ship It! - David Rosca On Dec. 16, 2015, 8:49

Re: [Kde-hardware-devel] Review Request 108503: Add link to "Downloaded Files" directory in kio bluetooth

2015-12-15 Thread David Rosca
hough. - David Rosca On Dec. 15, 2015, 9:53 p.m., Kai Uwe Broulik wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard

Re: [Kde-hardware-devel] Review Request 126342: Fixed Clazy warning [-Wclazy-function-args-by-ref] and [-Wclazy-reserve-candidates]

2015-12-14 Thread David Rosca
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126342/#review89487 --- Ship it! Ship It! - David Rosca On Dec. 14, 2015, 11:15

Re: [Kde-hardware-devel] Review Request 126342: Fixed Clazy warning [-Wclazy-function-args-by-ref] and [-Wclazy-reserve-candidates]

2015-12-14 Thread David Rosca
tps://git.reviewboard.kde.org/r/126342/#comment61236> This is still non-POD static. If it fixes issue in clazy, then it is bug in clazy. You can try static const char * = "..." if it works, otherwise leave it as it is. - David Rosca On Dec. 14, 2015, 11:15 a.m., A

Re: [Kde-hardware-devel] Review Request 126338: fixed Clazy warnings [-Wclazy-foreach] and [-Wclazy-detaching-temporary]

2015-12-13 Thread David Rosca
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126338/#review89432 --- Ship it! Ship It! - David Rosca On Dec. 13, 2015, 9:58

Re: [Kde-hardware-devel] Review Request 126338: fixed Clazy warning [-Wclazy-foreach]

2015-12-13 Thread David Rosca
tps://git.reviewboard.kde.org/r/126338/#comment61200> Please fix coding style (everywhere): const AdapterPtr &adapter - David Rosca On Dec. 13, 2015, 9:36 p.m., Artur Puzio wrote: > > --- > This is an automatically generated e-ma

Re: [Kde-hardware-devel] Integrating a non-standard bluetooth device

2015-11-30 Thread David Rosca
Hi, On Mon, Nov 30, 2015 at 12:29 AM, Paulo Motta wrote: > Hello All, > > I am new to the list and I was experimenting with a BLE device, trying to > connect with my own C program. While testing I could manage to connect to it > with the KDE Bluetooth application via the tray icon, however no ser

[Kde-hardware-devel] Review Request 125963: UdevQt: Don't use QVariant for property values + cleanup

2015-11-05 Thread David Rosca
solid/devices/backends/udisks2/udisksstoragedrive.cpp af49063 Diff: https://git.reviewboard.kde.org/r/125963/diff/ Testing --- Builds Thanks, David Rosca ___ Kde-hardware-devel mailing list Kde-hardware-devel@kde.org https://mail.kde.org/mailman

[Kde-hardware-devel] Install UdevQt headers in Solid

2015-11-05 Thread David Rosca
Hi, I was working on udev device notifier in kcm_keyboard [1] and ended up with using libudev directly. We are using libudev in various places, either directly or through Solid's UdevQt. But in the case of UdevQt, all projects using it have its own copy [2]. I think it would be better if Solid in

Re: [Kde-hardware-devel] Review Request 125182: Fix the brightness key being ignored during the animation

2015-09-28 Thread David Rosca
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125182/#review86032 --- +1, can we also get this into Plasma/5.4? - David Rosca On

Re: [Kde-hardware-devel] Review Request 125435: Fix updating brightness while animation is still running

2015-09-28 Thread David Rosca
Diff: https://git.reviewboard.kde.org/r/125435/diff/ Testing --- Brightness shortcut works correctly now, even when quickly pressing the shortcut. Thanks, David Rosca ___ Kde-hardware-devel mailing list Kde-hardware-devel@kde.org https

Re: [Kde-hardware-devel] Review Request 125435: Fix updating brightness while animation is still running

2015-09-28 Thread David Rosca
://git.reviewboard.kde.org/r/125182 - David Rosca On Sept. 28, 2015, 7:58 a.m., David Rosca wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.

[Kde-hardware-devel] Review Request 125435: Fix updating brightness while animation is still running

2015-09-28 Thread David Rosca
shortcut works correctly now, even when quickly pressing the shortcut. Thanks, David Rosca ___ Kde-hardware-devel mailing list Kde-hardware-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-hardware-devel

Re: [Kde-hardware-devel] Review Request 102983: Added support for rfkill

2015-07-12 Thread David Rosca
in recent Plasma release (replaced with bluez-qt which have support for rfkill), and there won't be any more KDE4 nor Plasma 5.2.x releases. - David Rosca On July 11, 2015, 8:43 p.m., Rüdiger Sonderfeld wrote: > > --- &

Re: [Kde-hardware-devel] Review Request 123388: BluetoothMonitor: Simplify addBluetoothConnection + add haveBluetoothConnection

2015-04-17 Thread David Rosca
marked as submitted. Review request for Solid, Jan Grulich, Lukáš Tinkl, and Lamarque Souza. Changes --- Submitted with commit b7ddf942153c1d6757361aa90c16decc19cc6345 by David Rosca to branch master. Repository: plasma-nm Description --- This patch removes all Bluez related code

Re: [Kde-hardware-devel] Review Request 123388: BluetoothMonitor: Simplify addBluetoothConnection + add haveBluetoothConnection

2015-04-17 Thread David Rosca
ager.xml fa58c72 kded/dbus/org.freedesktop.DBus.Properties.xml a71f409 kded/monitor.h ae89d3e kded/monitor.cpp e33b918 Diff: https://git.reviewboard.kde.org/r/123388/diff/ Testing --- Works as before, mobile connection wizard appears when trying to add dun connection. Than

Re: [Kde-hardware-devel] Review Request 123388: BluetoothMonitor: Simplify addBluetoothConnection + add haveBluetoothConnection

2015-04-17 Thread David Rosca
gt; > to get the device name and use it as connectionName. That is something > > simular to using essid as connection name for wifi connections. Besides > > this particular change breaks compatibility with old Bluedevil versions. Is > > there a good reason for breaking compat

Re: [Kde-hardware-devel] Review Request 123388: BluetoothMonitor: Simplify addBluetoothConnection + add haveBluetoothConnection

2015-04-17 Thread David Rosca
To reply, visit: https://git.reviewboard.kde.org/r/123388/#review79116 --- On April 17, 2015, 11:40 a.m., David Rosca wrote: > > --- > This is an automatically generated e-mail

Re: [Kde-hardware-devel] Review Request 123388: BluetoothMonitor: Simplify addBluetoothConnection + add haveBluetoothConnection

2015-04-17 Thread David Rosca
izard appears when trying to add dun connection. Thanks, David Rosca ___ Kde-hardware-devel mailing list Kde-hardware-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-hardware-devel

[Kde-hardware-devel] Review Request 123388: Simplify BluetoothMonitor

2015-04-16 Thread David Rosca
board.kde.org/r/123388/diff/ Testing --- Works as before, mobile connection wizard appears when trying to add dun connection. Thanks, David Rosca ___ Kde-hardware-devel mailing list Kde-hardware-devel@kde.org https://mail.kde.org/mailman

Re: [Kde-hardware-devel] Review Request 123164: Add new Bluetooth applet

2015-04-04 Thread David Rosca
marked as submitted. Review request for Bluedevil and Plasma. Changes --- Submitted with commit 25b43374519e189c3c5c0f4ce24ff343da392055 by David Rosca to branch bluezqt. Repository: bluedevil Description --- This is a replacement for bluedevil-monolithic. The code is based on

Re: [Kde-hardware-devel] Review Request 123164: Add new Bluetooth applet

2015-04-02 Thread David Rosca
pplet6.png https://git.reviewboard.kde.org/media/uploaded/files/2015/03/31/d8ffae3d-f4f4-4bf1-b5ad-27d1298d4d3f__btapplet6.png btapplet7.png https://git.reviewboard.kde.org/media/uploaded/files/2015/03/31/957074cc-acf4-40b1-bb08-857ac6937669__btapplet7.png Thanks, D

Re: [Kde-hardware-devel] Review Request 123164: Add new Bluetooth applet

2015-03-31 Thread David Rosca
--- On March 31, 2015, 9:22 a.m., David Rosca wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/123164/ > -

Re: [Kde-hardware-devel] Review Request 123164: Add new Bluetooth applet

2015-03-31 Thread David Rosca
files/2015/03/31/d8ffae3d-f4f4-4bf1-b5ad-27d1298d4d3f__btapplet6.png btapplet7.png https://git.reviewboard.kde.org/media/uploaded/files/2015/03/31/957074cc-acf4-40b1-bb08-857ac6937669__btapplet7.png Thanks, David Rosca ___ Kde-hardware-devel mailing

Re: [Kde-hardware-devel] Review Request 123164: Add new Bluetooth applet

2015-03-30 Thread David Rosca
ed e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123164/#review78206 ------- On March 29, 2015, 8:13 p.m., David Rosca wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.

Re: [Kde-hardware-devel] Review Request 123164: Add new Bluetooth applet

2015-03-29 Thread David Rosca
-830d-91dc5ed5c574__snapshot4.png snapshot5.png https://git.reviewboard.kde.org/media/uploaded/files/2015/03/28/d0cab8ca-a62b-4672-9600-cbd61de25c63__snapshot5.png Thanks, David Rosca ___ Kde-hardware-devel mailing list Kde-hardware-devel@kde.org https://mail.kd

Re: [Kde-hardware-devel] Review Request 123164: Add new Bluetooth applet

2015-03-29 Thread David Rosca
> On March 29, 2015, 6 p.m., Kai Uwe Broulik wrote: > > File Attachment: snapshot5.png - snapshot5.png > > <https://git.reviewboard.kde.org/r/123164/#fcomment385> > > > > I wouldn't show the ID right at a glance. That's super geeky. Hide that &

Re: [Kde-hardware-devel] Review Request 123164: Add new Bluetooth applet

2015-03-29 Thread David Rosca
t; > > > > Is it really neccessary to be able to turn sections off? No :D Ok, I will drop the whole config. - David --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123164/#review78179 ---

Re: [Kde-hardware-devel] Review Request 123164: Add new Bluetooth applet

2015-03-29 Thread David Rosca
-a62b-4672-9600-cbd61de25c63__snapshot5.png Thanks, David Rosca ___ Kde-hardware-devel mailing list Kde-hardware-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-hardware-devel

Re: [Kde-hardware-devel] Review Request 123164: Add new Bluetooth applet

2015-03-29 Thread David Rosca
ready and it works fine. > > > File Attachments > > > snapshot4.png > > https://git.reviewboard.kde.org/media/uploaded/files/2015/03/28/acba4387-a4e7-4e77-830d-91dc5ed5c574__snapshot4.png > snapshot5.png > > https://git.reviewboard.kde.org

Re: [Kde-hardware-devel] Review Request 123164: Add new Bluetooth applet

2015-03-29 Thread David Rosca
-9600-cbd61de25c63__snapshot5.png Thanks, David Rosca ___ Kde-hardware-devel mailing list Kde-hardware-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-hardware-devel

Re: [Kde-hardware-devel] Review Request 123164: Add new Bluetooth applet

2015-03-29 Thread David Rosca
sit: https://git.reviewboard.kde.org/r/123164/#review78160 ------- On March 28, 2015, 7:43 p.m., David Rosca wrote: > > --- > This is an automatically generated e-mail. To re

[Kde-hardware-devel] Review Request 123164: Add new Bluetooth applet

2015-03-28 Thread David Rosca
https://git.reviewboard.kde.org/media/uploaded/files/2015/03/28/acba4387-a4e7-4e77-830d-91dc5ed5c574__snapshot4.png snapshot5.png https://git.reviewboard.kde.org/media/uploaded/files/2015/03/28/d0cab8ca-a62b-4672-9600-cbd61de25c63__snapshot5.png Thanks, David

Re: [Kde-hardware-devel] Review Request 122785: Update .desktop files to use org.kde schema

2015-03-10 Thread David Rosca
marked as submitted. Review request for Bluedevil. Changes --- Submitted with commit f8e5b8e9f88326870c3e10432a214b175c073c56 by David Rosca to branch master. Repository: bluedevil Description --- Update .desktop files to use org.kde schema In case of bluedevil-wizard and

[Kde-hardware-devel] Review Request 122785: Update .desktop files to use org.kde schema

2015-03-03 Thread David Rosca
-CREATION src/wizard/CMakeLists.txt d615f3d src/monolithic/CMakeLists.txt f39964e src/monolithic/bluedevil-monolithic.desktop 2f6f6f2 Diff: https://git.reviewboard.kde.org/r/122785/diff/ Testing --- Everything seems to work fine Thanks, David Rosca

Re: [Kde-hardware-devel] Review Request 121179: Power: Add aboutToSuspend signal

2014-12-12 Thread David Rosca
://git.reviewboard.kde.org/r/121179/diff/ Testing --- Signal is correctly emitted in solid-power listen. Thanks, David Rosca ___ Kde-hardware-devel mailing list Kde-hardware-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-hardware-devel

[Kde-hardware-devel] Review Request 121179: Power: Add aboutToSuspend signal

2014-11-19 Thread David Rosca
-power listen. Thanks, David Rosca ___ Kde-hardware-devel mailing list Kde-hardware-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-hardware-devel

Re: [Kde-hardware-devel] Review Request 118875: Port wizard away from KDELibs4Support

2014-07-13 Thread David Rosca
/pages/fail.cpp 110f274 src/wizard/pages/keyboardpairing.h 9b06a9a src/wizard/pages/keyboardpairing.cpp ff3d1e9 src/wizard/pages/legacypairing.h c822bd5 src/wizard/pages/legacypairing.cpp 7a954cc Diff: https://git.reviewboard.kde.org/r/118875/diff/ Testing --- Thanks, David Rosca

Re: [Kde-hardware-devel] Review Request 118877: Port kio modules away from KDELibs4Support

2014-07-13 Thread David Rosca
/obexftp/debug_p.h PRE-CREATION src/kio/obexftp/debug_p.cpp PRE-CREATION src/kio/obexftp/kio_obexftp.h d105f3c src/kio/obexftp/kio_obexftp.cpp 35d4067 src/kio/obexftp/transferfilejob.cpp cf479c3 Diff: https://git.reviewboard.kde.org/r/118877/diff/ Testing --- Thanks, David Rosca

Re: [Kde-hardware-devel] Review Request 118875: Port wizard away from KDELibs4Support

2014-06-24 Thread David Rosca
/fail.cpp 110f274 src/wizard/pages/keyboardpairing.h 9b06a9a src/wizard/pages/keyboardpairing.cpp ff3d1e9 src/wizard/pages/legacypairing.h c822bd5 src/wizard/pages/legacypairing.cpp 7a954cc Diff: https://git.reviewboard.kde.org/r/118875/diff/ Testing --- Thanks, David Rosca

Re: [Kde-hardware-devel] Review Request 118877: Port kio modules away from KDELibs4Support

2014-06-24 Thread David Rosca
/debug_p.h PRE-CREATION src/kio/obexftp/debug_p.cpp PRE-CREATION src/kio/obexftp/kio_obexftp.h d105f3c src/kio/obexftp/kio_obexftp.cpp 35d4067 src/kio/obexftp/transferfilejob.cpp cf479c3 Diff: https://git.reviewboard.kde.org/r/118877/diff/ Testing --- Thanks, David Rosca

Re: [Kde-hardware-devel] Review Request 118874: Port kcmodule away from KDELibs4Support

2014-06-22 Thread David Rosca
g --- Thanks, David Rosca ___ Kde-hardware-devel mailing list Kde-hardware-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-hardware-devel

Re: [Kde-hardware-devel] Review Request 118878: Fix incorrect filename when receiving files

2014-06-22 Thread David Rosca
regardless of contents of temp folder. Thanks, David Rosca ___ Kde-hardware-devel mailing list Kde-hardware-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-hardware-devel

[Kde-hardware-devel] Review Request 118878: Fix incorrect filename when receiving files

2014-06-22 Thread David Rosca
/filereceiver/receivefilejob.h f520bac src/daemon/kded/filereceiver/receivefilejob.cpp 2bce27f Diff: https://git.reviewboard.kde.org/r/118878/diff/ Testing --- Transfers always use correct filename regardless of contents of temp folder. Thanks, David Rosca

[Kde-hardware-devel] Review Request 118875: Port wizard away from KDELibs4Support

2014-06-22 Thread David Rosca
src/wizard/wizardagent.cpp 864d02a Diff: https://git.reviewboard.kde.org/r/118875/diff/ Testing --- Thanks, David Rosca ___ Kde-hardware-devel mailing list Kde-hardware-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-hardware-devel

[Kde-hardware-devel] Review Request 118877: Port kio modules away from KDELibs4Support

2014-06-22 Thread David Rosca
://git.reviewboard.kde.org/r/118877/diff/ Testing --- Thanks, David Rosca ___ Kde-hardware-devel mailing list Kde-hardware-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-hardware-devel

[Kde-hardware-devel] Review Request 118874: Port kcmodule away from KDELibs4Support

2014-06-22 Thread David Rosca
redfilesdialog.cpp cdc1ab9 src/kcmodule/systemcheck.h e03daf9 src/kcmodule/systemcheck.cpp 97d37b2 src/kcmodule/transfer.ui 6c6cf74 Diff: https://git.reviewboard.kde.org/r/118874/diff/ Testing --- Thanks, David Rosca ___ Kde-hardware-

Re: [Kde-hardware-devel] Review Request 117936: Port daemon from KDELibs4Support

2014-05-14 Thread David Rosca
--- Thanks, David Rosca ___ Kde-hardware-devel mailing list Kde-hardware-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-hardware-devel

Re: [Kde-hardware-devel] Review Request 117936: Port daemon from KDELibs4Support

2014-05-05 Thread David Rosca
ver.kcfg 457506a Diff: https://git.reviewboard.kde.org/r/117936/diff/ Testing --- Thanks, David Rosca ___ Kde-hardware-devel mailing list Kde-hardware-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-hardware-devel

Re: [Kde-hardware-devel] Review Request 117943: Port sendfile from KDELibs4Support

2014-05-05 Thread David Rosca
d156f Diff: https://git.reviewboard.kde.org/r/117943/diff/ Testing --- Thanks, David Rosca ___ Kde-hardware-devel mailing list Kde-hardware-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-hardware-devel

Re: [Kde-hardware-devel] Review Request 117939: Port monolithic from KDELibs4Support

2014-05-05 Thread David Rosca
src/monolithic/monolithic.cpp 980531a Diff: https://git.reviewboard.kde.org/r/117939/diff/ Testing --- Thanks, David Rosca ___ Kde-hardware-devel mailing list Kde-hardware-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-hardware-devel

[Kde-hardware-devel] Review Request 117943: Port sendfile from KDELibs4Support

2014-05-02 Thread David Rosca
pages/selectfilediscover.ui b85e85c src/sendfile/pages/selectfilespage.cpp 423b772 src/sendfile/sendfilesjob.h e230a4a src/sendfile/sendfilesjob.cpp 339c3a5 src/sendfile/sendfilewizard.cpp 87d156f Diff: https://git.reviewboard.kde.org/r/117943/diff/ Testing --- Thanks, David

[Kde-hardware-devel] Review Request 117939: Port monolithic from KDELibs4Support

2014-05-02 Thread David Rosca
/ Testing --- Thanks, David Rosca ___ Kde-hardware-devel mailing list Kde-hardware-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-hardware-devel

[Kde-hardware-devel] Review Request 117936: Port daemon from KDELibs4Support

2014-05-02 Thread David Rosca
rg/r/117936/diff/ Testing --- Thanks, David Rosca ___ Kde-hardware-devel mailing list Kde-hardware-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-hardware-devel

Re: [Kde-hardware-devel] Review Request 117841: Initial port to KF5

2014-05-01 Thread David Rosca
--- Build & run fine with latest KF5 and Plasma. Thanks, David Rosca ___ Kde-hardware-devel mailing list Kde-hardware-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-hardware-devel

Re: [Kde-hardware-devel] Review Request 117840: Port to Qt5

2014-05-01 Thread David Rosca
/bluedevildevice.cpp 884d015 bluedevil/bluedevilmanager.cpp e5848be bluedevil/bluedevilmanager_p.cpp ad32470 bluedevil/test/CMakeLists.txt 8f12785 Diff: https://git.reviewboard.kde.org/r/117840/diff/ Testing --- Thanks, David Rosca ___ Kde-hardware

[Kde-hardware-devel] Review Request 117841: Initial port to KF5

2014-04-28 Thread David Rosca
f7c065e src/wizard/pages/legacypairingdatabase.cpp 5d4872f src/wizard/pages/ssppairing.cpp 3962e14 src/wizard/wizardagent.cpp 56b2ad7 Diff: https://git.reviewboard.kde.org/r/117841/diff/ Testing --- Build & run fine with latest KF5 and Plasma. Thanks, David R

[Kde-hardware-devel] Review Request 117840: Port to Qt5

2014-04-28 Thread David Rosca
ad32470 bluedevil/test/CMakeLists.txt 8f12785 Diff: https://git.reviewboard.kde.org/r/117840/diff/ Testing --- Thanks, David Rosca ___ Kde-hardware-devel mailing list Kde-hardware-devel@kde.org https://mail.kde.org/mailman/listinfo/kde

Re: [Kde-hardware-devel] [GSoC] Project: Make Libbluedevil Async

2014-03-16 Thread David Rosca
Thanks! Here is a public url for the proposal: https://www.google-melange.com/gsoc/proposal/public/google/gsoc2014/nowrep/5662278724616192 David 2014-03-16 15:44 GMT+01:00 Àlex Fiestas : > Those are some sexy apis! > > Please submit the proposal to Melange, it looks good to me. > > _

Re: [Kde-hardware-devel] [GSoC] Project: Make Libbluedevil Async

2014-03-14 Thread David Rosca
Hi all, I'm sending you a first version of my proposal. Àlex, and possibly others, can you please take a look at it? Thanks in advance, David Rosca --- Name: David Rosca Email Address: now...@gmail.com Freenode IRC Nick: n

[Kde-hardware-devel] [GSoC] Project: Make Libbluedevil Async

2014-03-03 Thread David Rosca
e class) method for making async calls. Should the other classes be made asynchronous this way too (so both synchronous and asynchronous API is available)? Or change the API, that it will only be available asynchronous? Thanks, David Rosca [1] https://github.com/nowrep [2] https://google-melange.a