Re: [Kde-hardware-devel] Review Request 122403: [OS X] adaptations to phonon component.

2016-04-15 Thread Harald Sitter
code looks fine in general. - Harald Sitter On Feb. 3, 2015, 12:41 p.m., René J.V. Bertin wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard

Re: [Kde-hardware-devel] Review Request 123047: explicitly find and use kdbusaddons

2015-03-19 Thread Harald Sitter
marked as submitted. Review request for Plasma and Solid. Changes --- Submitted with commit f82a0196dbc5623c137c14e3a7105afb799f77eb by Harald Sitter to branch Plasma/5.2. Repository: powerdevil Description --- the kded module needs the KDEDModule header which is provided by

[Kde-hardware-devel] Review Request 123047: explicitly find and use kdbusaddons

2015-03-19 Thread Harald Sitter
f9028d3b387d462a584e299b871dd6cc2fdc9907 daemon/CMakeLists.txt f1e6efbdf205282076251d7b975a6a448f818873 Diff: https://git.reviewboard.kde.org/r/123047/diff/ Testing --- make && make install && make test Thanks, Harald Sitter ___ Kd

Re: [Kde-hardware-devel] Review Request 122404: [OS X]: draft support for audio in the IOKit backend

2015-02-03 Thread Harald Sitter
in turn is pulseaudio listing || backend listing). So, enabling VLC to expose this information through the libvlc_audio_output_device enumerable would be the best course of action. If the VLC devs don't want that or whatever, then putting it in Phonon seems the most useful approach. - H

Re: [Kde-hardware-devel] Review Request 114393: Add support for logind interfaces on upstart >= 1.11

2013-12-18 Thread Harald Sitter
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114393/#review45917 --- Ship it! Ship It! - Harald Sitter On Dec. 18, 2013, 6:54

Re: [Kde-hardware-devel] Review Request 114393: Add support for logind interfaces on upstart >= 1.11

2013-12-10 Thread Harald Sitter
/powerdevilupowerbackend.cpp <http://git.reviewboard.kde.org/r/114393/#comment32458> I think a regex would be more readable really. - Harald Sitter On Dec. 10, 2013, 6:25 p.m., Rohan Garg wrote: > > --- > This is an automatically gener

Re: [Kde-hardware-devel] Review Request: Fix bug: generateProfiles generates a config where lidClose event is turn of screen.

2012-10-14 Thread Harald Sitter
uments are not needed (and that they are in fact not needed...) - Harald Sitter On Oct. 14, 2012, 11:20 p.m., Alex Fiestas wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://git.revie