Re: [Kde-hardware-devel] Review Request 126381: kwayland backend for libkscreen

2016-01-04 Thread Hrvoje Senjan
> On Dec. 24, 2015, 9:23 p.m., Hrvoje Senjan wrote: > > backends/CMakeLists.txt, line 3 > > <https://git.reviewboard.kde.org/r/126381/diff/7/?file=424946#file424946line3> > > > > Either this should be guarded by KF5Wayland_FOUND, or KF5Wayland should

Re: [Kde-hardware-devel] Review Request 126381: kwayland backend for libkscreen

2015-12-24 Thread Hrvoje Senjan
tps://git.reviewboard.kde.org/r/126381/#comment61717> Either this should be guarded by KF5Wayland_FOUND, or KF5Wayland should be marked as required in top CMakeLists.tyt - Hrvoje Senjan On Dec. 22, 2015, 12:46 a.m., Sebastian Kügler wrote: > > -

Re: [Kde-hardware-devel] Review Request 122414: Port DPMS to XCB

2015-02-07 Thread Hrvoje Senjan
414/#comment52278> you can kill this one... also in the config-workspace.h.cmake (there is a bunch of unused stuff there though) - Hrvoje Senjan On Feb. 6, 2015, 10:22 p.m., Kai Uwe Broulik wrote: > > --- > This is a

Re: [Kde-hardware-devel] Review Request 122151: Invert the KJob::Exec check logic

2015-02-07 Thread Hrvoje Senjan
Diff: https://git.reviewboard.kde.org/r/122151/diff/ Testing --- resolves the bug for me (i have the brightness control in the battery applet now) Thanks, Hrvoje Senjan ___ Kde-hardware-devel mailing list Kde-hardware-devel@kde.org https

[Kde-hardware-devel] Review Request 122151: Invert the KJob::Exec check logic

2015-01-19 Thread Hrvoje Senjan
bug for me (i have the brightness control in the battery applet now) Thanks, Hrvoje Senjan ___ Kde-hardware-devel mailing list Kde-hardware-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-hardware-devel

Re: [Kde-hardware-devel] Review Request 121355: Expose actual and maximum brightness value in dataengine

2014-12-07 Thread Hrvoje Senjan
> On Dec. 6, 2014, 12:39 a.m., Hrvoje Senjan wrote: > > i've lost brightness control in battery monitor after this change. > > brightnessValueMax returns 9, but Screen Brightness Available is false > > anyway > > Kai Uwe Broulik wrote: > Please update y

Re: [Kde-hardware-devel] Review Request 121355: Expose actual and maximum brightness value in dataengine

2014-12-07 Thread Hrvoje Senjan
> On Dec. 6, 2014, 12:39 a.m., Hrvoje Senjan wrote: > > i've lost brightness control in battery monitor after this change. > > brightnessValueMax returns 9, but Screen Brightness Available is false > > anyway > > Kai Uwe Broulik wrote: > Please update y

Re: [Kde-hardware-devel] Review Request 121355: Expose actual and maximum brightness value in dataengine

2014-12-05 Thread Hrvoje Senjan
> On Dec. 6, 2014, 12:39 a.m., Hrvoje Senjan wrote: > > i've lost brightness control in battery monitor after this change. > > brightnessValueMax returns 9, but Screen Brightness Available is false > > anyway > > Kai Uwe Broulik wrote: > Please update y

Re: [Kde-hardware-devel] Review Request 121355: Expose actual and maximum brightness value in dataengine

2014-12-05 Thread Hrvoje Senjan
this change. brightnessValueMax returns 9, but Screen Brightness Available is false anyway - Hrvoje Senjan On Dec. 5, 2014, 10:06 p.m., Kai Uwe Broulik wrote: > > --- > This is an automatically generated e-mail. To reply,

Re: [Kde-hardware-devel] Review Request 120526: Strip PowerDevilCore, PowerDevilUI and PowerDevil's kded from kdelibs4support

2014-10-16 Thread Hrvoje Senjan
ui 2b5585c kcmodule/profiles/CMakeLists.txt 1a13bb3 kcmodule/profiles/EditPage.cpp 5c7578d Diff: https://git.reviewboard.kde.org/r/120526/diff/ Testing --- builds, kded is succesfully initialized, reducing/increasing brightness work Thanks, Hrv

Re: [Kde-hardware-devel] Review Request 120526: Strip PowerDevilCore, PowerDevilUI and PowerDevil's kded from kdelibs4support

2014-10-12 Thread Hrvoje Senjan
pp cdad263 kcmodule/global/generalPage.ui 2b5585c kcmodule/profiles/CMakeLists.txt 1a13bb3 kcmodule/profiles/EditPage.cpp 5c7578d Diff: https://git.reviewboard.kde.org/r/120526/diff/ Testing --- builds, kded is succesfully initialized, reducing/increasing brightness work Thanks, Hrv

Re: [Kde-hardware-devel] Review Request 120526: Strip PowerDevilCore, PowerDevilUI and PowerDevil's kded from kdelibs4support

2014-10-12 Thread Hrvoje Senjan
uccesfully initialized, reducing/increasing brightness work Thanks, Hrvoje Senjan ___ Kde-hardware-devel mailing list Kde-hardware-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-hardware-devel

Re: [Kde-hardware-devel] Review Request 120526: Strip PowerDevilCore, PowerDevilUI and PowerDevil's kded from kdelibs4support

2014-10-08 Thread Hrvoje Senjan
ns/bundled/keyboardbrightnesscontrolconfig.h c546fd7 daemon/actions/bundled/runscriptconfig.h 7ad61cf Diff: https://git.reviewboard.kde.org/r/120526/diff/ Testing --- builds, kded is succesfully initialized, reducing/increasing brightness work Thanks, Hrv

[Kde-hardware-devel] Review Request 120526: Strip PowerDevilCore, PowerDevilUI and PowerDevil's kded from kdelibs4support

2014-10-07 Thread Hrvoje Senjan
daemon/backends/upower/powerdevilupowerbackend.h beb12aa Diff: https://git.reviewboard.kde.org/r/120526/diff/ Testing --- builds, kded is succesfully initialized, reducing/increasing brightness work Thanks, Hrvoje Senjan ___ Kde-hardware-dev

Re: [Kde-hardware-devel] Review Request 115271: Make sure that the right version of systemd is found as that git master systemd only returns a number

2014-02-25 Thread Hrvoje Senjan
this review resolves the problem... - Hrvoje Senjan On Jan. 24, 2014, 11:29 a.m., Raymond Wooninck wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.

Re: [Kde-hardware-devel] Review Request 114927: rename dbus interface files in solid

2014-01-26 Thread Hrvoje Senjan
> On Jan. 25, 2014, 3:56 p.m., Scarlett Clark wrote: > > This is becoming a big issue the farther into teir 3 packaging I get. In my > > humble opinion renaming the xml files (appending a 5) would make everything > > happy. > > Michael Palimaka wrote: > In other frameworks, the change has

Re: [Kde-hardware-devel] Review Request 114927: rename dbus interface files in solid

2014-01-22 Thread Hrvoje Senjan
tps://git.reviewboard.kde.org/r/114927/#comment34034> Is this change needed? Only XML names changed, interfaces are the same (at least in this diff) Same for other changes in this file. I'd keep interfaces as they are, and only rename xml's, but that's more for Solid guys to say ;-) - H

Re: [Kde-hardware-devel] Review Request 110135: Adjust to new suspend session handling

2013-04-24 Thread Hrvoje Senjan
plasma/generic/dataengines/time/CMakeLists.txt 007a60a plasma/generic/dataengines/time/timeengine.cpp 2f69e8f plasma/generic/runners/powerdevil/PowerDevilRunner.cpp 74eb36d Diff: http://git.reviewboard.kde.org/r/110135/diff/ Testing --- Compiled, actions work now. Thanks, Hrvoje

Re: [Kde-hardware-devel] Review Request 110135: Adjust to new suspend session handling

2013-04-24 Thread Hrvoje Senjan
--- Compiled, actions work now. Thanks, Hrvoje Senjan ___ Kde-hardware-devel mailing list Kde-hardware-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-hardware-devel

Re: [Kde-hardware-devel] Review Request 110135: Adjust to new suspend session handling

2013-04-23 Thread Hrvoje Senjan
6f90006 plasma/generic/dataengines/time/timeengine.cpp 2f69e8f plasma/generic/runners/powerdevil/PowerDevilRunner.cpp 74eb36d Diff: http://git.reviewboard.kde.org/r/110135/diff/ Testing --- Compiled, actions work now. Thanks, Hrvoje Senjan

Re: [Kde-hardware-devel] Review Request 110135: Adjust to new suspend session handling

2013-04-23 Thread Hrvoje Senjan
://git.reviewboard.kde.org/r/110135/diff/ Testing --- Compiled, actions work now. Thanks, Hrvoje Senjan ___ Kde-hardware-devel mailing list Kde-hardware-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-hardware-devel

Re: [Kde-hardware-devel] Review Request 110135: Adjust Kickoff actions to latest Powerdevil changes

2013-04-23 Thread Hrvoje Senjan
t FDO's). - Hrvoje --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110135/#review31459 --- On April 23, 2013, 5:28

[Kde-hardware-devel] Review Request 110135: Adjust Kickoff actions to latest Powerdevil changes

2013-04-23 Thread Hrvoje Senjan
://git.reviewboard.kde.org/r/110135/diff/ Testing --- Compiled, actions work now. Thanks, Hrvoje Senjan ___ Kde-hardware-devel mailing list Kde-hardware-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-hardware-devel