Le Mardi 27 Juin 2006 07:23, Martin (KaFai), Lau a écrit : > I screen through the solid svn tree. I think I have a rough idea... I am > probably wrong in many of them though ^_^ > > Having said that, I am still dare to put up my little idea, ask for > correction and learn from the mistakes before jumping off the cliff. Here > is my idea on powermanger with HAL backend
At first glance it looks almost ok, a few comments though: - Inheritance from Solid::Ifaces::PowerManager MUST NOT be virtual - Constructor must have a second parameter: const QStringList &args, otherwise you won't be able to use it as a module - You're not forced to have the members in a HalPowerManagerPrivate d pointer. It has been done this way in the HalDeviceManager for historical reasons but for backends d pointers are mandatory, and not using them might simplify your code a bit. - Regarding the Battery member, you surely want to have a list of batteries, because some system have several of them. Regards. -- Kévin 'ervin' Ottens, http://ervin.ipsquad.net "Ni le maître sans disciple, Ni le disciple sans maître, Ne font reculer l'ignorance."
pgpktSxrRdNum.pgp
Description: PGP signature
_______________________________________________ Kde-hardware-devel mailing list Kde-hardware-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-hardware-devel
