[Kde-hardware-devel] Re: Review Request: Add a resumingFromSuspend signal to PowerManager::Notifier

2011-01-03 Thread Kevin Ottens
--- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/6119/#review9490 --- No go API wise IMO. Only the signal should be in the public API an

[Kde-hardware-devel] Re: Review Request: Add a resumingFromSuspend signal to PowerManager::Notifier

2011-01-03 Thread Dario Freddi
> On 2011-01-03 18:50:58, Kevin Ottens wrote: > > No go API wise IMO. Only the signal should be in the public API and that's > > it, anything else is showing implementation details to the outside I think. Well, the main rationale behind it is that the signal can be indeed not be emitted at all

[Kde-hardware-devel] Re: Review Request: Add a resumingFromSuspend signal to PowerManager::Notifier

2011-01-03 Thread Kevin Ottens
> On 2011-01-03 18:50:58, Kevin Ottens wrote: > > No go API wise IMO. Only the signal should be in the public API and that's > > it, anything else is showing implementation details to the outside I think. > > Dario Freddi wrote: > Well, the main rationale behind it is that the signal can be

[Kde-hardware-devel] Re: Review Request: Add a resumingFromSuspend signal to PowerManager::Notifier

2011-01-06 Thread Dario Freddi
--- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/6119/ --- (Updated 2011-01-06 17:08:24.443028) Review request for Solid and Kevin Otte

[Kde-hardware-devel] Re: Review Request: Add a resumingFromSuspend signal to PowerManager::Notifier

2011-01-06 Thread Kevin Ottens
--- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/6119/#review9551 --- Ship it! Looks good now. - Kevin On 2011-01-06 17:08:24, Dario