Re: [Kde-hardware-devel] Review Request: Make appShouldConserResources() reliable

2012-06-21 Thread Lukáš Tinkl
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105310/#review14930 --- Ship it! Besides the white space change, looks good to me -

Re: [Kde-hardware-devel] Review Request: Make appShouldConserResources() reliable

2012-06-21 Thread Dario Freddi
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105310/#review14934 --- Ship it! Ship It! - Dario Freddi On June 20, 2012, 9:41

Re: [Kde-hardware-devel] Review Request: Make appShouldConserResources() reliable

2012-06-21 Thread Daniel Nicoletti
On June 20, 2012, 10:29 p.m., Lamarque Vieira Souza wrote: solid/solid/powermanagement.cpp, line 236 http://git.reviewboard.kde.org/r/105310/diff/1/?file=69989#file69989line236 The famous default complaint: remove extra space, please. The rest of the code is Ok from my

[Kde-hardware-devel] Review Request: Make appShouldConserResources() reliable

2012-06-20 Thread Daniel Nicoletti
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105310/ --- Review request for Solid. Description --- Without this patch the

Re: [Kde-hardware-devel] Review Request: Make appShouldConserResources() reliable

2012-06-20 Thread Lamarque Vieira Souza
On June 20, 2012, 10:29 p.m., Lamarque Vieira Souza wrote: solid/solid/powermanagement.cpp, line 236 http://git.reviewboard.kde.org/r/105310/diff/1/?file=69989#file69989line236 The famous default complaint: remove extra space, please. The rest of the code is Ok from my