Re: [Kde-hardware-devel] Review Request 108912: Port libbluedevil to Bluez 5

2013-03-17 Thread Daniel Schaal
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108912/ --- (Updated March 17, 2013, 10:50 a.m.) Status -- This change has been m

Re: [Kde-hardware-devel] Review Request 108912: Port libbluedevil to Bluez 5

2013-03-16 Thread Àlex Fiestas
> On March 16, 2013, 9:56 p.m., Àlex Fiestas wrote: > > Besides the spaces (reviewboard paints a big red square for them xD) > > everything seems ok, at least code wise. > > > > I have yet to learn all the changes in BlueZ so I can't really evaluate > > whether your changes are correct or not,

Re: [Kde-hardware-devel] Review Request 108912: Port libbluedevil to Bluez 5

2013-03-16 Thread Àlex Fiestas
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108912/#review29338 --- Ship it! Besides the spaces (reviewboard paints a big red squa

Re: [Kde-hardware-devel] Review Request 108912: Port libbluedevil to Bluez 5

2013-03-16 Thread Àlex Fiestas
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108912/#review29337 --- bluedevil/bluedeviladapter.cpp

Re: [Kde-hardware-devel] Review Request 108912: Port libbluedevil to Bluez 5

2013-03-16 Thread Daniel Schaal
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108912/ --- (Updated March 16, 2013, 4:34 p.m.) Review request for Bluedevil. Change

Re: [Kde-hardware-devel] Review Request 108912: Port libbluedevil to Bluez 5

2013-03-10 Thread Àlex Fiestas
> On March 6, 2013, 10:28 p.m., Àlex Fiestas wrote: > > WoW! this is a lot of work ! > > > > Sorry for the delay but reviewboard forgot to send me this review > > apparently :/ > > > > Will make review the next weekend. Do you have a KDE account? you are going > > to need one so we can work o