Re: [Kde-hardware-devel] Review Request 109384: Move advancedDiscDetect to daemon

2013-03-11 Thread Alexander Mezin
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109384/ --- (Updated March 11, 2013, 1:18 p.m.) Review request for Solid and Lukáš Tin

Re: [Kde-hardware-devel] Review Request 109384: Move advancedDiscDetect to daemon

2013-03-12 Thread Dan Vrátil
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109384/#review29073 --- This is not right. If you want to have a daemon, you should wri

Re: [Kde-hardware-devel] Review Request 109384: Move advancedDiscDetect to daemon

2013-03-12 Thread Alexander Mezin
> On March 12, 2013, 3:14 p.m., Dan Vrátil wrote: > > This is not right. If you want to have a daemon, you should write a KDED > > module and modify Solid (frontend or backends) to access the information > > from the daemon. I've just got an idea that it would be better if the daemon will be c

Re: [Kde-hardware-devel] Review Request 109384: Move advancedDiscDetect to daemon

2013-03-13 Thread Dan Vrátil
> On March 12, 2013, 4:14 p.m., Dan Vrátil wrote: > > This is not right. If you want to have a daemon, you should write a KDED > > module and modify Solid (frontend or backends) to access the information > > from the daemon. > > Alexander Mezin wrote: > I've just got an idea that it would

Re: [Kde-hardware-devel] Review Request 109384: Move advancedDiscDetect to daemon

2013-03-13 Thread Alexander Mezin
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109384/ --- (Updated March 14, 2013, 3:31 a.m.) Review request for Solid and Lukáš Tin

Re: [Kde-hardware-devel] Review Request 109384: Move advancedDiscDetect to daemon

2013-03-14 Thread Lukáš Tinkl
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109384/#review29184 --- Please also test with special media, like blank and audio CDs.

Re: [Kde-hardware-devel] Review Request 109384: Move advancedDiscDetect to daemon

2013-03-14 Thread Alexander Mezin
> On March 14, 2013, 10:40 a.m., Lukáš Tinkl wrote: > > Please also test with special media, like blank and audio CDs. Thanks for > > the work! I didn't touch code that handles other disk types, as only video disk detection caused problems. And I don't have audio cds, sorry. But other people t

Re: [Kde-hardware-devel] Review Request 109384: Move advancedDiscDetect to daemon

2013-03-14 Thread Dan Vrátil
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109384/#review29211 --- The code looks fine, thanks! There's another concern now, how

Re: [Kde-hardware-devel] Review Request 109384: Move advancedDiscDetect to daemon

2013-03-14 Thread Alexander Mezin
> On March 14, 2013, 3:02 p.m., Dan Vrátil wrote: > > The code looks fine, thanks! > > > > There's another concern now, however (something that I haven't thought > > about before, sorry!) - if the code now depends on kdelibs, we don't fit > > Tear 1 in KDE Frameworks anymore. The question is

Re: [Kde-hardware-devel] Review Request 109384: Move advancedDiscDetect to daemon

2013-03-15 Thread Alexander Mezin
> On March 14, 2013, 3:02 p.m., Dan Vrátil wrote: > > The code looks fine, thanks! > > > > There's another concern now, however (something that I haven't thought > > about before, sorry!) - if the code now depends on kdelibs, we don't fit > > Tear 1 in KDE Frameworks anymore. The question is

Re: [Kde-hardware-devel] Review Request 109384: Move advancedDiscDetect to daemon

2013-03-16 Thread Alexander Mezin
> On March 14, 2013, 3:02 p.m., Dan Vrátil wrote: > > The code looks fine, thanks! > > > > There's another concern now, however (something that I haven't thought > > about before, sorry!) - if the code now depends on kdelibs, we don't fit > > Tear 1 in KDE Frameworks anymore. The question is

Re: [Kde-hardware-devel] Review Request 109384: Move advancedDiscDetect to daemon

2013-03-18 Thread Alexander Mezin
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109384/ --- (Updated March 19, 2013, 5:19 a.m.) Review request for Solid and Lukáš Tin

Re: [Kde-hardware-devel] Review Request 109384: Move advancedDiscDetect to daemon

2013-03-26 Thread Alexander Mezin
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109384/ --- (Updated March 26, 2013, 3:17 p.m.) Review request for Solid, Dan Vrátil a

Re: [Kde-hardware-devel] Review Request 109384: Move advancedDiscDetect to daemon

2013-07-26 Thread Alexander Mezin
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109384/ --- (Updated July 26, 2013, 7:52 p.m.) Status -- This change has been dis