Re: [Kde-hardware-devel] Review Request 110841: Fix build with udisks2 backend enabled

2013-06-10 Thread Andrea Scarpino
> On June 5, 2013, 8:56 p.m., Lukáš Tinkl wrote: > > Ship It! > > Kevin Ottens wrote: > This change was wrong, it actually undo work previously done by George > Goldberg. > See his commit e1d5e73ef26233694b87367dfcc50d857e278827. > > This patch being already submitted it should

Re: [Kde-hardware-devel] Review Request 110841: Fix build with udisks2 backend enabled

2013-06-10 Thread Kevin Ottens
> On June 5, 2013, 6:56 p.m., Lukáš Tinkl wrote: > > Ship It! > > Kevin Ottens wrote: > This change was wrong, it actually undo work previously done by George > Goldberg. > See his commit e1d5e73ef26233694b87367dfcc50d857e278827. > > This patch being already submitted it should

Re: [Kde-hardware-devel] Review Request 110841: Fix build with udisks2 backend enabled

2013-06-10 Thread Andrea Scarpino
> On June 5, 2013, 8:56 p.m., Lukáš Tinkl wrote: > > Ship It! > > Kevin Ottens wrote: > This change was wrong, it actually undo work previously done by George > Goldberg. > See his commit e1d5e73ef26233694b87367dfcc50d857e278827. > > This patch being already submitted it should

Re: [Kde-hardware-devel] Review Request 110841: Fix build with udisks2 backend enabled

2013-06-10 Thread Kevin Ottens
> On June 5, 2013, 6:56 p.m., Lukáš Tinkl wrote: > > Ship It! This change was wrong, it actually undo work previously done by George Goldberg. See his commit e1d5e73ef26233694b87367dfcc50d857e278827. This patch being already submitted it should be reverted, and the missing uses of Q_DECLARE_TR

Re: [Kde-hardware-devel] Review Request 110841: Fix build with udisks2 backend enabled

2013-06-05 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110841/ --- (Updated June 5, 2013, 7 p.m.) Status -- This change has been marked

Re: [Kde-hardware-devel] Review Request 110841: Fix build with udisks2 backend enabled

2013-06-05 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110841/#review33819 --- This review has been submitted with commit 71ef88c8c327dbffd3c

Re: [Kde-hardware-devel] Review Request 110841: Fix build with udisks2 backend enabled

2013-06-05 Thread Lukáš Tinkl
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110841/#review33818 --- Ship it! Ship It! - Lukáš Tinkl On June 5, 2013, 8:35 p.m.,

[Kde-hardware-devel] Review Request 110841: Fix build with udisks2 backend enabled

2013-06-05 Thread Andrea Scarpino
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110841/ --- Review request for Solid. Description --- = subject. Same code have