Re: [Kde-hardware-devel] Review Request 114393: Add support for logind interfaces on upstart = 1.11

2014-01-08 Thread Rohan Garg
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114393/ --- (Updated Jan. 8, 2014, 10:45 a.m.) Status -- This change has been

Re: [Kde-hardware-devel] Review Request 114393: Add support for logind interfaces on upstart = 1.11

2014-01-06 Thread Àlex Fiestas
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114393/#review46941 --- Has this been submitted? if so, please close the review. -

Re: [Kde-hardware-devel] Review Request 114393: Add support for logind interfaces on upstart = 1.11

2013-12-18 Thread Àlex Fiestas
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114393/#review45912 --- Ship it! Add a comment explaining why we have to deal with

Re: [Kde-hardware-devel] Review Request 114393: Add support for logind interfaces on upstart = 1.11

2013-12-18 Thread Àlex Fiestas
On Dec. 18, 2013, 6:02 p.m., Àlex Fiestas wrote: Add a comment explaining why we have to deal with upstart if the method is called checkSsytemdVersion. Once that's done, please commit. Oh and also explain it in the commit message, plus say that this won't affect systems using

Re: [Kde-hardware-devel] Review Request 114393: Add support for logind interfaces on upstart = 1.11

2013-12-10 Thread Harald Sitter
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114393/#review45506 --- Ship it!