Re: [Kde-hardware-devel] Review Request 115409: Workaround battery detection at runtime

2014-03-10 Thread Christoph Feck
On March 7, 2014, 12:19 p.m., Christoph Feck wrote: plasma/generic/applets/batterymonitor/contents/ui/batterymonitor.qml, line 75 https://git.reviewboard.kde.org/r/115409/diff/1/?file=241087#file241087line75 Removal of this causes two other regressions: bug 331797, bug 331831.

Re: [Kde-hardware-devel] Review Request 115409: Workaround battery detection at runtime

2014-03-07 Thread Christoph Feck
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115409/#review52338 ---

Re: [Kde-hardware-devel] Review Request 115409: Workaround battery detection at runtime

2014-03-07 Thread Kai Uwe Broulik
On March 7, 2014, 12:19 p.m., Christoph Feck wrote: plasma/generic/applets/batterymonitor/contents/ui/batterymonitor.qml, line 75 https://git.reviewboard.kde.org/r/115409/diff/1/?file=241087#file241087line75 Removal of this causes two other regressions: bug 331797, bug 331831.

Re: [Kde-hardware-devel] Review Request 115409: Workaround battery detection at runtime

2014-03-07 Thread Christoph Feck
On March 7, 2014, 12:19 p.m., Christoph Feck wrote: plasma/generic/applets/batterymonitor/contents/ui/batterymonitor.qml, line 75 https://git.reviewboard.kde.org/r/115409/diff/1/?file=241087#file241087line75 Removal of this causes two other regressions: bug 331797, bug 331831.

Re: [Kde-hardware-devel] Review Request 115409: Workaround battery detection at runtime

2014-02-15 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115409/ --- (Updated Feb. 15, 2014, 4:58 p.m.) Review request for Plasma, Solid and

Re: [Kde-hardware-devel] Review Request 115409: Workaround battery detection at runtime

2014-02-15 Thread Sebastian Kügler
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115409/#review49877 --- Ship it! I've recently debugged a similar issue in Plasma

Re: [Kde-hardware-devel] Review Request 115409: Workaround battery detection at runtime

2014-02-15 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115409/#review49879 --- This review has been submitted with commit

Re: [Kde-hardware-devel] Review Request 115409: Workaround battery detection at runtime

2014-02-15 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115409/ --- (Updated Feb. 15, 2014, 10:19 p.m.) Status -- This change has been

[Kde-hardware-devel] Review Request 115409: Workaround battery detection at runtime

2014-01-30 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115409/ --- Review request for Plasma and Solid. Bugs: 324847