Re: [Kde-hardware-devel] Review Request 118390: Powerdevil KCM Updates

2014-06-03 Thread Thomas Pfeiffer
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118390/#review59054 --- Ship it! Unless I've missed something, it's all fine from my

Re: [Kde-hardware-devel] Review Request 118390: Powerdevil KCM Updates

2014-06-03 Thread Sebastian Kügler
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118390/ --- (Updated June 3, 2014, 3:32 p.m.) Status -- This change has been

Re: [Kde-hardware-devel] Review Request 118390: Powerdevil KCM Updates

2014-06-02 Thread Sebastian Kügler
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118390/ --- (Updated June 2, 2014, 1:35 p.m.) Review request for Plasma, Solid and

Re: [Kde-hardware-devel] Review Request 118390: Powerdevil KCM Updates

2014-06-02 Thread Thomas Pfeiffer
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118390/#review58985 --- Almost there ;) The only title case labels I didn't see fixed

Re: [Kde-hardware-devel] Review Request 118390: Powerdevil KCM Updates

2014-06-02 Thread Sebastian Kügler
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118390/ --- (Updated June 2, 2014, 4:04 p.m.) Review request for Plasma, Solid and

Re: [Kde-hardware-devel] Review Request 118390: Powerdevil KCM Updates

2014-06-02 Thread Andrew Lake
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118390/#review58996 --- The group box HIG has been updated after discussion on the

Re: [Kde-hardware-devel] Review Request 118390: Powerdevil KCM Updates

2014-06-02 Thread Sebastian Kügler
On June 2, 2014, 4:26 p.m., Andrew Lake wrote: The group box HIG has been updated after discussion on the HIG mailing list. Using a group box with the 'flat' property set true is now recommended; it provides a consistent way to use spacing to group visual elements without the line-y,

Re: [Kde-hardware-devel] Review Request 118390: Powerdevil KCM Updates

2014-06-02 Thread Andrew Lake
On June 2, 2014, 4:26 p.m., Andrew Lake wrote: The group box HIG has been updated after discussion on the HIG mailing list. Using a group box with the 'flat' property set true is now recommended; it provides a consistent way to use spacing to group visual elements without the line-y,

Re: [Kde-hardware-devel] Review Request 118390: Powerdevil KCM Updates

2014-06-02 Thread Sebastian Kügler
On June 2, 2014, 4:26 p.m., Andrew Lake wrote: The group box HIG has been updated after discussion on the HIG mailing list. Using a group box with the 'flat' property set true is now recommended; it provides a consistent way to use spacing to group visual elements without the line-y,

Re: [Kde-hardware-devel] Review Request 118390: Powerdevil KCM Updates

2014-05-31 Thread Thomas Pfeiffer
On Friday 30 May 2014 15:34:27 Sebastian Kügler wrote: I'll not change to groupboxes in this review, but anticipate the HIG catching up. :) Yes, that's okay. We'll discuss the grouping HIG on our list. If we come out with a different solution to what you implemented in the end, we'll notify

Re: [Kde-hardware-devel] Review Request 118390: Powerdevil KCM Updates

2014-05-30 Thread Thomas Pfeiffer
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118390/#review58836 --- Looks like there are still quite a few Title Case labels in

Re: [Kde-hardware-devel] Review Request 118390: Powerdevil KCM Updates

2014-05-29 Thread Thomas Pfeiffer
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118390/#review58692 --- Good improvements in general! There are two changes which are

Re: [Kde-hardware-devel] Review Request 118390: Powerdevil KCM Updates

2014-05-29 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118390/#review58693 --- Thanks for looking into this! See my issues below, some of

Re: [Kde-hardware-devel] Review Request 118390: Powerdevil KCM Updates

2014-05-29 Thread Andrew Lake
On May 29, 2014, 8:13 a.m., Thomas Pfeiffer wrote: Good improvements in general! There are two changes which are not HIG-compliant: - Control labels which are written next to the controls (checkboxes, spin boxes etc.) do not use Title Capitalization. See

Re: [Kde-hardware-devel] Review Request 118390: Powerdevil KCM Updates

2014-05-28 Thread Sebastian Kügler
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118390/ --- (Updated May 28, 2014, 11:33 p.m.) Review request for Plasma, Solid and