Re: [Kde-hardware-devel] Review Request 121355: Expose actual and maximum brightness value in dataengine

2014-12-07 Thread Hrvoje Senjan
On Dec. 6, 2014, 12:39 a.m., Hrvoje Senjan wrote: i've lost brightness control in battery monitor after this change. brightnessValueMax returns 9, but Screen Brightness Available is false anyway Kai Uwe Broulik wrote: Please update your plasma-workspace, I've adjusted battery

Re: [Kde-hardware-devel] Review Request 121355: Expose actual and maximum brightness value in dataengine

2014-12-07 Thread Hrvoje Senjan
On Dec. 6, 2014, 12:39 a.m., Hrvoje Senjan wrote: i've lost brightness control in battery monitor after this change. brightnessValueMax returns 9, but Screen Brightness Available is false anyway Kai Uwe Broulik wrote: Please update your plasma-workspace, I've adjusted battery

Re: [Kde-hardware-devel] Review Request 121355: Expose actual and maximum brightness value in dataengine

2014-12-05 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121355/ --- (Updated Dec. 5, 2014, 9:06 p.m.) Status -- This change has been

Re: [Kde-hardware-devel] Review Request 121355: Expose actual and maximum brightness value in dataengine

2014-12-05 Thread Hrvoje Senjan
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121355/#review71445 --- i've lost brightness control in battery monitor after this

Re: [Kde-hardware-devel] Review Request 121355: Expose actual and maximum brightness value in dataengine

2014-12-05 Thread Kai Uwe Broulik
On Dez. 5, 2014, 11:39 nachm., Hrvoje Senjan wrote: i've lost brightness control in battery monitor after this change. brightnessValueMax returns 9, but Screen Brightness Available is false anyway Kai Uwe Broulik wrote: Please update your plasma-workspace, I've adjusted battery

Re: [Kde-hardware-devel] Review Request 121355: Expose actual and maximum brightness value in dataengine

2014-12-05 Thread Kai Uwe Broulik
On Dez. 5, 2014, 11:39 nachm., Hrvoje Senjan wrote: i've lost brightness control in battery monitor after this change. brightnessValueMax returns 9, but Screen Brightness Available is false anyway Kai Uwe Broulik wrote: Please update your plasma-workspace, I've adjusted battery

[Kde-hardware-devel] Review Request 121355: Expose actual and maximum brightness value in dataengine

2014-12-04 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121355/ --- Review request for Plasma and Solid. Repository: plasma-workspace

Re: [Kde-hardware-devel] Review Request 121355: Expose actual and maximum brightness value in dataengine

2014-12-04 Thread Emmanuel Pescosta
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121355/#review71367 --- dataengines/powermanagement/powermanagementengine.cpp

Re: [Kde-hardware-devel] Review Request 121355: Expose actual and maximum brightness value in dataengine

2014-12-04 Thread Kai Uwe Broulik
On Dez. 4, 2014, 9:20 nachm., Emmanuel Pescosta wrote: dataengines/powermanagement/powermanagementengine.cpp, line 170 https://git.reviewboard.kde.org/r/121355/diff/1/?file=331906#file331906line170 You can remove the this receiver here and in other connect calls. Are you sure?

Re: [Kde-hardware-devel] Review Request 121355: Expose actual and maximum brightness value in dataengine

2014-12-04 Thread Emmanuel Pescosta
On Dec. 4, 2014, 10:20 p.m., Emmanuel Pescosta wrote: dataengines/powermanagement/powermanagementengine.cpp, line 170 https://git.reviewboard.kde.org/r/121355/diff/1/?file=331906#file331906line170 You can remove the this receiver here and in other connect calls. Kai Uwe Broulik

Re: [Kde-hardware-devel] Review Request 121355: Expose actual and maximum brightness value in dataengine

2014-12-04 Thread Kai Uwe Broulik
On Dez. 4, 2014, 9:20 nachm., Emmanuel Pescosta wrote: dataengines/powermanagement/powermanagementengine.cpp, line 170 https://git.reviewboard.kde.org/r/121355/diff/1/?file=331906#file331906line170 You can remove the this receiver here and in other connect calls. Kai Uwe Broulik

Re: [Kde-hardware-devel] Review Request 121355: Expose actual and maximum brightness value in dataengine

2014-12-04 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121355/#review71394 --- +1 I don't really understand dataengines enough to say it's