Re: [Kde-hardware-devel] Review Request 122151: Invert the KJob::Exec check logic

2015-02-07 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122151/#review75557 --- I suppose this is obsolete now? - Kai Uwe Broulik On Jan.

Re: [Kde-hardware-devel] Review Request 122151: Invert the KJob::Exec check logic

2015-02-07 Thread Hrvoje Senjan
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122151/ --- (Updated Feb. 7, 2015, 10:26 p.m.) Status -- This change has been

Re: [Kde-hardware-devel] Review Request 122151: Invert the KJob::Exec check logic

2015-01-20 Thread Daniel Vrátil
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122151/#review74384 --- Could this be related to /r/122029? When KAuth failed to

[Kde-hardware-devel] Review Request 122151: Invert the KJob::Exec check logic

2015-01-19 Thread Hrvoje Senjan
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122151/ --- Review request for Solid and Kai Uwe Broulik. Bugs: 342597

Re: [Kde-hardware-devel] Review Request 122151: Invert the KJob::Exec check logic

2015-01-19 Thread Lukáš Tinkl
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122151/#review74344 --- Hmm I don't see how the order could affect the outcome, but

Re: [Kde-hardware-devel] Review Request 122151: Invert the KJob::Exec check logic

2015-01-19 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122151/#review74346 --- Ship it! I don't see how this could make any difference but