Re: [Kde-hardware-devel] Review Request 127387: Refactor the backend loading code

> On March 15, 2016, 11:42 p.m., David Edmundson wrote: > > src/backendmanager.cpp, line 216 > > > > > > is the name argument still used? > > > > It looks like that used to be the name of the backend to

Re: [Kde-hardware-devel] Review Request 127387: Refactor the backend loading code

> On March 16, 2016, 11:45 a.m., Martin Gräßlin wrote: > > src/backendmanager.cpp, line 165 > > > > > > startsWith always goes with QLatin1String QString() is needed for .arg() (which QLatin1String doesn't

Re: [Kde-hardware-devel] Review Request 127387: Refactor the backend loading code

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127387/#review93639 --- Ship it! Ship It! - Martin Gräßlin On March 16, 2016,

Re: [Kde-hardware-devel] Review Request 127387: Refactor the backend loading code

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127387/#review93598 --- autotests/testbackendloader.cpp (line 46)

Re: [Kde-hardware-devel] Review Request 127387: Refactor the backend loading code

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127387/ --- (Updated March 16, 2016, 1:54 p.m.) Review request for Plasma, Solid,

Re: [Kde-hardware-devel] Review Request 127387: Refactor the backend loading code

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127387/ --- (Updated March 16, 2016, 2:04 p.m.) Review request for Plasma, Solid,

Re: [Kde-hardware-devel] Review Request 127387: Refactor the backend loading code

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127387/ --- (Updated March 16, 2016, 1:50 p.m.) Review request for Plasma, Solid,

Re: [Kde-hardware-devel] Review Request 127387: Refactor the backend loading code

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127387/#review93597 --- src/backendmanager.cpp (line 86)

Re: [Kde-hardware-devel] Review Request 127387: Refactor the backend loading code

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127387/#review93578 --- looks generally good. autotests/testbackendloader.cpp

[Kde-hardware-devel] Review Request 127387: Refactor the backend loading code

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127387/ --- Review request for Plasma, Solid, Daniel Vrátil, and Martin Gräßlin.