Re: [Kde-scm-interest] Integrating Reviewboard with git branches

2013-02-05 Thread Thiago Macieira
On terça-feira, 5 de fevereiro de 2013 16.13.34, Torgny Nyblom wrote: > Not for all I hope, for instance when the release team sets the tags for a > new KDE SC release how is that done if direct push is not supported? We've already established that direct pushes are supported. And also note that

Re: [Kde-scm-interest] Integrating Reviewboard with git branches

2013-02-05 Thread Thiago Macieira
On terça-feira, 5 de fevereiro de 2013 18.11.18, Jan Kundrát wrote: > On Tuesday, 5 February 2013 18:00:03 CEST, Torgny Nyblom wrote: > >> oh, you know, you simply cannot use tags when you use gerrit. > > > > Well not entirely true, we use them at work. > > But we also need to maintain a new repo o

Re: [Kde-scm-interest] Integrating Reviewboard with git branches

2013-02-05 Thread Torgny Nyblom
Hi, On Tuesday 05 February 2013 16.36.37 Oswald Buddenhagen wrote: > On Tue, Feb 05, 2013 at 04:13:34PM +0100, Torgny Nyblom wrote: > > On Tuesday 05 February 2013 00.15.47 Oswald Buddenhagen wrote: > > > in fact, i'd strongly recommend *against* allowing direct pushes (to the > > > baseline branc

Re: [Kde-scm-interest] Integrating Reviewboard with git branches

2013-02-05 Thread Oswald Buddenhagen
On Tue, Feb 05, 2013 at 04:13:34PM +0100, Torgny Nyblom wrote: > On Tuesday 05 February 2013 00.15.47 Oswald Buddenhagen wrote: > > in fact, i'd strongly recommend *against* allowing direct pushes (to the > > baseline branches). > > Not for all I hope, for instance when the release team sets the t

Re: [Kde-scm-interest] Integrating Reviewboard with git branches

2013-02-05 Thread Torgny Nyblom
Hi, On Tuesday 05 February 2013 00.15.47 Oswald Buddenhagen wrote: > On Mon, Feb 04, 2013 at 11:51:31PM +1300, Ben Cooksley wrote: [...] > > (not permitting direct pushes is unacceptable). > > yeah? why? because people would suddenly have to consider the part of > the policy which says that commi

Re: [Kde-scm-interest] Integrating Reviewboard with git branches

2013-02-05 Thread Oswald Buddenhagen
On Tue, Feb 05, 2013 at 01:09:10PM +1300, Ben Cooksley wrote: > On Tue, Feb 5, 2013 at 12:15 PM, Oswald Buddenhagen wrote: > > i don't see how gerrit's built-in webserver should be inherently less > > secure than all the other systems we have running. > > Currently, any changes to access controls

Re: [Kde-scm-interest] Integrating Reviewboard with git branches

2013-02-05 Thread Ben Cooksley
On Tue, Feb 5, 2013 at 9:44 PM, Thomas Koch wrote: > Hi all, > > Ben Cooksley: >> > there is no higher risk of screwin up the repos than with any other git >> > server. >> >> See what happened to Github and Rails. The web frontend was >> compromised and an unauthorised person was able to push code

Re: [Kde-scm-interest] Integrating Reviewboard with git branches

2013-02-05 Thread Thomas Koch
Hi all, Ben Cooksley: > > there is no higher risk of screwin up the repos than with any other git > > server. > > See what happened to Github and Rails. The web frontend was > compromised and an unauthorised person was able to push code directly > into the Rails repository. Are you referring to

Re: [Kde-scm-interest] Integrating Reviewboard with git branches

2013-02-04 Thread Ben Cooksley
On Tue, Feb 5, 2013 at 12:15 PM, Oswald Buddenhagen wrote: > On Mon, Feb 04, 2013 at 11:51:31PM +1300, Ben Cooksley wrote: >> On Fri, Feb 1, 2013 at 6:18 AM, Thomas Koch wrote: >> > I'm not involved in KDE but I'd love to see another big project realizing >> > the >> > beauty of gerrit. I've som

Re: [Kde-scm-interest] Integrating Reviewboard with git branches

2013-02-04 Thread Ian Monroe
On Mon, Feb 4, 2013 at 3:15 PM, Oswald Buddenhagen wrote: > while there are a few (well, two) more steps to take into account, > gerrit's review-only mode inherently catches most screwups before they > hit the repository, and consequently contributes to a less scary > learning experience. This wa

Re: [Kde-scm-interest] Integrating Reviewboard with git branches

2013-02-04 Thread Oswald Buddenhagen
On Mon, Feb 04, 2013 at 12:34:45PM +0100, Jan Kundrát wrote: > That might be the root of the misunderstanding here -- I'm not > proposing to let Gerrit be the gateway; I'm proposing setting it up as > a standalone service for code review. > i don't see how this could work and still be useful. the

Re: [Kde-scm-interest] Integrating Reviewboard with git branches

2013-02-04 Thread Oswald Buddenhagen
On Mon, Feb 04, 2013 at 11:51:31PM +1300, Ben Cooksley wrote: > On Fri, Feb 1, 2013 at 6:18 AM, Thomas Koch wrote: > > I'm not involved in KDE but I'd love to see another big project realizing > > the > > beauty of gerrit. I've some comments inline: > > Does this include the user interface? The

Re: [Kde-scm-interest] Integrating Reviewboard with git branches

2013-02-04 Thread Ben Cooksley
On Fri, Feb 1, 2013 at 6:18 AM, Thomas Koch wrote: > Hi Jan, Hi Thomas, > > I'm a big gerrit fanboy and have presented it on several occasions and I still > have nightmares from using jira + reviewboard + git-svn when working on an > Apache project. > > I'm not involved in KDE but I'd love to se

Re: [Kde-scm-interest] Integrating Reviewboard with git branches

2013-01-31 Thread Thomas Koch
Hi Jan, I'm a big gerrit fanboy and have presented it on several occasions and I still have nightmares from using jira + reviewboard + git-svn when working on an Apache project. I'm not involved in KDE but I'd love to see another big project realizing the beauty of gerrit. I've some comments i

Re: [Kde-scm-interest] Integrating Reviewboard with git branches

2013-01-24 Thread Oswald Buddenhagen
On Thu, Jan 24, 2013 at 10:25:31PM +0100, Jan Kundrát wrote: > Let's discuss whether the goals I outlined above are worth the effort, > whether they make sense to other people besides me and in case they > make sense, let's talk about how to get there. > that's an impressive lists of things to do

Re: [Kde-scm-interest] Integrating Reviewboard with git branches

2013-01-24 Thread Ian Monroe
On Thu, Jan 24, 2013 at 1:25 PM, Jan Kundrát wrote: > Hi, > I'd like to start a discussion about integrating the reviews and git more > tightly. In particular, what I dislike about the reviewboard is that as a > project maintainer, I have to carry the patches by hand and that the web > interface h

[Kde-scm-interest] Integrating Reviewboard with git branches

2013-01-24 Thread Jan Kundrát
Hi, I'd like to start a discussion about integrating the reviews and git more tightly. In particular, what I dislike about the reviewboard is that as a project maintainer, I have to carry the patches by hand and that the web interface has no information about what the parent commit is. I have