---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119248/
---
(Updated Iulie 12, 2014, 2:20 p.m.)
Review request for KDE Frameworks
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119249/#review62197
---
src/kdecore/k3resolver.h
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119249/#review62198
---
Generally seems sensible, apart from the things I noted
On July 12, 2014, 6:54 p.m., David Faure wrote:
Doesn't qplatformdefs.h define this already?
Ah not exactly, but you can use QT_STAT_DIR and QT_STAT_REG.
- David
---
This is an automatically generated e-mail. To reply, visit:
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119251/
---
Review request for KDE Frameworks and kdewin.
Repository: kcoreaddons
On July 12, 2014, 5:19 p.m., Cristian Oneț wrote:
src/kio/netaccess.h, line 197
https://git.reviewboard.kde.org/r/119249/diff/1/?file=289765#file289765line197
Issue 3: See http://msdn.microsoft.com/en-us/library/t72ahzw1.aspx
Member methods of exported classes should
On Iulie 12, 2014, 5:44 p.m., Alex Merry wrote:
src/kdeui/kapplication.cpp, lines 22-24
https://git.reviewboard.kde.org/r/119249/diff/1/?file=289763#file289763line22
Ooh, that's a nasty trap. We should fix this in KCoreAddons, not work
around it here. Possibly by using
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119249/
---
(Updated Iulie 12, 2014, 7:09 p.m.)
Review request for KDE Frameworks
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119249/
---
(Updated Iulie 12, 2014, 7:15 p.m.)
Review request for KDE Frameworks
On Iulie 12, 2014, 6:54 p.m., David Faure wrote:
Doesn't qplatformdefs.h define this already?
David Faure wrote:
Ah not exactly, but you can use QT_STAT_DIR and QT_STAT_REG.
Yeah, that was my other option, I'm going to update the diff.
- Cristian
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119248/
---
(Updated Iulie 12, 2014, 7:25 p.m.)
Review request for KDE Frameworks
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119251/#review62209
---
src/lib/kaboutdata.h
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119249/#review62211
---
Ship it!
Please make it one commit for each issue you listed
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119251/
---
(Updated Iulie 12, 2014, 7:30 p.m.)
Review request for KDE Frameworks
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119251/#review62212
---
Ship it!
Ship It!
- Alex Merry
On July 12, 2014, 7:30
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119248/#review62213
---
Ship it!
Looks good.
Grepping for S_ISDIR shows that
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119249/
---
(Updated July 12, 2014, 7:48 p.m.)
Status
--
This change has been
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119251/
---
(Updated July 12, 2014, 7:49 p.m.)
Status
--
This change has been
On Iulie 12, 2014, 7:33 p.m., David Faure wrote:
Looks good.
Grepping for S_ISDIR shows that kdelibs4support has some more (but no other
framework does).
The rest is in code the is not compiled on Windows or at least MSVC.
- Cristian
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119248/
---
(Updated July 12, 2014, 7:55 p.m.)
Status
--
This change has been
On Iulie 12, 2014, 7:58 p.m., Nicolás Alvarez wrote:
Windows has no concept of an integer UID/GID, it uses much longer SIDs to
identify users. These are not returned by stat (stat always returns zero in
the st_uid member).
I would just ifdef away the UDS_USER and UDS_GROUP lines on
21 matches
Mail list logo
