[Kdenlive-devel] Getting ready ofr the 0.8.2 release

-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 07/05/2011 06:32 PM, Dan Dennedy wrote: > On Tue, Jul 5, 2011 at 3:54 AM, jb wrote: >> Hi all. >> >> I think I fixed most major issues for the 0.8.2 release. I >> created the 0.8.2 info page ( http://kdenlive.org/discover/0.8.2 >> ), and will so

[Kdenlive-devel] Getting ready ofr the 0.8.2 release

e how they look. Now revert the commit with 'svn merge -c -5845 .' and retry the tests. Technically, it is OK to have mlt_profile in the render profiles as I had left it but only because of the "standard" attribute and how it is being used more strictly now. However, to discourage others from using it in custom profiles, we can retain the changes you made to replace its usage with s= and aspect=. It is the code that removes the consumer producer that is the real regression. -- +-DRD-+ -- next part -- A non-text attachment was scrubbed... Name: test.kdenlive Type: application/x-kdenlive Size: 7217 bytes Desc: not available URL: <http://mail.kde.org/pipermail/kdenlive/attachments/20110828/dba48850/attachment.bin>

[Kdenlive-devel] Getting ready ofr the 0.8.2 release

- > EMC VNX: the world's simplest storage, starting under $10K > The only unified storage solution that offers unified management > Up to 160% more powerful than alternatives and 25% more efficient. > Guaranteed. http://p.sf.net/sfu/emc-vnx-dev2dev > ___ > Kdenlive-devel mailing list > Kdenlive-devel at lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/kdenlive-devel -- next part -- An HTML attachment was scrubbed... URL: <http://mail.kde.org/pipermail/kdenlive/attachments/20110828/c618b633/attachment.html>

[Kdenlive-devel] Getting ready ofr the 0.8.2 release

On Sun, Aug 28, 2011 at 1:47 PM, Till Theato wrote: > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA1 > > On 07/05/2011 06:32 PM, Dan Dennedy wrote: >> On Tue, Jul 5, 2011 at 3:54 AM, jb wrote: >>> Hi all. >>> >>> I think I fixed most major issues for the 0.8.2 release. I >>> created the 0.8.2 in

[Kdenlive-devel] Getting ready ofr the 0.8.2 release

On Sun, Aug 28, 2011 at 1:47 PM, Till Theato wrote: > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA1 > > On 07/05/2011 06:32 PM, Dan Dennedy wrote: >> On Tue, Jul 5, 2011 at 3:54 AM, jb wrote: >>> Hi all. >>> >>> I think I fixed most major issues for the 0.8.2 release. I >>> created the 0.8.2 in

[Kdenlive-devel] [PATCH kdenlive 27/27] const parameter as reference

Found by cppcheck. --- src/transition.cpp |2 +- src/transition.h |2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/transition.cpp b/src/transition.cpp index eefa77b..1c134f6 100644 --- a/src/transition.cpp +++ b/src/transition.cpp @@ -31,7 +31,7 @@ #include

[Kdenlive-devel] [PATCH kdenlive 26/27] const parameter as reference

Found by cppcheck. --- src/titlewidget.cpp |2 +- src/titlewidget.h |2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/titlewidget.cpp b/src/titlewidget.cpp index 8ba4eb4..53b7516 100644 --- a/src/titlewidget.cpp +++ b/src/titlewidget.cpp @@ -2399,7 +2399,7 @@ void

[Kdenlive-devel] [PATCH kdenlive 25/27] const parameter as reference

Found by cppcheck. --- src/timecode.cpp |4 ++-- src/timecode.h |4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/src/timecode.cpp b/src/timecode.cpp index 5e68e0d..89063dd 100644 --- a/src/timecode.cpp +++ b/src/timecode.cpp @@ -137,13 +137,13 @@ QString Timecode::

[Kdenlive-devel] [PATCH kdenlive 24/27] const parameter as reference

Found by cppcheck. --- src/renderwidget.cpp |2 +- src/renderwidget.h |2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/renderwidget.cpp b/src/renderwidget.cpp index e4b6b9e..6136857 100644 --- a/src/renderwidget.cpp +++ b/src/renderwidget.cpp @@ -252,7 +252,7 @@

[Kdenlive-devel] [PATCH kdenlive 23/27] const parameter as reference

Found by cppcheck. --- src/renderer.cpp |8 src/renderer.h | 18 +- 2 files changed, 13 insertions(+), 13 deletions(-) diff --git a/src/renderer.cpp b/src/renderer.cpp index 879d676..743e776 100644 --- a/src/renderer.cpp +++ b/src/renderer.cpp @@ -176,7 +176,7 @@

[Kdenlive-devel] [PATCH kdenlive 22/27] const parameter as reference

Found by cppcheck. --- src/recmonitor.cpp |4 ++-- src/recmonitor.h |4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/src/recmonitor.cpp b/src/recmonitor.cpp index 41ea650..0ace145 100644 --- a/src/recmonitor.cpp +++ b/src/recmonitor.cpp @@ -192,7 +192,7 @@ void Rec

[Kdenlive-devel] [PATCH kdenlive 21/27] const parameter as reference

Found by cppcheck. --- src/monitormanager.cpp |2 +- src/monitormanager.h |2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/monitormanager.cpp b/src/monitormanager.cpp index 9bf6ce4..662748e 100644 --- a/src/monitormanager.cpp +++ b/src/monitormanager.cpp @@ -81,7

[Kdenlive-devel] [PATCH kdenlive 20/27] cont parameter as reference

Found by cppcheck. --- src/monitor.cpp |2 +- src/monitor.h|2 +- src/renderer.cpp |2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/src/monitor.cpp b/src/monitor.cpp index 54c708b..d800b62 100644 --- a/src/monitor.cpp +++ b/src/monitor.cpp @@ -857,7 +857,7 @@

[Kdenlive-devel] [PATCH kdenlive 19/27] const parameter as reference

Found by cppcheck. --- src/mltdevicecapture.cpp |2 +- src/mltdevicecapture.h |2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/mltdevicecapture.cpp b/src/mltdevicecapture.cpp index 7998aa2..a60f34a 100644 --- a/src/mltdevicecapture.cpp +++ b/src/mltdevicecapture.

[Kdenlive-devel] [PATCH kdenlive 18/27] const parameter as reference

Found by cppcheck. --- src/mainwindow.cpp |2 +- src/mltdevicecapture.h |2 +- src/stopmotion/capturehandler.h |2 +- src/stopmotion/stopmotion.cpp | 10 +- src/stopmotion/stopmotion.h |6 +++--- 5 files changed, 11 insertions(+), 11 deletions(

[Kdenlive-devel] [PATCH kdenlive 17/27] const parameters as reference

Found by cppcheck. --- src/kdenlivedoc.cpp | 14 +++--- src/kdenlivedoc.h | 18 +- 2 files changed, 16 insertions(+), 16 deletions(-) diff --git a/src/kdenlivedoc.cpp b/src/kdenlivedoc.cpp index f453f70..ef76ad0 100644 --- a/src/kdenlivedoc.cpp +++ b/src/kdenlivedoc.

[Kdenlive-devel] [PATCH kdenlive 16/27] const parameter as reference

Found by cppcheck. --- src/guide.cpp |2 +- src/guide.h|2 +- src/mainwindow.cpp |2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/src/guide.cpp b/src/guide.cpp index 9c92236..47ba15e 100644 --- a/src/guide.cpp +++ b/src/guide.cpp @@ -70,7 +70,7 @@ Comm

[Kdenlive-devel] [PATCH kdenlive 15/27] const parameter as reference

Found by cppcheck. --- src/geometryval.cpp |2 +- src/geometryval.h |2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/geometryval.cpp b/src/geometryval.cpp index 290435b..9dfe5f3 100644 --- a/src/geometryval.cpp +++ b/src/geometryval.cpp @@ -29,7 +29,7 @@ #includ

[Kdenlive-devel] [PATCH kdenlive 14/27] const parameters as reference

Found by cppcheck. --- src/effectstackview.cpp |2 +- src/effectstackview.h |2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/effectstackview.cpp b/src/effectstackview.cpp index 92bcfce..95ff95c 100644 --- a/src/effectstackview.cpp +++ b/src/effectstackview.cpp @@

[Kdenlive-devel] [PATCH kdenlive 13/27] const parameter as reference

Found by cppcheck. --- src/effectstackedit.cpp |2 +- src/effectstackedit.h |4 ++-- src/effectstackview.cpp |2 +- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/src/effectstackedit.cpp b/src/effectstackedit.cpp index 955f0c5..af2b1e5 100644 --- a/src/effectstackedit

[Kdenlive-devel] [PATCH kdenlive 12/27] const parameters as reference

Found by cppcheck. --- src/effectslist.cpp |2 +- src/effectslist.h |2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/effectslist.cpp b/src/effectslist.cpp index f3ac887..6fc98a9 100644 --- a/src/effectslist.cpp +++ b/src/effectslist.cpp @@ -177,7 +177,7 @@ bool E

[Kdenlive-devel] [PATCH kdenlive 11/27] const parameters as reference

Found by cppcheck. --- src/dvdwizardvob.cpp |4 ++-- src/dvdwizardvob.h |4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/src/dvdwizardvob.cpp b/src/dvdwizardvob.cpp index 39e7d37..8b9b0d6 100644 --- a/src/dvdwizardvob.cpp +++ b/src/dvdwizardvob.cpp @@ -276,7 +276,7

[Kdenlive-devel] [PATCH kdenlive 10/27] initialize variables in constructor

Found by cppcheck: [../src/dvdwizardmenu.h:39]: (warning) Member variable 'DvdScene::m_width' is not initialized in the constructor. [../src/dvdwizardmenu.h:39]: (warning) Member variable 'DvdScene::m_height' is not initialized in the constructor. --- src/dvdwizardmenu.h |4 +++- 1 files ch

[Kdenlive-devel] [PATCH kdenlive 09/27] const parameters as reference

Found by cppcheck. --- src/dvdwizardchapters.cpp |2 +- src/dvdwizardchapters.h |2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/dvdwizardchapters.cpp b/src/dvdwizardchapters.cpp index 0804f5c..807e180 100644 --- a/src/dvdwizardchapters.cpp +++ b/src/dvdwizardcha

[Kdenlive-devel] [PATCH kdenlive 08/27] const parameters as reference

Found by cppcheck. --- src/docclipbase.h |4 ++-- src/projectlist.cpp |4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/src/docclipbase.h b/src/docclipbase.h index 95e0b6b..b23945d 100644 --- a/src/docclipbase.h +++ b/src/docclipbase.h @@ -278,9 +278,9 @@ public slo

[Kdenlive-devel] [PATCH kdenlive 07/27] const parameters as reference

Found by cppcheck. --- src/docclipbase.cpp |4 ++-- src/docclipbase.h |4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/src/docclipbase.cpp b/src/docclipbase.cpp index 527f939..fc45161 100644 --- a/src/docclipbase.cpp +++ b/src/docclipbase.cpp @@ -209,7 +209,7 @@ bo

[Kdenlive-devel] [PATCH kdenlive 06/27] const parameters as reference

Found by cppcheck. --- src/definitions.h | 12 ++-- 1 files changed, 6 insertions(+), 6 deletions(-) diff --git a/src/definitions.h b/src/definitions.h index 6b0576b..4384e8c 100644 --- a/src/definitions.h +++ b/src/definitions.h @@ -101,14 +101,14 @@ struct MltVideoProfile { class Eff

[Kdenlive-devel] [PATCH kdenlive 05/27] const parameter as reference and end file

Found by cppcheck. --- src/databackup/backupwidget.cpp |4 ++-- src/databackup/backupwidget.h |2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/src/databackup/backupwidget.cpp b/src/databackup/backupwidget.cpp index 64e4a88..c3e4f34 100644 --- a/src/databackup/backupw

[Kdenlive-devel] [PATCH kdenlive 04/27] const parameters as reference

Found by cppcheck. --- src/clipmanager.cpp | 16 src/clipmanager.h | 16 2 files changed, 16 insertions(+), 16 deletions(-) diff --git a/src/clipmanager.cpp b/src/clipmanager.cpp index 7993794..d3669ca 100644 --- a/src/clipmanager.cpp +++ b/src/clipmanager.

[Kdenlive-devel] [PATCH kdenlive 03/27] const parameters as reference

Found by cppcheck. --- src/customtrackview.cpp | 28 ++-- src/customtrackview.h | 30 +++--- 2 files changed, 29 insertions(+), 29 deletions(-) diff --git a/src/customtrackview.cpp b/src/customtrackview.cpp index 38ab4d6..04874a6 100644 --- a/

[Kdenlive-devel] [PATCH kdenlive 02/27] const parameter as reference

Found by cppcheck. --- src/abstractscopewidget.cpp |2 +- src/abstractscopewidget.h |2 +- src/audioscopes/audiospectrum.cpp |2 +- src/audioscopes/audiospectrum.h |2 +- src/audioscopes/spectrogram.cpp |2 +- src/audioscopes/spectrogram.h |2 +- 6 fil

[Kdenlive-devel] [PATCH kdenlive 01/27] const parameters as reference

Found by cppcheck: [../src/abstractclipitem.h:45]: (performance) Parameter 'info' is passed as a value. It could be passed as a (const) reference which is usually faster and recommended in C++. [../src/abstractclipitem.h:52]: (performance) Parameter 'pos' is passed as a value. It could be passe

[Kdenlive-devel] [PATCH kdenlive 00/27] cppcheck fixes

While waiting for proxy clips to be generated, I decided to run cppcheck on kdenlive and fix most of the issues found. I used cppcheck version 1.49-1 available on Debian unstable. Patches were created in one bunch but I tried to separate them in git so that each change would still compile. I have