Found by cppcheck. --- src/docclipbase.cpp | 4 ++-- src/docclipbase.h | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/docclipbase.cpp b/src/docclipbase.cpp index 527f939..fc45161 100644 --- a/src/docclipbase.cpp +++ b/src/docclipbase.cpp @@ -209,7 +209,7 @@ bool DocClipBase::isTransparent() const return (m_properties.value("transparency") == "1"); } -const QString DocClipBase::getProperty(const QString prop) const +const QString DocClipBase::getProperty(const QString &prop) const { return m_properties.value(prop); } @@ -870,7 +870,7 @@ void DocClipBase::clearProperty(const QString &key) m_properties.remove(key); } -void DocClipBase::getFileHash(const QString url) +void DocClipBase::getFileHash(const QString &url) { if (m_clipType == SLIDESHOW) return; QFile file(url); diff --git a/src/docclipbase.h b/src/docclipbase.h index a19d226..95e0b6b 100644 --- a/src/docclipbase.h +++ b/src/docclipbase.h @@ -76,7 +76,7 @@ Q_OBJECT public: bool isTransparent() const; /** Returns any property of this clip. */ - const QString getProperty(const QString prop) const; + const QString getProperty(const QString &prop) const; void setProperty(const QString &key, const QString &value); void clearProperty(const QString &key); @@ -248,7 +248,7 @@ private: // Private attributes void slotRefreshProducer(); void setProducerProperty(const char *name, int data); void setProducerProperty(const char *name, double data); - void getFileHash(const QString url); + void getFileHash(const QString &url); /** @brief When duplicating a producer, make sure all manually set properties are passed to it. */ void adjustProducerProperties(Mlt::Producer *prod, const QString &id, bool mute, bool blind); /** @brief Create another instance of a producer. */ -- 1.7.5.4