[kdenlive] Review Request 126796: online resource -logs into users freesound accounts to get permission for HQ audio. Fixes archive.org video search new dependancy KF5WebKit. (libkf5webkit5-dev)

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126796/ --- Review request for Kdenlive and Vincent Pinon. Repository: kdenlive Des

Re: [kdenlive] Review Request 126796: online resource -logs into users freesound accounts to get permission for HQ audio. Fixes archive.org video search new dependancy KF5WebKit. (libkf5webkit5-dev)

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126796/#review91371 --- Thanks for this patch. Some comments / questions: Some files

Re: [kdenlive] Review Request 126796: online resource -logs into users freesound accounts to get permission for HQ audio. Fixes archive.org video search new dependancy KF5WebKit. (libkf5webkit5-dev)

> On Jan. 20, 2016, 10:28 a.m., Jean-Baptiste Mardelle wrote: > > Thanks for this patch. Some comments / questions: > > Some files are missing a license header > > The token is saved in $HOME/config/kde.org/kdenlive.conf is that a standard > > location for saving web tokens ? Licence headers. Y

Re: [kdenlive] Review Request 126796: online resource -logs into users freesound accounts to get permission for HQ audio. Fixes archive.org video search new dependancy KF5WebKit. (libkf5webkit5-dev)

> On Jan. 20, 2016, 10:28 a.m., Jean-Baptiste Mardelle wrote: > > src/utils/freesound.cpp, line 317 > > > > > > I'd prefer if you keep the previous format, calling start with: > > > > m_previewProcess->

Re: [kdenlive] Review Request 126796: online resource -logs into users freesound accounts to get permission for HQ audio. Fixes archive.org video search new dependancy KF5WebKit. (libkf5webkit5-dev)

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126796/ --- (Updated Feb. 4, 2016, 12:39 p.m.) Review request for Kdenlive and Vincen

Re: [kdenlive] Review Request 126796: online resource -logs into users freesound accounts to get permission for HQ audio. Fixes archive.org video search new dependancy KF5WebKit. (libkf5webkit5-dev)

I have uploaded a patch file to the review board. However, it is up there as just a file attachement - not a diff file. Why? This happened last time too. git format-patch -2 HEAD -o ~/development/kdenlive/f ^^^ this gave me 2 patch files. One which did have the new stuff I wrote on top of my oth

Re: [kdenlive] Review Request 126796: online resource -logs into users freesound accounts to get permission for HQ audio. Fixes archive.org video search new dependancy KF5WebKit. (libkf5webkit5-dev)

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126796/ --- (Updated Feb. 7, 2016, 3:12 a.m.) Review request for Kdenlive and Vincent

Re: [kdenlive] Review Request 126796: online resource -logs into users freesound accounts to get permission for HQ audio. Fixes archive.org video search new dependancy KF5WebKit. (libkf5webkit5-dev)

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126796/ --- (Updated Feb. 11, 2016, 9:51 a.m.) Review request for Kdenlive and Vincen

Re: [kdenlive] Review Request 126796: online resource -logs into users freesound accounts to get permission for HQ audio. Fixes archive.org video search new dependancy KF5WebKit. (libkf5webkit5-dev)

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126796/#review92255 --- src/qt-oauth-lib/oauth2.cpp (line 81)

Re: [kdenlive] Review Request 126796: online resource -logs into users freesound accounts to get permission for HQ audio. Fixes archive.org video search new dependancy KF5WebKit. (libkf5webkit5-dev)

> On Feb. 11, 2016, 1:03 p.m., Jean-Baptiste Mardelle wrote: > > src/utils/freesound.cpp, line 317 > > > > > > Keep the QProcess->start(exec, QStringList args) format I dunno how this keeps slipping back to this

Re: [kdenlive] Review Request 126796: online resource -logs into users freesound accounts to get permission for HQ audio. Fixes archive.org video search new dependancy KF5WebKit. (libkf5webkit5-dev)

> On Feb. 11, 2016, 1:03 p.m., Jean-Baptiste Mardelle wrote: > > Hi JB, Thanks for all this guidance. I am seeing a general principle here with respect to memory leaks. It seems that when you declare and create a pointer variable you want to see a place where that pointer is deleted. Is that

Re: [kdenlive] Review Request 126796: online resource -logs into users freesound accounts to get permission for HQ audio. Fixes archive.org video search new dependancy KF5WebKit. (libkf5webkit5-dev)

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126796/ --- (Updated Feb. 15, 2016, 1:08 p.m.) Review request for Kdenlive and Vincen

Re: [kdenlive] Review Request 126796: online resource -logs into users freesound accounts to get permission for HQ audio. Fixes archive.org video search new dependancy KF5WebKit. (libkf5webkit5-dev)

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126796/#review92506 --- Thanks for the update, looks good to me now. We will make the

Re: [kdenlive] Review Request 126796: online resource -logs into users freesound accounts to get permission for HQ audio. Fixes archive.org video search new dependancy KF5WebKit. (libkf5webkit5-dev)

> On Feb. 17, 2016, 9:21 p.m., Jean-Baptiste Mardelle wrote: > > Thanks for the update, looks good to me now. > > We will make the push to git in the next days, and after that add a > > CMakeList flag to conditionnaly disable the webkit dependency. Cool. One thing that troubles me about it is