Re: Current specfile misapplies v4.14.10 stable update for fc26

2018-01-02 Thread Paul Bolle
On Wed, 2018-01-03 at 00:00 +, Peter Robinson wrote: > On Tue, Jan 2, 2018 at 11:56 PM, Paul Bolle wrote: > > But koji isn't carved in stone, is it? > > No, but in the current status quo it can't pull from random sources > (Fedora config, not koji in general), this is an explicit decision for

Re: Current specfile misapplies v4.14.10 stable update for fc26

2018-01-02 Thread Peter Robinson
On Tue, Jan 2, 2018 at 11:56 PM, Paul Bolle wrote: > On Tue, 2018-01-02 at 17:27 -0500, Josh Boyer wrote: >> If you're talking about local builds, it isn't tricky at all. Someone >> would just need to adjust the kernel.spec to do it and/or write steps >> to have your local git tree in a state tha

Re: Current specfile misapplies v4.14.10 stable update for fc26

2018-01-02 Thread Paul Bolle
On Tue, 2018-01-02 at 17:27 -0500, Josh Boyer wrote: > If you're talking about local builds, it isn't tricky at all. Someone > would just need to adjust the kernel.spec to do it and/or write steps > to have your local git tree in a state that the existing spec could > use. You could even use the

Re: RFC: Moving kernel-tools out of kernel.spec

2018-01-02 Thread Laura Abbott
On 12/08/2017 04:35 PM, Laura Abbott wrote: On 12/05/2017 12:50 PM, Laura Abbott wrote: On 11/28/2017 02:03 PM, Laura Abbott wrote: Like all good bits of software, the kernel.spec has grown over time. Part of this growth has come from building more of the userspace tools that live under the too

Re: Current specfile misapplies v4.14.10 stable update for fc26

2018-01-02 Thread Paul Bolle
On Tue, 2018-01-02 at 17:21 -0500, Josh Boyer wrote: > On Tue, Jan 2, 2018 at 4:35 PM, Paul Bolle wrote: > > Git apply doesn't need a git repo. It is designed to be a patch replacement. > > Interesting. I wasn't aware of that. Seems odd? Apparently a conscious decision: https://lkml.org/lkml/2

Re: Current specfile misapplies v4.14.10 stable update for fc26

2018-01-02 Thread Josh Boyer
On Tue, Jan 2, 2018 at 4:55 PM, Paul Bolle wrote: > On Tue, 2018-01-02 at 12:32 -0800, Laura Abbott wrote: >> On 01/02/2018 08:35 AM, Paul Bolle wrote: >> > A bit off topic: I suppose at the ultimate goal is to do rpmbuild from >> > within >> > a proper git clone of the kernel repository. Ie, usi

Re: Current specfile misapplies v4.14.10 stable update for fc26

2018-01-02 Thread Josh Boyer
On Tue, Jan 2, 2018 at 4:35 PM, Paul Bolle wrote: > On Tue, 2018-01-02 at 16:28 -0500, Josh Boyer wrote: >> So if you want to use git apply instead of patch, I have no objections >> that I can remember. It'll just require some extra work to make sure >> the git repo actually exists and that doesn

Re: Current specfile misapplies v4.14.10 stable update for fc26

2018-01-02 Thread Paul Bolle
On Tue, 2018-01-02 at 12:32 -0800, Laura Abbott wrote: > On 01/02/2018 08:35 AM, Paul Bolle wrote: > > A bit off topic: I suppose at the ultimate goal is to do rpmbuild from > > within > > a proper git clone of the kernel repository. Ie, using a branch with > > Fedora's > > patches, a specfile, a

Re: Current specfile misapplies v4.14.10 stable update for fc26

2018-01-02 Thread Paul Bolle
On Tue, 2018-01-02 at 16:28 -0500, Josh Boyer wrote: > So if you want to use git apply instead of patch, I have no objections > that I can remember. It'll just require some extra work to make sure > the git repo actually exists and that doesn't break other things. Git apply doesn't need a git rep

Re: Current specfile misapplies v4.14.10 stable update for fc26

2018-01-02 Thread Josh Boyer
On Sun, Dec 31, 2017 at 9:13 PM, Laura Abbott wrote: > On 12/30/2017 04:52 AM, Paul Bolle wrote: >> >> 0) The v4.14.10 stable updates adds a new executable (tools/objtool/sync- >> check.sh). Somehow this was added non-executable during my local build of >> v4.14.10 (on fc26, that is). This made th

Re: Current specfile misapplies v4.14.10 stable update for fc26

2018-01-02 Thread Laura Abbott
On 01/02/2018 08:35 AM, Paul Bolle wrote: On Sun, 2017-12-31 at 18:13 -0800, Laura Abbott wrote: On 12/30/2017 04:52 AM, Paul Bolle wrote: 2) Would it make sense to further gitify the specfile and move from patch to "git apply" here (and a few other places)? Or should we expect patch to do the

Re: Current specfile misapplies v4.14.10 stable update for fc26

2018-01-02 Thread Don Zickus
On Tue, Jan 02, 2018 at 05:13:59PM +0100, Paul Bolle wrote: > On Tue, 2018-01-02 at 09:50 -0500, Don Zickus wrote: > > On Sat, Dec 30, 2017 at 01:52:49PM +0100, Paul Bolle wrote: > > > diff --git a/kernel.spec b/kernel.spec > > > index 965345c2a26e..b2a1ffbe843d 100644 > > > --- a/kernel.spec > > >

Re: Current specfile misapplies v4.14.10 stable update for fc26

2018-01-02 Thread Paul Bolle
On Sun, 2017-12-31 at 18:13 -0800, Laura Abbott wrote: > On 12/30/2017 04:52 AM, Paul Bolle wrote: > > 2) Would it make sense to further gitify the specfile and move from patch to > > "git apply" here (and a few other places)? Or should we expect patch to do > > the > > right thing? (In the latter

Re: Current specfile misapplies v4.14.10 stable update for fc26

2018-01-02 Thread Paul Bolle
On Tue, 2018-01-02 at 09:50 -0500, Don Zickus wrote: > On Sat, Dec 30, 2017 at 01:52:49PM +0100, Paul Bolle wrote: > > diff --git a/kernel.spec b/kernel.spec > > index 965345c2a26e..b2a1ffbe843d 100644 > > --- a/kernel.spec > > +++ b/kernel.spec > > @@ -1267,8 +1267,9 @@ fi > > # released_kernel w

Re: Current specfile misapplies v4.14.10 stable update for fc26

2018-01-02 Thread Don Zickus
On Sat, Dec 30, 2017 at 01:52:49PM +0100, Paul Bolle wrote: > 0) The v4.14.10 stable updates adds a new executable (tools/objtool/sync- > check.sh). Somehow this was added non-executable during my local build of > v4.14.10 (on fc26, that is). This made the build fail: > > [...] > + make -s ARCH=x8