Re: [OS-BUILD PATCHv5] Enable iSER on s390x

2022-02-03 Thread Patrick Talbert (via Email Bridge)
From: Patrick Talbert on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1536#note_830254181 @sfrielin please update the commit description to include some basic context. ___ kernel mailing list -- kernel@lists.fedoraproject.org To

Re: [OS-BUILD PATCHv7] Makefile: Check PKGRELEASE size on dist-brew targets

2022-02-03 Thread Frantisek Hrbata (via Email Bridge)
From: Frantisek Hrbata on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1579#note_830327786 In this particular case it doesn't matter, so just a note. IIRC make vars do not care about any quotes. Anything after one of the assignment operators, except leading whitespaces, is

Re: [OS-BUILD PATCHv2] kernel.spec: Add glibc-static build requirement

2022-02-03 Thread Bruno Meneguele (via Email Bridge)
From: Bruno Meneguele on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1538#note_831080251 Oh, sorry for missing this blocking thread. You did answer my question and I'm fine with the solution based on the above discussion. Sorry for holding it.

Re: [OS-BUILD PATCHv7] Makefile: Check PKGRELEASE size on dist-brew targets

2022-02-03 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1579#note_831081645 > So for me the "$(PKGRELEASE)" seems correct. Okay :) I can change it back. @bmeneg, any thoughts before I do? ___ kernel mailing lis

[OS-BUILD PATCHv3] kernel.spec: Add glibc-static build requirement

2022-02-03 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava kernel.spec: Add glibc-static build requirement CKI and brew builds resulted in two different values for CONFIG_CC_CAN_LINK_STATIC. In CKI CONFIG_CC_CAN_LINK_STATIC=y while in brew CONFIG_CC_CAN_LINK_STATIC was not defined. This occurs because glibc-static is installed on

Re: [OS-BUILD PATCHv3] kernel.spec: Add glibc-static build requirement

2022-02-03 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1538#note_831085893 Done. I added a more detailed comment in both the spec and the commit message (I changed systems to environments). ___ kernel mailing list

Re: [OS-BUILD PATCHv7] Makefile: Check PKGRELEASE size on dist-brew targets

2022-02-03 Thread Bruno Meneguele (via Email Bridge)
From: Bruno Meneguele on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1579#note_831089330 @frhr that's a valuable piece of "note" :D and it makes complete sense. Thanks for that. @prarit nope, go ahead and change it back with the quotes. __