From: Zbigniew Jędrzejewski-Szmek on gitlab.com
https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1617#note_846918364
I forgot to add: if the third commit is too much, I'm fine with dropping it.
This can always be revived later if some concrete use cases pops up.
From: Zbigniew Jędrzejewski-Szmek on gitlab.com
https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1617#note_846917518
I don't have any immediate use case in mind. This is more a matter of general
principle: dependencies should only be declared if the package genuinely needs
the
From: Jiri Benc on gitlab.com
https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1619#note_846679718
This leaves the semicolon here in the GENKSYMS pass. I don't think we want
that; the kABI checksum would be generated from:
```
union {
unsigned long xyz[_size];
;
}
```
From: Sabrina Dubroca
redhat: kABI: add missing RH_KABI_SIZE_ALIGN_CHECKS Kconfig option
When the kABI macros were copied from the RHEL kernel to ARK, the
RH_KABI_SIZE_ALIGN_CHECKS config option was dropped. Without it, the
size checks included in some of the kABI macros can't be enabled.
Add
From: Sabrina Dubroca
redhat: rh_kabi: introduce RH_KABI_EXCLUDE_WITH_SIZE
This macro is similar to RH_KABI_EXTEND_WITH_SIZE, but with a
different intention. While RH_KABI_EXTEND_WITH_SIZE is meant to add
new elements that may grow in the future to kABI-protected structures,
From: Sabrina Dubroca on gitlab.com
Merge Request: https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1619
This MR introduces a new kABI macro, RH_KABI_EXCLUDE_WITH_SIZE. The
implementation is identical to RH_KABI_EXTEND_WITH_SIZE, but the meaning is
more in line with RH_KABI_EXCLUDE. The
From: Sabrina Dubroca on gitlab.com
https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1619#note_846657442
In v3 I modified RH_KABI_EXCLUDE_WITH_SIZE to only exclude the new element
from the checksum, but include the reserved size, so that we can't
accidentally grow it without breaking
From: Sabrina Dubroca on gitlab.com
https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1619#note_846653940
Ok, addressed in v4 (I missed the 'depends on' in v3). Thanks.
___
kernel mailing list -- kernel@lists.fedoraproject.org
To unsubscribe
From: Sabrina Dubroca on gitlab.com
https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1619#note_846653350
Ok, addressed in v4 (I forgot the 'depends on' in v3).
___
kernel mailing list -- kernel@lists.fedoraproject.org
To unsubscribe send an
From: Don Zickus on gitlab.com
https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1619#note_846563779
@sdubroca - I agree with @jmflinuxtx . Let's keep Red Hat configs centralized
in Kconfig.redhat. Adding a 'depends on RHEL_DIFFERENCES' is to help Fedora
keep it disabled.
From: Don Zickus on gitlab.com
https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1617#note_846539664
@keszybz - thanks for the contribution. I feel like I am missing something
obvious.
If I follow your assumption, that someone will install a kernel in a virt env
or container that may
From: Justin M. Forbes on gitlab.com
https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1619#note_846439422
It seems the Kconfig entry for this really belongs in Kconfig.redhat perhaps
even better if it had a dep on RHEL_DIFFERENCES as well.
___
From: Hangbin Liu
redhat: configs: Disable team driver
Bugzilla: https://bugzilla.redhat.com/show_bug.cgi?id=1945477
Upstream Status: RHEL-only
This drivers have been deprecated with RHEL9, so with RHEL10 it is time
to remove it. Disable the NET_TEAM on ARK. No need to set the modes as
they
From: Sabrina Dubroca
redhat: rh_kabi: introduce RH_KABI_EXCLUDE_WITH_SIZE
This macro is identical to RH_KABI_EXTEND_WITH_SIZE, but with a
different intention. While RH_KABI_EXTEND_WITH_SIZE is meant to add
new elements that may grow in the future to kABI-protected structures,
From: Sabrina Dubroca
redhat: kABI: add missing RH_KABI_SIZE_ALIGN_CHECKS Kconfig option
When the kABI macros were copied from the RHEL kernel to ARK, the
RH_KABI_SIZE_ALIGN_CHECKS config option was dropped. Without it, the
size checks included in some of the kABI macros can't be enabled.
Add
From: Sabrina Dubroca on gitlab.com
Merge Request: https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1619
This MR introduces a new kABI macro, RH_KABI_EXCLUDE_WITH_SIZE. The
implementation is identical to RH_KABI_EXTEND_WITH_SIZE, but the meaning is
more in line with RH_KABI_EXCLUDE. The
From: Zbigniew Jędrzejewski-Szmek on gitlab.com
https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1617#note_846003134
I added a third commit now.
___
kernel mailing list -- kernel@lists.fedoraproject.org
To unsubscribe send an email to
From: Zbigniew Jędrzejewski-Szmek on gitlab.com
Merge Request: https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1617
NOTE: Truncated patchset due to missing public @redhat.com email
address on your GitLab profile at https://gitlab.com/-/profile.
Once that is fixed, close and
From: Jiri Benc on gitlab.com
https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1619#note_846001310
Sabrina, I suggest enabling CONFIG_RH_KABI_SIZE_ALIGN_CHECKS only in
redhat/configs/ark and disabling them in redhat/configs/fedora. That config
option is not useful for Fedora.
From: Sabrina Dubroca on gitlab.com
Merge Request: https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1619
This MR introduces a new kABI macro, RH_KABI_EXCLUDE_WITH_SIZE. The
implementation is identical to RH_KABI_EXTEND_WITH_SIZE, but the meaning is
more in line with RH_KABI_EXCLUDE. The
From: Sabrina Dubroca
redhat: kABI: add missing RH_KABI_SIZE_ALIGN_CHECKS Kconfig option
When the kABI macros were copied from the RHEL kernel to ARK, the
RH_KABI_SIZE_ALIGN_CHECKS config option was dropped. Without it, the
size checks included in some of the kABI macros can't be enabled.
Add
From: Sabrina Dubroca
redhat: rh_kabi: introduce RH_KABI_EXCLUDE_WITH_SIZE
This macro is identical to RH_KABI_EXTEND_WITH_SIZE, but with a
different intention. While RH_KABI_EXTEND_WITH_SIZE is meant to add
new elements that may grow in the future to kABI-protected structures,
From: Zbigniew Jędrzejewski-Szmek on gitlab.com
https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1617#note_845976933
I think it'd make sense to make calls to kernel-install optional: i.e. do them
only if `/usr/bin/kernel-install` is present. The justification is that on
"normal"
From: Zbigniew Jędrzejewski-Szmek on gitlab.com
https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1617#note_845971647
Thank you for the review. I added `Requires(posttrans,preun):
/usr/bin/systemd-detect-virt` and adjusted the comments on the message a bit.
(It was already pulled in via
From: Zbigniew Jędrzejewski-Szmek on gitlab.com
Merge Request: https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1617
NOTE: Truncated patchset due to missing public @redhat.com email
address on your GitLab profile at https://gitlab.com/-/profile.
Once that is fixed, close and
From: Patrick Talbert on gitlab.com
https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1606#note_845967814
@cohuck I've added you to the project so the Approve button should be
available to you now.
___
kernel mailing list --
26 matches
Mail list logo
