✅ PASS: Test report for kernel 5.16.14-200.fc35 (fedora-35)

2022-03-11 Thread CKI Project
Hello, We ran automated tests on the following kernel build: Kernel package: kernel-5.16.14-200.fc35 Task URL: https://koji.fedoraproject.org/koji/taskinfo?taskID=84029919 The results of these automated tests are provided below. Overall result: PASSED Tests: OK

Re: [OS-BUILD PATCH 0/24] redhat/Makefile: Cleanup variables

2022-03-11 Thread Herton R. Krzesinski (via Email Bridge)
From: Herton R. Krzesinski on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1641#note_872389813 Making this a thread. ___ kernel mailing list -- kernel@lists.fedoraproject.org To unsubscribe send an email to kernel-le...@lists.fed

Re: [OS-BUILD PATCH 0/24] redhat/Makefile: Cleanup variables

2022-03-11 Thread Herton R. Krzesinski (via Email Bridge)
From: Herton R. Krzesinski on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1641#note_872389780 Making this a thread. ___ kernel mailing list -- kernel@lists.fedoraproject.org To unsubscribe send an email to kernel-le...@lists.fed

Re: [OS-BUILD PATCH 0/24] redhat/Makefile: Cleanup variables

2022-03-11 Thread Herton R. Krzesinski (via Email Bridge)
From: Herton R. Krzesinski on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1641#note_872389599 Making this a thread. ___ kernel mailing list -- kernel@lists.fedoraproject.org To unsubscribe send an email to kernel-le...@lists.fed

Re: [OS-BUILD PATCH 0/24] redhat/Makefile: Cleanup variables

2022-03-11 Thread Herton R. Krzesinski (via Email Bridge)
From: Herton R. Krzesinski on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1641#note_872386823 - [18/24] `3fbac283b672` ("redhat/Makefile: Cleanup KABI* variables.") You say you move KABIDW variable in this commit, but it's confusing that you are not moving but just cop

Re: [OS-BUILD PATCH 0/24] redhat/Makefile: Cleanup variables

2022-03-11 Thread Herton R. Krzesinski (via Email Bridge)
From: Herton R. Krzesinski on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1641#note_872383775 Also there is a small typo in the changelog or patch tiles in the 3 patches before the last two in the series, where Makefile is spelled as Makfile __

Re: [OS-BUILD PATCH 0/24] redhat/Makefile: Cleanup variables

2022-03-11 Thread Herton R. Krzesinski (via Email Bridge)
From: Herton R. Krzesinski on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1641#note_872383298 - [20/24] `10b8b9ff2a10` ("redhat/genspec.sh: Rework RPMVERSION variable") There is an extra $ added here which looks unintended. _

Re: [OS-BUILD PATCH] redhat: spec: trigger dracut when modules are installed separately

2022-03-11 Thread Herton R. Krzesinski (via Email Bridge)
From: Herton R. Krzesinski on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1644#note_872327753 The logic looks ok however I wonder what happens if you install more than one kernel flavour in the same transaction. May be use the filename with eg. %{KVERREL}%{?1:+%{1}} appen

Re: [OS-BUILD PATCH] redhat: spec: trigger dracut when modules are installed separately

2022-03-11 Thread Herton R. Krzesinski (via Email Bridge)
From: Herton R. Krzesinski on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1644#note_872327749 Need to remove "touch" from this line. ___ kernel mailing list -- kernel@lists.fedoraproject.org To unsubscribe send an email to kerne

Re: [OS-BUILD PATCH] redhat: spec: trigger dracut when modules are installed separately

2022-03-11 Thread Frantisek Hrbata (via Email Bridge)
From: Frantisek Hrbata on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1644#note_871918208 FWIW LGM :smile: ___ kernel mailing list -- kernel@lists.fedoraproject.org To unsubscribe send an email to kernel-le...@lists.fedoraprojec

[OS-BUILD PATCH] redhat/Makefile: Silence dist-clean-configs output

2022-03-11 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava redhat/Makefile: Silence dist-clean-configs output Silence dist-clean-configs output. Signed-off-by: Prarit Bhargava diff --git a/redhat/Makefile b/redhat/Makefile index blahblah..blahblah 100644 --- a/redhat/Makefile +++ b/redhat/Makefile @@ -155,9 +155,7 @@ dist-config

[OS-BUILD PATCH] redhat/configs: Disable watchdog components

2022-03-11 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava redhat/configs: Disable watchdog components These watchdog components are not necessary for RHEL9. CONFIG_IB700_WDT CONFIG_ALIM1535_WDT CONFIG_ALIM7101_WDT CONFIG_I6300ESB_WDT CONFIG_IT8712F_WDT CONFIG_IT87_WDT CONFIG_MACHZ_WDT CONFIG_PCIPCWATCHDOG CONFIG_SMSC_SCH311X_WDT

Re: [OS-BUILD PATCH] redhat: spec: trigger dracut when modules are installed separately

2022-03-11 Thread Frantisek Hrbata (via Email Bridge)
From: Frantisek Hrbata on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1644#note_871877217 > What would happen if user installs only kernel-core RPM (without kernel- modules and kernel meta package)? Would the trigger still run? I would expect that. The docs[1] says: If

[OS-BUILD PATCH 24/24] redhat/Makefile: Reorganize variables

2022-03-11 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava redhat/Makefile: Reorganize variables Reorganize the variables from simple variables to complex variables. Signed-off-by: Prarit Bhargava diff --git a/redhat/Makefile b/redhat/Makefile index blahblah..blahblah 100644 --- a/redhat/Makefile +++ b/redhat/Makefile @@ -35,8 +

[OS-BUILD PATCH 23/24] redhat/Makefile: Add some descriptions

2022-03-11 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava redhat/Makefile: Add some descriptions Add some descriptive text about some of the Makefile sections. Signed-off-by: Prarit Bhargava diff --git a/redhat/Makefile b/redhat/Makefile index blahblah..blahblah 100644 --- a/redhat/Makefile +++ b/redhat/Makefile @@ -1,4 +1,8 @@

[OS-BUILD PATCH 22/24] redhat/Makfile: Move SNAPSHOT check

2022-03-11 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava redhat/Makfile: Move SNAPSHOT check Move the SNAPSHOT check to the only place where it can actually be "1". Signed-off-by: Prarit Bhargava diff --git a/redhat/Makefile b/redhat/Makefile index blahblah..blahblah 100644 --- a/redhat/Makefile +++ b/redhat/Makefile @@ -80,37

[OS-BUILD PATCH 20/24] redhat/genspec.sh: Rework RPMVERSION variable

2022-03-11 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava redhat/genspec.sh: Rework RPMVERSION variable The redhat/genspec.sh file contains $RPMVERSION and $RPM_VERSION variables which don't match the Makefile variables. Create a new KVERSION variable and replace $RPMVERSION with KVERSION, and $RPM_VERSION with $RPMVERSION. Rewo

[OS-BUILD PATCH 21/24] redhat/Makfile: Deprecate BREW_FLAGS, KOJI_FLAGS, and TEST_FLAGS

2022-03-11 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava redhat/Makfile: Deprecate BREW_FLAGS, KOJI_FLAGS, and TEST_FLAGS The BREW_FLAGS, KOJI_FLAGS, and TEST_FLAGS variables can be replaced with BUILD_FLAGS. Mark these three variables for later deprecation and warn users about their usage. Signed-off-by: Prarit Bhargava diff

[OS-BUILD PATCH 18/24] redhat/Makefile: Cleanup KABI* variables.

2022-03-11 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava redhat/Makefile: Cleanup KABI* variables. There is no need for both TARBALL and TARFILE variables. Cleanup the KABI* variables. Extra fix: Move KABIDW to the other KABI variables. Signed-off-by: Prarit Bhargava diff --git a/redhat/Makefile b/redhat/Makefile index blahb

[OS-BUILD PATCH 19/24] redhat/Makefile: Remove dead comment

2022-03-11 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava redhat/Makefile: Remove dead comment This comment no longer applies and can be dropped. Signed-off-by: Prarit Bhargava diff --git a/redhat/Makefile b/redhat/Makefile index blahblah..blahblah 100644 --- a/redhat/Makefile +++ b/redhat/Makefile @@ -96,10 +96,6 @@ ifeq ($(SN

[OS-BUILD PATCH 15/24] redhat/Makefile: Remove extra DIST_BRANCH

2022-03-11 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava redhat/Makefile: Remove extra DIST_BRANCH This is already declared in Makefile.variables. Signed-off-by: Prarit Bhargava diff --git a/redhat/Makefile b/redhat/Makefile index blahblah..blahblah 100644 --- a/redhat/Makefile +++ b/redhat/Makefile @@ -547,7 +547,6 @@ git-tre

[OS-BUILD PATCH 17/24] redhat/Makefile.variables: Default RHGITCOMMIT to HEAD

2022-03-11 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava redhat/Makefile.variables: Default RHGITCOMMIT to HEAD RHGITCOMMIT is equal to HEAD. Rather than recalculating it, just set it to HEAD by default. Signed-off-by: Prarit Bhargava diff --git a/redhat/Makefile.variables b/redhat/Makefile.variables index blahblah..blahblah

[OS-BUILD PATCH 16/24] redhat/scripts/create-tarball.sh: Use Makefile TARBALL variable

2022-03-11 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava redhat/scripts/create-tarball.sh: Use Makefile TARBALL variable Use the Makefile TARBALL variable instead of passing it as an argument. Signed-off-by: Prarit Bhargava diff --git a/redhat/Makefile b/redhat/Makefile index blahblah..blahblah 100644 --- a/redhat/Makefile +++

[OS-BUILD PATCH 14/24] redhat/Makefile: Remove STAMP_VERSION

2022-03-11 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava redhat/Makefile: Remove STAMP_VERSION STAMP_VERSION can be replaced with KVERSION. Remove STAMP_VERSION. Signed-off-by: Prarit Bhargava diff --git a/redhat/Makefile b/redhat/Makefile index blahblah..blahblah 100644 --- a/redhat/Makefile +++ b/redhat/Makefile @@ -5,10 +5

[OS-BUILD PATCH 13/24] redhat/Makefile: Move NO_CONFIGCHECKS to Makefile.variables

2022-03-11 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava redhat/Makefile: Move NO_CONFIGCHECKS to Makefile.variables Move the NO_CONFIGCHECKS variable to Makefile.variables. Signed-off-by: Prarit Bhargava diff --git a/redhat/Makefile b/redhat/Makefile index blahblah..blahblah 100644 --- a/redhat/Makefile +++ b/redhat/Makefile

[OS-BUILD PATCH 11/24] redhat/Makefile: Move RHGIT* variables to Makefile.variables

2022-03-11 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava redhat/Makefile: Move RHGIT* variables to Makefile.variables Mmove the RHGITURL and RHGITCOMMIT variables to Makefile.variables. Signed-off-by: Prarit Bhargava diff --git a/redhat/Makefile b/redhat/Makefile index blahblah..blahblah 100644 --- a/redhat/Makefile +++ b/redh

[OS-BUILD PATCH 10/24] redhat/Makefile: Move PREBUILD_GIT_ONLY to Makefile.variables

2022-03-11 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava redhat/Makefile: Move PREBUILD_GIT_ONLY to Makefile.variables Move PREBUILD_GIT_ONLY to Makefile.variables. Signed-off-by: Prarit Bhargava diff --git a/redhat/Makefile b/redhat/Makefile index blahblah..blahblah 100644 --- a/redhat/Makefile +++ b/redhat/Makefile @@ -79,10

[OS-BUILD PATCH 12/24] redhat/Makefile: Move RHJOBS to Makefile.variables

2022-03-11 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava redhat/Makefile: Move RHJOBS to Makefile.variables Move RHJOBS to Makefile.variables. Signed-off-by: Prarit Bhargava diff --git a/redhat/Makefile b/redhat/Makefile index blahblah..blahblah 100644 --- a/redhat/Makefile +++ b/redhat/Makefile @@ -222,13 +222,15 @@ KABIDW :=

[OS-BUILD PATCH 9/24] redhat/Makefile: Move BUILD to Makefile.variables

2022-03-11 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava redhat/Makefile: Move BUILD to Makefile.variables Move BUILD to Makefile.variables. Signed-off-by: Prarit Bhargava diff --git a/redhat/Makefile b/redhat/Makefile index blahblah..blahblah 100644 --- a/redhat/Makefile +++ b/redhat/Makefile @@ -101,7 +101,9 @@ endif KVERSI

[OS-BUILD PATCH 5/24] redhat/Makefile: Remove RHPRODUCT variable

2022-03-11 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava redhat/Makefile: Remove RHPRODUCT variable The only use of RHPRODUCT is to set the RHDISTGIT_BRANCH variable. Remove the RHPRODUCT variable and just use RHDISTGIT_BRANCH. This will make future change easier. Signed-off-by: Prarit Bhargava diff --git a/redhat/Makefile b

[OS-BUILD PATCH 8/24] redhat/Makefile: Move BUILD_FLAGS to Makefile.variables.

2022-03-11 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava redhat/Makefile: Move BUILD_FLAGS to Makefile.variables. Move BUILD_FLAGS to Makefile.variables. Signed-off-by: Prarit Bhargava diff --git a/redhat/Makefile b/redhat/Makefile index blahblah..blahblah 100644 --- a/redhat/Makefile +++ b/redhat/Makefile @@ -229,6 +229,16 @@

[OS-BUILD PATCH 7/24] redhat/Makefile: Move BUILD_PROFILE to Makefile.variables

2022-03-11 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava redhat/Makefile: Move BUILD_PROFILE to Makefile.variables Move BUILD_PROFILE to Makefile.variables. Signed-off-by: Prarit Bhargava diff --git a/redhat/Makefile b/redhat/Makefile index blahblah..blahblah 100644 --- a/redhat/Makefile +++ b/redhat/Makefile @@ -140,7 +140,9

[OS-BUILD PATCH 6/24] redhat/Makefile: Move BUILD_TARGET and BUILD_SCRATCH_TARGET to Makefile.variables

2022-03-11 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava redhat/Makefile: Move BUILD_TARGET and BUILD_SCRATCH_TARGET to Makefile.variables Move BUILD_TARGET and BUILD_SCRATCH_TARGET to Makefile.variables. Signed-off-by: Prarit Bhargava diff --git a/redhat/Makefile b/redhat/Makefile index blahblah..blahblah 100644 --- a/redhat

[OS-BUILD PATCH 4/24] redhat/Makefile: Cleanup DISTRO variable

2022-03-11 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava redhat/Makefile: Cleanup DISTRO variable Move the DISTRO variable to Makefile.variables and clean up its usage in the Makfile. This creates separate fedora-specific, centos-specific, and 'other'-specific variable sections. Signed-off-by: Prarit Bhargava diff --git a/red

[OS-BUILD PATCH 2/24] redhat: Combine Makefile and Makefile.common

2022-03-11 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava redhat: Combine Makefile and Makefile.common The only include of Makefile.common is the Makefile. Combine the two files in Makefile. Signed-off-by: Prarit Bhargava diff --git a/redhat/Makefile b/redhat/Makefile index blahblah..blahblah 100644 --- a/redhat/Makefile +++ b

[OS-BUILD PATCH 1/24] redhat/koji/Makefile: Decouple koji Makefile from Makefile.common

2022-03-11 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava redhat/koji/Makefile: Decouple koji Makefile from Makefile.common The koji Makefile uses the GIT and PACKAGE_NAME variables which are currently defined in Makefile.common. Since these are configurable by a user they should actually be defined in Makefile.variables. Move G

[OS-BUILD PATCH 3/24] redhat/Makefile: Move HEAD to Makefile.variables.

2022-03-11 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava redhat/Makefile: Move HEAD to Makefile.variables. Move HEAD to Makefile.variables. Signed-off-by: Prarit Bhargava diff --git a/redhat/Makefile b/redhat/Makefile index blahblah..blahblah 100644 --- a/redhat/Makefile +++ b/redhat/Makefile @@ -9,7 +9,6 @@ RPMBUILD := $(shel

[OS-BUILD PATCH 0/24] redhat/Makefile: Cleanup variables

2022-03-11 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava on gitlab.com Merge Request: https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1641 For a long time we have complained about disorganization in the redhat/Makefile. This was because the code was separated into several Makefiles (Makefile.cross, Makefile.rhpkg, Makef

Re: [OS-BUILD PATCH] redhat: spec: trigger dracut when modules are installed separately

2022-03-11 Thread Jan Stancek (via Email Bridge)
From: Jan Stancek on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1644#note_871687831 Reason for posttrans originates in RHBZ 528063 - to generate initrd only when all packages (like some optional firmware) are present. I'm not that familiar with triggerin, so your sugges

Re: [OS-BUILD PATCH] redhat: spec: trigger dracut when modules are installed separately

2022-03-11 Thread Frantisek Hrbata (via Email Bridge)
From: Frantisek Hrbata on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1644#note_871598780 Wouldn't it be possible just to use triggerin instead of posttrans here? ``` %{expand:%%triggerin %{?1:%{1}-}core, %{?1:%{1}-}modules} ``` It would run the full kernel-install instea

[OS-BUILD PATCH] redhat: spec: trigger dracut when modules are installed separately

2022-03-11 Thread Jan Stancek (via Email Bridge)
From: Jan Stancek redhat: spec: trigger dracut when modules are installed separately In most scenarios, users install -core and -modules subpackages at the same time (as part of same transaction). But it is also possible to install -core RPM and then -modules RPM separately. We allow this becaus

Re: [OS-BUILD PATCH] Setting CONFIG_I2C_SMBUS to "m" for ark

2022-03-11 Thread Patrick Talbert (via Email Bridge)
From: Patrick Talbert on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1626#note_871346892 Thank you @perobins. I am marking this thread as Resolved then. ___ kernel mailing list -- kernel@lists.fedoraproject.org To unsubscribe se