Re: [OS-BUILD PATCHv5 0/8] redhat/self-test: Add new tests

2022-03-29 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1706#note_893655753 Oops. Bad typo. Fixed. ___ kernel mailing list -- kernel@lists.fedoraproject.org To unsubscribe send an email to kernel-le...@lists.fedor

[OS-BUILD PATCHv5 7/8] redhat/self-tests: Ignore RHGITURL

2022-03-29 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava redhat/self-tests: Ignore RHGITURL While testing, dzickus noticed that his RHGITURL was different from the RHGITURL in the default data. This is because RHGITURL is dependent on the user's local git configuration and therefore cannot be guaranteed to be unique across all u

[OS-BUILD PATCHv5 8/8] redhat/self-tests: Ignore UPSTREAM

2022-03-29 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava redhat/self-tests: Ignore UPSTREAM While testing, dzickus noticed that his UPSTREAM was different from the UPSTREAM in the default data. This is because UPSTREAM is the base merge commit and will change as the repository is updated. Ignore UPSTREAM from the data set. Rep

[OS-BUILD PATCHv5 6/8] redhat/Makefile.variables: Extend git hash length to 15

2022-03-29 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava redhat/Makefile.variables: Extend git hash length to 15 While testing the dist-self-test-data target, dzickus noticed that the git hash lengths were 13 and not 12 on his output. After discussion, and to avoid future problems, we have decided to default the hash length to 1

[OS-BUILD PATCHv5 4/8] redhat/genspec.sh: Rearrange genspec.sh

2022-03-29 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava redhat/genspec.sh: Rearrange genspec.sh genspec.sh takes a long time to run when executed to create test examples. The script does three things: creates a changelog, creates a patch file, and creates the specfile. Reorganize the code so that the specfile is created first,

[OS-BUILD PATCHv5 1/8] redhat/self-test: Add variable test data

2022-03-29 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava redhat/self-test: Add variable test data Add test data for various release types, a script to create the data, and a Makefile target. This data will be used as a baseline for testing of Makefile changes. Note: By default, 'make self-test-data' outputs absolute paths. The

[OS-BUILD PATCHv5 0/8] redhat/self-test: Add new tests

2022-03-29 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava on gitlab.com Merge Request: https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1706 Making changes to the Makefiles has been difficult and revealed minor issues with even the simplest of changes. Having a test that compares the Makefile variables to a "known good" s

[OS-BUILD PATCHv5 5/8] redhat/self-test: Remove changelog from spec files

2022-03-29 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava redhat/self-test: Remove changelog from spec files Remove the changelog entries from spec files and replace it with a generic one line entry. We currently do not have changelog tests, and removing them at this time will make testing easier. Signed-off-by: Prarit Bhargava

[OS-BUILD PATCHv5 3/8] redhat/self-test: Add spec file data

2022-03-29 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava redhat/self-test: Add spec file data Add spec file examples for various release types and modify create-data.sh to create the data. This data will be used as a baseline for testing of Makefile changes. Signed-off-by: Prarit Bhargava diff --git a/redhat/self-test/data/ce

[OS-BUILD PATCHv5 2/8] redhat/self-test: Add better dist-dump-variables test

2022-03-29 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava redhat/self-test: Add better dist-dump-variables test The current dist-dump-variables test is not adequate in that it only tests a small number of fields. Add a test to run create-data.sh and compare that data against the stored "known good" output in self-test/data. Sign

Re: [OS-BUILD PATCHv4 0/8] redhat/self-test: Add new tests

2022-03-29 Thread Don Zickus (via Email Bridge)
From: Don Zickus on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1706#note_893275813 remove 'be used' ___ kernel mailing list -- kernel@lists.fedoraproject.org To unsubscribe send an email to kernel-le...@lists.fedoraproject.org

Re: [OS-BUILD PATCHv4 0/8] redhat/self-test: Add new tests

2022-03-29 Thread Don Zickus (via Email Bridge)
From: Don Zickus on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1706#note_893269386 Other than the #skip line being too long, things look good. Thanks! ___ kernel mailing list -- kernel@lists.fedoraproject.org To unsubscribe sen

Re: [OS-BUILD PATCHv4 0/8] redhat/self-test: Add new tests

2022-03-29 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1706#note_893244573 >privately sent log output with failures. My UPSTREAM var is different than the commits. Thanks. I cleaned up the shellcheck warning(s) in the commits, and then added a new commit

[OS-BUILD PATCHv4 1/8] redhat/self-test: Add variable test data

2022-03-29 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava redhat/self-test: Add variable test data Add test data for various release types, a script to create the data, and a Makefile target. This data will be used as a baseline for testing of Makefile changes. Note: By default, 'make self-test-data' outputs absolute paths. The

[OS-BUILD PATCHv4 4/8] redhat/genspec.sh: Rearrange genspec.sh

2022-03-29 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava redhat/genspec.sh: Rearrange genspec.sh genspec.sh takes a long time to run when executed to create test examples. The script does three things: creates a changelog, creates a patch file, and creates the specfile. Reorganize the code so that the specfile is created first,

[OS-BUILD PATCHv4 8/8] redhat/self-tests: Ignore UPSTREAM

2022-03-29 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava redhat/self-tests: Ignore UPSTREAM While testing, dzickus noticed that his UPSTREAM was different from the UPSTREAM in the default data. This is because UPSTREAM is the base merge commit and will change as the repository is updated. Ignore UPSTREAM from the data set. Rep

[OS-BUILD PATCHv4 6/8] redhat/Makefile.variables: Extend git hash length to 15

2022-03-29 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava redhat/Makefile.variables: Extend git hash length to 15 While testing the dist-self-test-data target, dzickus noticed that the git hash lengths were 13 and not 12 on his output. After discussion, and to avoid future problems, we have decided to default the hash length to 1

[OS-BUILD PATCHv4 3/8] redhat/self-test: Add spec file data

2022-03-29 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava redhat/self-test: Add spec file data Add spec file examples for various release types and modify create-data.sh to create the data. This data will be used as a baseline for testing of Makefile changes. Signed-off-by: Prarit Bhargava diff --git a/redhat/self-test/data/ce

[OS-BUILD PATCHv4 7/8] redhat/self-tests: Ignore RHGITURL

2022-03-29 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava redhat/self-tests: Ignore RHGITURL While testing, dzickus noticed that his RHGITURL was different from the RHGITURL in the default data. This is because RHGITURL is dependent on the user's local git configuration and therefore cannot be guaranteed to be unique across all u

[OS-BUILD PATCHv4 2/8] redhat/self-test: Add better dist-dump-variables test

2022-03-29 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava redhat/self-test: Add better dist-dump-variables test The current dist-dump-variables test is not adequate in that it only tests a small number of fields. Add a test to run create-data.sh and compare that data against the stored "known good" output in self-test/data. Sign

[OS-BUILD PATCHv4 5/8] redhat/self-test: Remove changelog from spec files

2022-03-29 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava redhat/self-test: Remove changelog from spec files Remove the changelog entries from spec files and replace it with a generic one line entry. We currently do not have changelog tests, and removing them at this time will make testing easier. Signed-off-by: Prarit Bhargava

[OS-BUILD PATCHv4 0/8] redhat/self-test: Add new tests

2022-03-29 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava on gitlab.com Merge Request: https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1706 Making changes to the Makefiles has been difficult and revealed minor issues with even the simplest of changes. Having a test that compares the Makefile variables to a "known good" s

[OS-BUILD PATCH] redhat/configs: enable nf_tables SYNPROXY extension on ark

2022-03-29 Thread Davide Caratti (via Email Bridge)
From: Davide Caratti redhat/configs: enable nf_tables SYNPROXY extension on ark as part of the ongoing iptables deprecation, enable SYNPROXY extension on nftables. While at it, explicitly disable CONFIG_IP{,6}_NF_TARGET_SYNPROXY: they were 'm' but 'make dist-configs' clears them since they depen

Re: [OS-BUILD PATCH] [redhat] UIO: sync up config options with RHEL9

2022-03-29 Thread Justin M. Forbes (via Email Bridge)
From: Justin M. Forbes on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1695#note_893095650 The patch needs to be updated either way. This change has no impact on the RHEL configs at all because the ark config directory has priority over the common directory for RHEL, meani

Re: [OS-BUILD PATCHv3 0/7] redhat/self-test: Add new tests

2022-03-29 Thread Don Zickus (via Email Bridge)
From: Don Zickus on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1706#note_893020098 privately sent log output with failures. My UPSTREAM var is different than the commits. ___ kernel mailing list -- kernel@lists.fedoraproject.o

Re: [OS-BUILD PATCH] [redhat] UIO: sync up config options with RHEL9

2022-03-29 Thread Aristeu Rozanski (via Email Bridge)
From: Aristeu Rozanski on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1695#note_892984183 Patrick, do you agree with Justin or you want me to update the patch? ___ kernel mailing list -- kernel@lists.fedoraproject.org To unsubsc

Re: [OS-BUILD PATCHv3 0/7] redhat/self-test: Add new tests

2022-03-29 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1706#note_892978755 >I like the spirit of the approach. On the surface things make sense and don't look to intrusive. Unfortunately, playing with your MR caused test failures. > >The biggest issues wer

Re: [OS-BUILD PATCH] [redhat] UIO: sync up config options with RHEL9

2022-03-29 Thread Justin M. Forbes (via Email Bridge)
From: Justin M. Forbes on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1695#note_892814613 Right, as it stands, they are enabled on Fedora, but not eln/RHEL. Given what these are used for, I doubt they have Fedora users, though I could be wrong. Going to ack this, and if a

[OS-BUILD PATCH] disable redundant assignment of CONFIG_BQL on ARK

2022-03-29 Thread Davide Caratti (via Email Bridge)
From: Davide Caratti disable redundant assignment of CONFIG_BQL on ARK there is no need to set it explicitly on aarch64, it's already set to 'y' on all arches. tested with: $ make dist-configs $ grep -r CONFIG_BQL redhat/* Signed-off-by: Davide Caratti diff --git a/redhat/configs/ark/generic

Re: [OS-BUILD PATCH] Turn on CONFIG_RANDOM_TRUST_BOOTLOADER

2022-03-29 Thread Patrick Talbert (via Email Bridge)
From: Patrick Talbert on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1681#note_892497914 blocked ___ kernel mailing list -- kernel@lists.fedoraproject.org To unsubscribe send an email to kernel-le...@lists.fedoraproject.org Fedo

Re: [OS-BUILD PATCH] [redhat] UIO: sync up config options with RHEL9

2022-03-29 Thread Patrick Talbert (via Email Bridge)
From: Patrick Talbert on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1695#note_892496202 block ___ kernel mailing list -- kernel@lists.fedoraproject.org To unsubscribe send an email to kernel-le...@lists.fedoraproject.org Fedora

Re: [OS-BUILD PATCH] [redhat] UIO: sync up config options with RHEL9

2022-03-29 Thread Patrick Talbert (via Email Bridge)
From: Patrick Talbert on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1695#note_892495802 This will change fedora as well so @jmflinuxtx. Also, these options are `not set` in `ark/generic` and `ark/generic/s390x`. So if they are to be disabled in `common/generic` then tho

❌ FAIL: Test report for kernel 5.16.18-200.fc35 (fedora-35)

2022-03-29 Thread CKI Project
Hello, We ran automated tests on the following kernel build: Kernel package: kernel-5.16.18-200.fc35 Task URL: https://koji.fedoraproject.org/koji/taskinfo?taskID=84836433 The results of these automated tests are provided below. Overall result: FAILED (see details below)

Re: [OS-BUILD PATCH] Turn on CONFIG_RANDOM_TRUST_BOOTLOADER

2022-03-29 Thread Patrick Talbert (via Email Bridge)
From: Patrick Talbert on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1681#note_892428406 @prarit @dledford Are you okay with this? ___ kernel mailing list -- kernel@lists.fedoraproject.org To unsubscribe send an email to kernel-