Re: [OS-BUILD PATCH 0/3] redhat/Makefile: Deprecate variables

2022-07-28 Thread Herton R. Krzesinski (via Email Bridge)
From: Herton R. Krzesinski on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1922#note_1043048801 @prarit I was about to merge this, but just noticed: ``` redhat/self-test/data/create-data.sh:makefile_vars=$(unset SINGLE_TARBALL; make dist-dump-variables | grep "=" | cut

What purpose does the redhat/Makefile "MARKER is" line serve?

2022-07-28 Thread Prarit Bhargava
$subject essentially. Does it actually serve any purpose. I know its been there a long time but I'm not sure if it serves any actual purpose anymore other than creating noise in the output. The line itself is output from redhat/genspec.py:176 and IMO can be deleted but before I submit an MR

[OS-BUILD PATCH 3/3] redhat/Makefile: Deprecate PREBUILD_GIT_ONLY variable

2022-07-28 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava redhat/Makefile: Deprecate PREBUILD_GIT_ONLY variable Deprecate the PREBUILD_GIT_ONLY variable. Signed-off-by: Prarit Bhargava diff --git a/redhat/Makefile b/redhat/Makefile index blahblah..blahblah 100644 --- a/redhat/Makefile +++ b/redhat/Makefile @@ -3,12 +3,6 @@ #

[OS-BUILD PATCH 2/3] redhat/Makefile: Deprecate SINGLE_TARBALL variable

2022-07-28 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava redhat/Makefile: Deprecate SINGLE_TARBALL variable Deprecate the SINGLE_TARBALL variable. Signed-off-by: Prarit Bhargava diff --git a/redhat/Makefile b/redhat/Makefile index blahblah..blahblah 100644 --- a/redhat/Makefile +++ b/redhat/Makefile @@ -3,13 +3,6 @@ # #

[OS-BUILD PATCH 1/3] redhat/Makefile: Deprecate GIT variable

2022-07-28 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava redhat/Makefile: Deprecate GIT variable The GIT variable was added in the early days of the self-tests. After commit c86f798cefbf ("redhat/self-test: Add better dist-dump-variables test") the variable is no longer necessary. Signed-off-by: Prarit Bhargava diff --git

[OS-BUILD PATCH 0/3] redhat/Makefile: Deprecate variables

2022-07-28 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava on gitlab.com Merge Request: https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1922 Mark the GIT variable for deprecation and remove the SINGLE_TARBALL and PREBUILD_GIT_ONLY variables which were deprecated in 5.18.0. Signed-off-by: Prarit Bhargava ---

Re: [OS-BUILD PATCHv4 0/6] redhat/configs: Enable INIT_STACK_ALL_ZERO for Fedora

2022-07-28 Thread Miko Larsson (via Email Bridge)
From: Miko Larsson on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1923#note_1042085885 Also, FWIW, see !961: > We also want to enable the structleak and stackleak GCC plugins, but currently they're causing a lot of pain with slight GCC mismatches. Until that problem gets

Re: [OS-BUILD PATCHv4 0/6] redhat/configs: Enable INIT_STACK_ALL_ZERO for Fedora

2022-07-28 Thread Miko Larsson (via Email Bridge)
From: Miko Larsson on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1923#note_1041694276 There's probably a very slight performance impact, but I'd imagine it's negligible. Proper testings should be performed if performance is a concern, though.

[OS-BUILD PATCHv4 6/6] redhat/configs: Unset INIT_STACK_NONE for Fedora

2022-07-28 Thread Miko Larsson (via Email Bridge)
From: Miko Larsson redhat/configs: Unset INIT_STACK_NONE for Fedora We want to use INIT_STACK_ALL_ZERO on Fedora, so INIT_STACK_NONE shouldn't be set. Signed-off-by: Miko Larsson diff --git a/redhat/configs/fedora/generic/CONFIG_INIT_STACK_NONE

[OS-BUILD PATCHv4 5/6] redhat/configs: Set INIT_STACK_NONE for ark

2022-07-28 Thread Miko Larsson (via Email Bridge)
From: Miko Larsson redhat/configs: Set INIT_STACK_NONE for ark RHEL9+ doesn't ship with GCC 12+, so INIT_STACK_NONE should be set. Signed-off-by: Miko Larsson diff --git a/redhat/configs/ark/generic/CONFIG_INIT_STACK_NONE b/redhat/configs/ark/generic/CONFIG_INIT_STACK_NONE new file mode

[OS-BUILD PATCHv4 4/6] redhat/configs: Remove INIT_STACK_NONE from common

2022-07-28 Thread Miko Larsson (via Email Bridge)
From: Miko Larsson redhat/configs: Remove INIT_STACK_NONE from common We want this to be unset on Fedora so that we can use INIT_STACK_ALL_ZERO. Signed-off-by: Miko Larsson diff --git a/redhat/configs/common/generic/CONFIG_INIT_STACK_NONE

[OS-BUILD PATCHv4 0/6] redhat/configs: Enable INIT_STACK_ALL_ZERO for Fedora

2022-07-28 Thread Miko Larsson (via Email Bridge)
From: Miko Larsson on gitlab.com Merge Request: https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1923 In !961, it was proposed that STRUCTLEAK_BYREF_ALL should be enabled, but that specific proposal was rejected due to structleak being a GCC plugin. However, in GCC 12, support for

[OS-BUILD PATCHv4 1/6] redhat/configs: Enable INIT_STACK_ALL_ZERO for Fedora

2022-07-28 Thread Miko Larsson (via Email Bridge)
From: Miko Larsson redhat/configs: Enable INIT_STACK_ALL_ZERO for Fedora In !961, it was proposed that STRUCTLEAK_BYREF_ALL should be enabled, but that specific proposal was rejected due to structleak being a GCC plugin. However, in GCC 12, support for INIT_STACK_ALL_ZERO was introduced, which

[OS-BUILD PATCHv4 2/6] redhat/configs: Remove INIT_STACK_ALL_ZERO from common

2022-07-28 Thread Miko Larsson (via Email Bridge)
From: Miko Larsson redhat/configs: Remove INIT_STACK_ALL_ZERO from common We want to enable this on Fedora. Signed-off-by: Miko Larsson diff --git a/redhat/configs/common/generic/CONFIG_INIT_STACK_ALL_ZERO b/redhat/configs/common/generic/CONFIG_INIT_STACK_ALL_ZERO deleted file mode 100644

[OS-BUILD PATCHv4 3/6] redhat/configs: Disable INIT_STACK_ALL_ZERO for ark

2022-07-28 Thread Miko Larsson (via Email Bridge)
From: Miko Larsson redhat/configs: Disable INIT_STACK_ALL_ZERO for ark RHEL9 doesn't ship with GCC 12+, so we can't use INIT_STACK_ALL_ZERO there. Signed-off-by: Miko Larsson diff --git a/redhat/configs/ark/generic/CONFIG_INIT_STACK_ALL_ZERO

Re: [OS-BUILD PATCHv3 0/3] redhat/configs: Enable INIT_STACK_ALL_ZERO for Fedora

2022-07-28 Thread pbrobinson (via Email Bridge)
From: pbrobinson on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1923#note_1041662400 Is there a performance impact? ___ kernel mailing list -- kernel@lists.fedoraproject.org To unsubscribe send an email to

[OS-BUILD PATCHv3 2/3] redhat/configs: Remove INIT_STACK_ALL_ZERO from common

2022-07-28 Thread Miko Larsson (via Email Bridge)
From: Miko Larsson redhat/configs: Remove INIT_STACK_ALL_ZERO from common We want to enable this on Fedora. Signed-off-by: Miko Larsson diff --git a/redhat/configs/common/generic/CONFIG_INIT_STACK_ALL_ZERO b/redhat/configs/common/generic/CONFIG_INIT_STACK_ALL_ZERO deleted file mode 100644

[OS-BUILD PATCHv3 3/3] redhat/configs: Disable INIT_STACK_ALL_ZERO for ark

2022-07-28 Thread Miko Larsson (via Email Bridge)
From: Miko Larsson redhat/configs: Disable INIT_STACK_ALL_ZERO for ark RHEL9 doesn't ship with GCC 12+, so we can't use INIT_STACK_ALL_ZERO there. Signed-off-by: Miko Larsson diff --git a/redhat/configs/ark/generic/CONFIG_INIT_STACK_ALL_ZERO

[OS-BUILD PATCHv3 0/3] redhat/configs: Enable INIT_STACK_ALL_ZERO for Fedora

2022-07-28 Thread Miko Larsson (via Email Bridge)
From: Miko Larsson on gitlab.com Merge Request: https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1923 In !961, it was proposed that STRUCTLEAK_BYREF_ALL should be enabled, but that specific proposal was rejected due to structleak being a GCC plugin. However, in GCC 12, support for

[OS-BUILD PATCHv3 1/3] redhat/configs: Enable INIT_STACK_ALL_ZERO for Fedora

2022-07-28 Thread Miko Larsson (via Email Bridge)
From: Miko Larsson redhat/configs: Enable INIT_STACK_ALL_ZERO for Fedora In !961, it was proposed that STRUCTLEAK_BYREF_ALL should be enabled, but that specific proposal was rejected due to structleak being a GCC plugin. However, in GCC 12, support for INIT_STACK_ALL_ZERO was introduced, which

[OS-BUILD PATCHv2 3/3] redhat/configs: Disable INIT_STACK_ALL_ZERO for ark

2022-07-28 Thread Miko Larsson (via Email Bridge)
From: Miko Larsson redhat/configs: Disable INIT_STACK_ALL_ZERO for ark RHEL9 doesn't ship with GCC 12+, so we can't use INIT_STACK_ALL_ZERO there. Signed-off-by: Miko Larsson diff --git a/redhat/configs/ark/generic/CONFIG_INIT_STACK_ALL_ZERO

[OS-BUILD PATCHv2 2/3] redhat/configs: Remove CONFIG_INIT_STACK_ALL_ZERO

2022-07-28 Thread Miko Larsson (via Email Bridge)
From: Miko Larsson redhat/configs: Remove CONFIG_INIT_STACK_ALL_ZERO We want to enable this on Fedora. Signed-off-by: Miko Larsson diff --git a/redhat/configs/common/generic/CONFIG_INIT_STACK_ALL_ZERO b/redhat/configs/common/generic/CONFIG_INIT_STACK_ALL_ZERO deleted file mode 100644 index

[OS-BUILD PATCHv2 1/3] redhat/configs: Enable INIT_STACK_ALL_ZERO for Fedora

2022-07-28 Thread Miko Larsson (via Email Bridge)
From: Miko Larsson redhat/configs: Enable INIT_STACK_ALL_ZERO for Fedora In !961, it was proposed that STRUCTLEAK_BYREF_ALL should be enabled, but that specific proposal was rejected due to structleak being a GCC plugin. However, in GCC 12, support for INIT_STACK_ALL_ZERO was introduced, which

[OS-BUILD PATCHv2 0/3] redhat/configs: Enable INIT_STACK_ALL_ZERO for Fedora

2022-07-28 Thread Miko Larsson (via Email Bridge)
From: Miko Larsson on gitlab.com Merge Request: https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1923 In !961, it was proposed that STRUCTLEAK_BYREF_ALL should be enabled, but that specific proposal was rejected due to structleak being a GCC plugin. However, in GCC 12, support for

Re: [OS-BUILD PATCH] redhat/configs: Enable INIT_STACK_ALL_ZERO for Fedora

2022-07-28 Thread Miko Larsson (via Email Bridge)
From: Miko Larsson on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1923#note_1041620024 Mm, this is embarrassing. Argh ___ kernel mailing list -- kernel@lists.fedoraproject.org To unsubscribe send an email to

[OS-BUILD PATCH] redhat/configs: Enable INIT_STACK_ALL_ZERO for Fedora

2022-07-28 Thread Miko Larsson (via Email Bridge)
From: Miko Larsson redhat/configs: Enable INIT_STACK_ALL_ZERO for Fedora In !961, it was proposed that STRUCTLEAK_BYREF_ALL should be enabled, but that specific proposal was rejected due to structleak being a GCC plugin. However, in GCC 12, support for INIT_STACK_ALL_ZERO was introduced, which