[OS-BUILD PATCH] Turn off forced debug builds

2023-01-23 Thread Justin M. Forbes (via Email Bridge)
From: Justin M. Forbes Turn off forced debug builds For many years, rawhide kernels have forced users to run debug builds on git snapshots by not building a non debug kernel as an option. While this has served us well, in finding occasional bugs that are less likely to surface otherwise, the

Re: [OS-BUILD PATCHv9 0/5] makefile: Add -Werror support for RHEL

2023-01-23 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/2240#note_1249865169 Oops. Fixed. ___ kernel mailing list -- kernel@lists.fedoraproject.org To unsubscribe send an email to

[OS-BUILD PATCHv9 1/5] redhat/Makefile.variables: Alphabetize variables

2023-01-23 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava redhat/Makefile.variables: Alphabetize variables Alphabetize the variables in the file. There is no functional change with this commit. Signed-off-by: Prarit Bhargava diff --git a/redhat/Makefile.variables b/redhat/Makefile.variables index blahblah..blahblah 100644 ---

[OS-BUILD PATCHv9 3/5] makefile: Add -Werror support for RHEL

2023-01-23 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava makefile: Add -Werror support for RHEL The -Werror flag should be enabled for RHEL. In ARK, however, it is a bit tricky to enable -Werror as a build bug occasionally leaks through upstream review and into Linus' tree. As a consequence, CONFIG_WERROR cannot be enabled in

[OS-BUILD PATCHv9 5/5] redhat/self-test: Update data with ENABLE_WERROR

2023-01-23 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava redhat/self-test: Update data with ENABLE_WERROR This changeset introduces ENABLE_WERROR. Signed-off-by: Prarit Bhargava diff --git a/redhat/self-test/data/centos-2585cf9dfaad.el7 b/redhat/self-test/data/centos-2585cf9dfaad.el7 index blahblah..blahblah 100644 ---

[OS-BUILD PATCHv9 4/5] redhat/Makefile.variables: Add ENABLE_WERROR

2023-01-23 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava redhat/Makefile.variables: Add ENABLE_WERROR kernel-ark requires CONFIG_WERROR be disabled due to the rate of change in the upstream toolchain. This differs from RHEL where they need CONFIG_WERROR=y. Instead of trying to remember to set CONFIG_WERROR=y when RHEL is

[OS-BUILD PATCHv9 2/5] redhat/Makefile.variables: Remove mention of Makefile.rhpkg

2023-01-23 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava redhat/Makefile.variables: Remove mention of Makefile.rhpkg The Makefile.rhpkg no longer exists. Signed-off-by: Prarit Bhargava diff --git a/redhat/Makefile.variables b/redhat/Makefile.variables index blahblah..blahblah 100644 --- a/redhat/Makefile.variables +++

[OS-BUILD PATCHv9 0/5] makefile: Add -Werror support for RHEL

2023-01-23 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava on gitlab.com Merge Request: https://gitlab.com/cki-project/kernel-ark/-/merge_requests/2240 The -Werror flag should be enabled for RHEL. In ARK, however, it is a bit tricky to enable -Werror as a build bug occasionally leaks through upstream review and into Linus' tree,

Re: [OS-BUILD PATCHv5] redhat: Add sub-RPM with a EFI unified kernel image for virtual machines

2023-01-23 Thread via Email Bridge
From: Veronika Kabátová on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/2175#note_1249831495 Yeah those dependencies were only added for c9s/RHEL: https://gitlab.com/cki- project/containers/-/commit/0576f7e12c3a9198faa8eb7622ab5e86e4375be9 The changes need to be added to

Re: [OS-BUILD PATCH] Disable frame pointers

2023-01-23 Thread Patrick Talbert (via Email Bridge)
From: Patrick Talbert on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/2260#note_1249818380 @jmflinuxtx It is not clear from the build job but the failure is here: https://s3.amazonaws.com/arr-cki-prod-trusted-artifacts/trusted-

Re: [OS-BUILD PATCHv5] redhat: Add sub-RPM with a EFI unified kernel image for virtual machines

2023-01-23 Thread Patrick Talbert (via Email Bridge)
From: Patrick Talbert on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/2175#note_1249814131 @vkuznets The build stage of the pipeline fails due to missing rpm dependencies: https://gitlab.com/redhat/red-hat-ci-tools/kernel/cki-internal-pipelines/cki-

Re: [OS-BUILD PATCHv8 0/4] makefile: Add -Werror support for RHEL

2023-01-23 Thread Patrick Talbert (via Email Bridge)
From: Patrick Talbert on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/2240#note_1249812545 @prarit it looks like the selftest dies because of a new environment variable? https://gitlab.com/redhat/red-hat-ci-tools/kernel/cki-internal-pipelines/cki-

Re: [OS-BUILD PATCH 2/4] redhat/kernel.spec.template: Fix vmlinux_decompressor on !s390x

2023-01-23 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/2255#note_1249648372 Changed in new version. ___ kernel mailing list -- kernel@lists.fedoraproject.org To unsubscribe send an email to

[OS-BUILD PATCHv2 4/4] redhat/kernel.spec.template: Fix internal "File listed twice" errors

2023-01-23 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava redhat/kernel.spec.template: Fix internal "File listed twice" errors Executing an rpm build results in a "File listed twice" error for every file in the modules-internal subpackage. The modules-internal subpackage's file list is created by mod-denylist.sh. The file

[OS-BUILD PATCHv2 3/4] redhat: Remove stale .tmp_versions code and comments

2023-01-23 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava redhat: Remove stale .tmp_versions code and comments At sometime prior to the beginning of this repository, .tmp_versions was removed as a temporary data store in the rpm build. Unfortunately two references to it remain: one as a comment and one in code. The code remnant

[OS-BUILD PATCHv2 0/4] rpm builds: Fix warnings and output

2023-01-23 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava on gitlab.com Merge Request: https://gitlab.com/cki-project/kernel-ark/-/merge_requests/2255 There are several groups of warnings and output that should be fixed in the kernel's rpm build commands. 1) The output of pathfix.py is too noisy. Users do not need to see the

[OS-BUILD PATCHv2 2/4] redhat/kernel.spec.template: Fix vmlinux_decompressor on !s390x

2023-01-23 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava redhat/kernel.spec.template: Fix vmlinux_decompressor on !s390x The build log contains eu-readelf: cannot open input file '%{vmlinux_decompressor}': No such file or directory This should only execute on s390x. Fix vmlinux_decompressor warnings for all other arches.

[OS-BUILD PATCHv2 1/4] redhat/kernel.spec.template: Remove unnecessary output from pathfix.py

2023-01-23 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava redhat/kernel.spec.template: Remove unnecessary output from pathfix.py pathfix.py outputs directory names as it traverses them looking for files to fix, for example, recursedown('tools') recursedown('tools/accounting') recursedown('tools/arch') This information isn't

[OS-BUILD PATCHv7] redhat/kernel.spec.template: Parallelize compression

2023-01-23 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava redhat/kernel.spec.template: Parallelize compression This line in the kernel.spec file: find $RPM_BUILD_ROOT/lib/modules/ -type f -name '*.ko' | xargs -P${RPM_BUILD_NCPUS} -r xz; implies that ${RPM_BUILD_NCPUS} xz instances are run. This is not true, and this line

Re: [OS-BUILD PATCHv6] redhat/kernel.spec.template: Parallelize compression

2023-01-23 Thread Herton R. Krzesinski (via Email Bridge)
From: Herton R. Krzesinski on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/2254#note_1249574743 @prarit didn't see changes compared to latest version, didn't you want it to be ```-n 16```? ___ kernel mailing list --

[OS-BUILD PATCH 2/2] redhat: remove merge.pl and references to it

2023-01-23 Thread Clark Williams (via Email Bridge)
From: Clark Williams redhat: remove merge.pl and references to it get rid of redhat/configs/merge.pl and any references to it in redhat/kernel.spec.template and redhat/Makefile Signed-off-by: Clark Williams diff --git a/redhat/Makefile b/redhat/Makefile index blahblah..blahblah 100644 ---

[OS-BUILD PATCH 1/2] redhat: update merge.py to handle merge.pl corner cases

2023-01-23 Thread Clark Williams (via Email Bridge)
From: Clark Williams redhat: update merge.py to handle merge.pl corner cases Change merge.py to handle input config files in similar manner to how merge.pl did it. Signed-off-by: Clark Williams diff --git a/redhat/configs/merge.py b/redhat/configs/merge.py index blahblah..blahblah 100755

[OS-BUILD PATCH 0/2] redhat: update merge.py to handle merge.pl corner cases

2023-01-23 Thread Clark Williams (via Email Bridge)
From: Clark Williams on gitlab.com Merge Request: https://gitlab.com/cki-project/kernel-ark/-/merge_requests/2262 Change merge.py to handle input config files in similar manner to how merge.pl did it. Signed-off-by: Clark Williams --- redhat/configs/merge.pl | 72

Re: [OS-BUILD PATCHv6] redhat/kernel.spec.template: Parallelize compression

2023-01-23 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/2254#note_1249554679 Set to -16 as requested. ___ kernel mailing list -- kernel@lists.fedoraproject.org To unsubscribe send an email to

[OS-BUILD PATCHv6] redhat/kernel.spec.template: Parallelize compression

2023-01-23 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava redhat/kernel.spec.template: Parallelize compression This line in the kernel.spec file: find $RPM_BUILD_ROOT/lib/modules/ -type f -name '*.ko' | xargs -P${RPM_BUILD_NCPUS} -r xz; implies that ${RPM_BUILD_NCPUS} xz instances are run. This is not true, and this line

Re: [OS-BUILD PATCHv2] Revert "redhat: fix elf got hardening for vm tools"

2023-01-23 Thread Herton R. Krzesinski (via Email Bridge)
From: Herton R. Krzesinski on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/2236#note_1249510524 We agreed in the last ark meeting we need this patch and the CFLAGS underlying issue will be fixed once upstream patch https://www.spinics.net/lists/kernel/msg4653901.html

[OS-BUILD PATCH] redhat/self-test/data: Regenerate self-test data for make change

2023-01-23 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava redhat/self-test/data: Regenerate self-test data for make change make 4.4 has dropped the -w flag by default. This affects the MAKEFLAGS variable in the kernel and the self-test data has to be regenerated. Regenerate the self-test data. Signed-off-by: Prarit Bhargava

Re: [OS-BUILD PATCHv5] redhat/kernel.spec.template: Parallelize compression

2023-01-23 Thread Denys Vlasenko (via Email Bridge)
From: Denys Vlasenko on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/2254#note_1249493515 We usually have 2000..4000 modules. With e.g. -n 1000, you obviously risk having fewer "xz" processes than CPUs. Even with -n 100, conceivably on a big machine, you can underutilize

Re: [OS-BUILD PATCHv5] redhat/kernel.spec.template: Parallelize compression

2023-01-23 Thread Herton R. Krzesinski (via Email Bridge)
From: Herton R. Krzesinski on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/2254#note_1249483495 I don't think we need to overengineer this. I agree fork costs can be something to avoid, but we don't need a separate script. If there is a heuristic for it we should

[OS-BUILD PATCH] Disable frame pointers

2023-01-23 Thread Justin M. Forbes (via Email Bridge)
From: Justin M. Forbes Disable frame pointers Fedora is defaulting to add -fno-omit-frame-pointer by default. This is not necessary for kernel. Signed-off-by: Justin M. Forbes diff --git a/redhat/kernel.spec.template b/redhat/kernel.spec.template index blahblah..blahblah 100755 ---

[OS-BUILD PATCH] Modularize CONFIG_ARM_CORESIGHT_PMU_ARCH_SYSTEM_PMU

2023-01-23 Thread Mark Salter (via Email Bridge)
From: Mark Salter Modularize CONFIG_ARM_CORESIGHT_PMU_ARCH_SYSTEM_PMU Build arm coresight system pmu as a module. Signed-off-by: Mark Salter diff --git a/redhat/configs/ark/generic/arm/aarch64/CONFIG_ARM_CORESIGHT_PMU_ARCH_SYSTEM_PMU

[OS-BUILD PATCH] Modularize CONFIG_ARM_CORESIGHT_PMU_ARCH_SYSTEM_PMU

2023-01-23 Thread Mark Salter (via Email Bridge)
From: Mark Salter Modularize CONFIG_ARM_CORESIGHT_PMU_ARCH_SYSTEM_PMU MakeBuild arm coresight system pmu as a module. Signed-off-by: Mark Salter diff --git a/redhat/configs/ark/generic/arm/aarch64/CONFIG_ARM_CORESIGHT_PMU_ARCH_SYSTEM_PMU

[OS-BUILD PATCHv5] redhat: Add sub-RPM with a EFI unified kernel image for virtual machines

2023-01-23 Thread Vitaly Kuznetsov (via Email Bridge)
From: Vitaly Kuznetsov redhat: Add sub-RPM with a EFI unified kernel image for virtual machines The new 'kernel-unified-virt' sub-RPM is added on x86_64 targets. This contains an EFI application that provides a combined vmlinux, initrd and cmdline, as a so called 'unified kernel image'. The

Re: [OS-BUILD PATCHv5] redhat/kernel.spec.template: Parallelize compression

2023-01-23 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/2254#note_1249133186 I'd argue then the original version (with a separate parallel script) would be preferable than a magic number. @hertonrk-rh, your thoughts?

Re: [OS-BUILD PATCHv5] redhat/kernel.spec.template: Parallelize compression

2023-01-23 Thread Denys Vlasenko (via Email Bridge)
From: Denys Vlasenko on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/2254#note_1249068590 "-n 1" will spawn one "xz" per every module. This incurs some startup costs (fork+exec+library loading). How about "-n 16", so that each xz process compresses 16 modules, decreasing

[OS-BUILD PATCH 0/0] General cleanups

2023-01-23 Thread pbrobinson (via Email Bridge)
From: pbrobinson on gitlab.com Merge Request: https://gitlab.com/cki-project/kernel-ark/-/merge_requests/2256 NOTE: Truncated patchset due to missing public @redhat.com email address on your GitLab profile at https://gitlab.com/-/profile. Once that is fixed, close and reopen the merge

Re: [OS-BUILD PATCH 2/4] redhat/kernel.spec.template: Fix vmlinux_decompressor on !s390x

2023-01-23 Thread Jan Stancek (via Email Bridge)
From: Jan Stancek on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/2255#note_1248824249 vmlinux_decompressor is already defined only on s390x, so it should be enough to let it expand to empty string otherwise: ``` -if [ -n "%{vmlinux_decompressor}" ]; then +if [ -n