Re: [OS-BUILD PATCH] Fix binutils breakage

2023-10-18 Thread Viktor Malik (via Email Bridge)
From: Viktor Malik on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/2749#note_1608645136 I don't think that setting `TPROGS_CFLAGS` here is correct. The reason is that `samples/bpf/Makefile` appends a couple of options to `TPROGS_CFLAGS`, particularly several include paths

Re: [OS-BUILD PATCH] Fix binutils breakage

2023-10-18 Thread Herton R. Krzesinski (via Email Bridge)
From: Herton R. Krzesinski on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/2749#note_1609004744 The way to do it in this case should be: ```TPROGS_CFLAGS="%{?build_hostcflags}" %{make} %{?_smp_mflags} ARCH=$Arch V=1 M=samples/bpf/ VMLINUX_H="${RPM_VMLINUX_H}" || true``` P

Re: [OS-BUILD PATCH] Fix binutils breakage

2023-10-18 Thread Viktor Malik (via Email Bridge)
From: Viktor Malik on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/2749#note_1609047113 Agreed, I just wasn't sure if this is acceptable for the specfile. Makefile always uses `+=` so it should work without modification (except for the above Don's patch to enable setting `

Re: [OS-BUILD PATCH] Fix binutils breakage

2023-10-18 Thread Viktor Malik (via Email Bridge)
From: Viktor Malik on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/2749#note_1609066156 Argh, it won't work b/c [samples/bpf/Makefile:315](https://gitlab.com/cki- project/kernel-ark/-/blob/os-build/samples/bpf/Makefile?ref_type=heads#L315) overrides `TPROGS_CFLAGS` for one

Re: [OS-BUILD PATCH] Fix binutils breakage

2023-10-18 Thread Don Zickus (via Email Bridge)
From: Don Zickus on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/2749#note_1609190998 @hertonrk-rh @vmalikrh - moving TPROGS_xxx to before make resolved my missing includes issue. But I see what @vmalikrh means for that one target. The rpm still builds, so I think we cou

Re: [OS-BUILD PATCH] Fix binutils breakage

2023-10-18 Thread Don Zickus (via Email Bridge)
From: Don Zickus on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/2749#note_1609196658 I guess I spoke too soon, moving the TPROGS_xxx before make still causes rpm to fail. hmm... ___ kernel mailing list -- kernel@lists.fedorapro