Re: [OS-BUILD PATCHv4 0/3] redhat: introduce RH_KABI_EXCLUDE_WITH_SIZE and enable size checks

2023-11-17 Thread Justin M. Forbes (via Email Bridge)
From: Justin M. Forbes on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1619#note_1654178039 Appreciate the updates. As it no longer has Fedora files, my ack is no longer required, but it looks good to me. -- ___ kernel mailing

Re: [OS-BUILD PATCHv4 0/3] redhat: introduce RH_KABI_EXCLUDE_WITH_SIZE and enable size checks

2023-11-17 Thread Sabrina Dubroca (via Email Bridge)
From: Sabrina Dubroca on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1619#note_1654073315 thanks, I removed it now. -- ___ kernel mailing list -- kernel@lists.fedoraproject.org To unsubscribe send an email to

Re: [OS-BUILD PATCHv4 0/3] redhat: introduce RH_KABI_EXCLUDE_WITH_SIZE and enable size checks

2023-11-17 Thread Sabrina Dubroca (via Email Bridge)
From: Sabrina Dubroca on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1619#note_1654073206 also removed. -- ___ kernel mailing list -- kernel@lists.fedoraproject.org To unsubscribe send an email to

[OS-BUILD PATCHv4 3/3] redhat: kABI: add missing RH_KABI_SIZE_ALIGN_CHECKS Kconfig option

2023-11-17 Thread Sabrina Dubroca (via Email Bridge)
From: Sabrina Dubroca redhat: kABI: add missing RH_KABI_SIZE_ALIGN_CHECKS Kconfig option When the kABI macros were copied from the RHEL kernel to ARK, the RH_KABI_SIZE_ALIGN_CHECKS config option was dropped. Without it, the size checks included in some of the kABI macros can't be enabled. Add

[OS-BUILD PATCHv4 2/3] redhat: rh_kabi: introduce RH_KABI_EXCLUDE_WITH_SIZE

2023-11-17 Thread Sabrina Dubroca (via Email Bridge)
From: Sabrina Dubroca redhat: rh_kabi: introduce RH_KABI_EXCLUDE_WITH_SIZE This macro is similar to RH_KABI_EXTEND_WITH_SIZE, but with a different intention. While RH_KABI_EXTEND_WITH_SIZE is meant to add new elements that may grow in the future to kABI-protected structures,

[OS-BUILD PATCHv4 1/3] redhat: rh_kabi: move semicolon inside __RH_KABI_CHECK_SIZE

2023-11-17 Thread Sabrina Dubroca (via Email Bridge)
From: Sabrina Dubroca redhat: rh_kabi: move semicolon inside __RH_KABI_CHECK_SIZE With the current implementation, an unnecessary semicolon is left during the GENKSYMS pass (which doesn't matter since at the moment __RH_KABI_CHECK_SIZE is only used during the !GENKSYMS pass -- it's burried

[OS-BUILD PATCHv4 0/3] redhat: introduce RH_KABI_EXCLUDE_WITH_SIZE and enable size checks

2023-11-17 Thread Sabrina Dubroca (via Email Bridge)
From: Sabrina Dubroca on gitlab.com Merge Request: https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1619 This MR introduces a new kABI macro, RH_KABI_EXCLUDE_WITH_SIZE. The implementation is identical to RH_KABI_EXTEND_WITH_SIZE, but the meaning is more in line with RH_KABI_EXCLUDE. The