[OS-BUILD PATCHv3 9/24] redhat/Makefile: Move BUILD to Makefile.variables

2022-03-12 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava redhat/Makefile: Move BUILD to Makefile.variables Move BUILD to Makefile.variables. Signed-off-by: Prarit Bhargava diff --git a/redhat/Makefile b/redhat/Makefile index blahblah..blahblah 100644 --- a/redhat/Makefile +++ b/redhat/Makefile @@ -101,7 +101,9 @@ endif

[OS-BUILD PATCHv3 11/24] redhat/Makefile: Move RHGIT* variables to Makefile.variables

2022-03-12 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava redhat/Makefile: Move RHGIT* variables to Makefile.variables Mmove the RHGITURL and RHGITCOMMIT variables to Makefile.variables. Signed-off-by: Prarit Bhargava diff --git a/redhat/Makefile b/redhat/Makefile index blahblah..blahblah 100644 --- a/redhat/Makefile +++

[OS-BUILD PATCHv3 5/24] redhat/Makefile: Remove RHPRODUCT variable

2022-03-12 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava redhat/Makefile: Remove RHPRODUCT variable The only use of RHPRODUCT is to set the RHDISTGIT_BRANCH variable. Remove the RHPRODUCT variable and just use RHDISTGIT_BRANCH. This will make future change easier. Signed-off-by: Prarit Bhargava diff --git a/redhat/Makefile

[OS-BUILD PATCHv3 8/24] redhat/Makefile: Move BUILD_FLAGS to Makefile.variables.

2022-03-12 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava redhat/Makefile: Move BUILD_FLAGS to Makefile.variables. Move BUILD_FLAGS to Makefile.variables. Signed-off-by: Prarit Bhargava diff --git a/redhat/Makefile b/redhat/Makefile index blahblah..blahblah 100644 --- a/redhat/Makefile +++ b/redhat/Makefile @@ -229,6 +229,16

[OS-BUILD PATCHv3 7/24] redhat/Makefile: Move BUILD_PROFILE to Makefile.variables

2022-03-12 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava redhat/Makefile: Move BUILD_PROFILE to Makefile.variables Move BUILD_PROFILE to Makefile.variables. Signed-off-by: Prarit Bhargava diff --git a/redhat/Makefile b/redhat/Makefile index blahblah..blahblah 100644 --- a/redhat/Makefile +++ b/redhat/Makefile @@ -140,7 +140,9

[OS-BUILD PATCHv3 2/24] redhat: Combine Makefile and Makefile.common

2022-03-12 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava redhat: Combine Makefile and Makefile.common The only include of Makefile.common is the Makefile. Combine the two files in Makefile. Signed-off-by: Prarit Bhargava diff --git a/redhat/Makefile b/redhat/Makefile index blahblah..blahblah 100644 --- a/redhat/Makefile +++

[OS-BUILD PATCHv3 6/24] redhat/Makefile: Move BUILD_TARGET and BUILD_SCRATCH_TARGET to Makefile.variables

2022-03-12 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava redhat/Makefile: Move BUILD_TARGET and BUILD_SCRATCH_TARGET to Makefile.variables Move BUILD_TARGET and BUILD_SCRATCH_TARGET to Makefile.variables. Signed-off-by: Prarit Bhargava diff --git a/redhat/Makefile b/redhat/Makefile index blahblah..blahblah 100644 ---

[OS-BUILD PATCHv3 4/24] redhat/Makefile: Cleanup DISTRO variable

2022-03-12 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava redhat/Makefile: Cleanup DISTRO variable Move the DISTRO variable to Makefile.variables and clean up its usage in the Makefile. This creates separate fedora-specific, centos-specific, and 'other'-specific variable sections. Signed-off-by: Prarit Bhargava diff --git

[OS-BUILD PATCHv3 1/24] redhat/koji/Makefile: Decouple koji Makefile from Makefile.common

2022-03-12 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava redhat/koji/Makefile: Decouple koji Makefile from Makefile.common The koji Makefile uses the GIT and PACKAGE_NAME variables which are currently defined in Makefile.common. Since these are configurable by a user they should actually be defined in Makefile.variables. Move

[OS-BUILD PATCHv3 3/24] redhat/Makefile: Move HEAD to Makefile.variables.

2022-03-12 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava redhat/Makefile: Move HEAD to Makefile.variables. Move HEAD to Makefile.variables. Signed-off-by: Prarit Bhargava diff --git a/redhat/Makefile b/redhat/Makefile index blahblah..blahblah 100644 --- a/redhat/Makefile +++ b/redhat/Makefile @@ -9,7 +9,6 @@ RPMBUILD :=

[OS-BUILD PATCHv3 0/24] redhat/Makefile: Cleanup variables

2022-03-12 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava on gitlab.com Merge Request: https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1641 For a long time we have complained about disorganization in the redhat/Makefile. This was because the code was separated into several Makefiles (Makefile.cross, Makefile.rhpkg,

Re: [OS-BUILD PATCHv2 0/24] redhat/Makefile: Cleanup variables

2022-03-12 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1641#note_872579104 v3: Fixed @hertonk-rh comments ___ kernel mailing list -- kernel@lists.fedoraproject.org To unsubscribe send an email to

Re: [OS-BUILD PATCHv2 0/24] redhat/Makefile: Cleanup variables

2022-03-12 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1641#note_872578273 Fixed. Will push in a few minutes. ___ kernel mailing list -- kernel@lists.fedoraproject.org To unsubscribe send an email to

Re: [OS-BUILD PATCHv2 0/24] redhat/Makefile: Cleanup variables

2022-03-12 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1641#note_872578032 Fixed. Will push in a few minutes. ___ kernel mailing list -- kernel@lists.fedoraproject.org To unsubscribe send an email to

Re: [OS-BUILD PATCHv2 0/24] redhat/Makefile: Cleanup variables

2022-03-12 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1641#note_872576578 Fixed. Will push in a few minutes. ___ kernel mailing list -- kernel@lists.fedoraproject.org To unsubscribe send an email to

[OS-BUILD PATCHv2 24/24] redhat/Makefile: Reorganize variables

2022-03-12 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava redhat/Makefile: Reorganize variables Reorganize the variables from simple variables to complex variables. Signed-off-by: Prarit Bhargava diff --git a/redhat/Makefile b/redhat/Makefile index blahblah..blahblah 100644 --- a/redhat/Makefile +++ b/redhat/Makefile @@ -35,8

[OS-BUILD PATCHv2 23/24] redhat/Makefile: Add some descriptions

2022-03-12 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava redhat/Makefile: Add some descriptions Add some descriptive text about some of the Makefile sections. Signed-off-by: Prarit Bhargava diff --git a/redhat/Makefile b/redhat/Makefile index blahblah..blahblah 100644 --- a/redhat/Makefile +++ b/redhat/Makefile @@ -1,4 +1,8

[OS-BUILD PATCHv2 22/24] redhat/Makfile: Move SNAPSHOT check

2022-03-12 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava redhat/Makfile: Move SNAPSHOT check Move the SNAPSHOT check to the only place where it can actually be "1". Signed-off-by: Prarit Bhargava diff --git a/redhat/Makefile b/redhat/Makefile index blahblah..blahblah 100644 --- a/redhat/Makefile +++ b/redhat/Makefile @@

[OS-BUILD PATCHv2 20/24] redhat/genspec.sh: Rework RPMVERSION variable

2022-03-12 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava redhat/genspec.sh: Rework RPMVERSION variable The redhat/genspec.sh file contains $RPMVERSION and $RPM_VERSION variables which don't match the Makefile variables. Create a new KVERSION variable and replace $RPMVERSION with KVERSION, and $RPM_VERSION with $RPMVERSION.

[OS-BUILD PATCHv2 19/24] redhat/Makefile: Remove dead comment

2022-03-12 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava redhat/Makefile: Remove dead comment This comment no longer applies and can be dropped. Signed-off-by: Prarit Bhargava diff --git a/redhat/Makefile b/redhat/Makefile index blahblah..blahblah 100644 --- a/redhat/Makefile +++ b/redhat/Makefile @@ -96,10 +96,6 @@ ifeq

[OS-BUILD PATCHv2 21/24] redhat/Makfile: Deprecate BREW_FLAGS, KOJI_FLAGS, and TEST_FLAGS

2022-03-12 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava redhat/Makfile: Deprecate BREW_FLAGS, KOJI_FLAGS, and TEST_FLAGS The BREW_FLAGS, KOJI_FLAGS, and TEST_FLAGS variables can be replaced with BUILD_FLAGS. Mark these three variables for later deprecation and warn users about their usage. Signed-off-by: Prarit Bhargava

[OS-BUILD PATCHv2 18/24] redhat/Makefile: Cleanup KABI* variables.

2022-03-12 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava redhat/Makefile: Cleanup KABI* variables. There is no need for both TARBALL and TARFILE variables. Cleanup the KABI* variables. Extra fix: Move KABIDW to the other KABI variables. Signed-off-by: Prarit Bhargava diff --git a/redhat/Makefile b/redhat/Makefile index

[OS-BUILD PATCHv2 17/24] redhat/Makefile.variables: Default RHGITCOMMIT to HEAD

2022-03-12 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava redhat/Makefile.variables: Default RHGITCOMMIT to HEAD RHGITCOMMIT is equal to HEAD. Rather than recalculating it, just set it to HEAD by default. Signed-off-by: Prarit Bhargava diff --git a/redhat/Makefile.variables b/redhat/Makefile.variables index blahblah..blahblah

[OS-BUILD PATCHv2 15/24] redhat/Makefile: Remove extra DIST_BRANCH

2022-03-12 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava redhat/Makefile: Remove extra DIST_BRANCH This is already declared in Makefile.variables. Signed-off-by: Prarit Bhargava diff --git a/redhat/Makefile b/redhat/Makefile index blahblah..blahblah 100644 --- a/redhat/Makefile +++ b/redhat/Makefile @@ -547,7 +547,6 @@

[OS-BUILD PATCHv2 16/24] redhat/scripts/create-tarball.sh: Use Makefile TARBALL variable

2022-03-12 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava redhat/scripts/create-tarball.sh: Use Makefile TARBALL variable Use the Makefile TARBALL variable instead of passing it as an argument. Signed-off-by: Prarit Bhargava diff --git a/redhat/Makefile b/redhat/Makefile index blahblah..blahblah 100644 --- a/redhat/Makefile

[OS-BUILD PATCHv2 12/24] redhat/Makefile: Move RHJOBS to Makefile.variables

2022-03-12 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava redhat/Makefile: Move RHJOBS to Makefile.variables Move RHJOBS to Makefile.variables. Signed-off-by: Prarit Bhargava diff --git a/redhat/Makefile b/redhat/Makefile index blahblah..blahblah 100644 --- a/redhat/Makefile +++ b/redhat/Makefile @@ -222,13 +222,15 @@ KABIDW

[OS-BUILD PATCHv2 14/24] redhat/Makefile: Remove STAMP_VERSION

2022-03-12 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava redhat/Makefile: Remove STAMP_VERSION STAMP_VERSION can be replaced with KVERSION. Remove STAMP_VERSION. Signed-off-by: Prarit Bhargava diff --git a/redhat/Makefile b/redhat/Makefile index blahblah..blahblah 100644 --- a/redhat/Makefile +++ b/redhat/Makefile @@ -5,10

[OS-BUILD PATCHv2 13/24] redhat/Makefile: Move NO_CONFIGCHECKS to Makefile.variables

2022-03-12 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava redhat/Makefile: Move NO_CONFIGCHECKS to Makefile.variables Move the NO_CONFIGCHECKS variable to Makefile.variables. Signed-off-by: Prarit Bhargava diff --git a/redhat/Makefile b/redhat/Makefile index blahblah..blahblah 100644 --- a/redhat/Makefile +++ b/redhat/Makefile

[OS-BUILD PATCHv2 11/24] redhat/Makefile: Move RHGIT* variables to Makefile.variables

2022-03-12 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava redhat/Makefile: Move RHGIT* variables to Makefile.variables Mmove the RHGITURL and RHGITCOMMIT variables to Makefile.variables. Signed-off-by: Prarit Bhargava diff --git a/redhat/Makefile b/redhat/Makefile index blahblah..blahblah 100644 --- a/redhat/Makefile +++

[OS-BUILD PATCHv2 8/24] redhat/Makefile: Move BUILD_FLAGS to Makefile.variables.

2022-03-12 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava redhat/Makefile: Move BUILD_FLAGS to Makefile.variables. Move BUILD_FLAGS to Makefile.variables. Signed-off-by: Prarit Bhargava diff --git a/redhat/Makefile b/redhat/Makefile index blahblah..blahblah 100644 --- a/redhat/Makefile +++ b/redhat/Makefile @@ -229,6 +229,16

[OS-BUILD PATCHv2 9/24] redhat/Makefile: Move BUILD to Makefile.variables

2022-03-12 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava redhat/Makefile: Move BUILD to Makefile.variables Move BUILD to Makefile.variables. Signed-off-by: Prarit Bhargava diff --git a/redhat/Makefile b/redhat/Makefile index blahblah..blahblah 100644 --- a/redhat/Makefile +++ b/redhat/Makefile @@ -101,7 +101,9 @@ endif

[OS-BUILD PATCHv2 10/24] redhat/Makefile: Move PREBUILD_GIT_ONLY to Makefile.variables

2022-03-12 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava redhat/Makefile: Move PREBUILD_GIT_ONLY to Makefile.variables Move PREBUILD_GIT_ONLY to Makefile.variables. Signed-off-by: Prarit Bhargava diff --git a/redhat/Makefile b/redhat/Makefile index blahblah..blahblah 100644 --- a/redhat/Makefile +++ b/redhat/Makefile @@

[OS-BUILD PATCHv2 6/24] redhat/Makefile: Move BUILD_TARGET and BUILD_SCRATCH_TARGET to Makefile.variables

2022-03-12 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava redhat/Makefile: Move BUILD_TARGET and BUILD_SCRATCH_TARGET to Makefile.variables Move BUILD_TARGET and BUILD_SCRATCH_TARGET to Makefile.variables. Signed-off-by: Prarit Bhargava diff --git a/redhat/Makefile b/redhat/Makefile index blahblah..blahblah 100644 ---

[OS-BUILD PATCHv2 5/24] redhat/Makefile: Remove RHPRODUCT variable

2022-03-12 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava redhat/Makefile: Remove RHPRODUCT variable The only use of RHPRODUCT is to set the RHDISTGIT_BRANCH variable. Remove the RHPRODUCT variable and just use RHDISTGIT_BRANCH. This will make future change easier. Signed-off-by: Prarit Bhargava diff --git a/redhat/Makefile

[OS-BUILD PATCHv2 7/24] redhat/Makefile: Move BUILD_PROFILE to Makefile.variables

2022-03-12 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava redhat/Makefile: Move BUILD_PROFILE to Makefile.variables Move BUILD_PROFILE to Makefile.variables. Signed-off-by: Prarit Bhargava diff --git a/redhat/Makefile b/redhat/Makefile index blahblah..blahblah 100644 --- a/redhat/Makefile +++ b/redhat/Makefile @@ -140,7 +140,9

[OS-BUILD PATCHv2 4/24] redhat/Makefile: Cleanup DISTRO variable

2022-03-12 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava redhat/Makefile: Cleanup DISTRO variable Move the DISTRO variable to Makefile.variables and clean up its usage in the Makfile. This creates separate fedora-specific, centos-specific, and 'other'-specific variable sections. Signed-off-by: Prarit Bhargava diff --git

[OS-BUILD PATCHv2 2/24] redhat: Combine Makefile and Makefile.common

2022-03-12 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava redhat: Combine Makefile and Makefile.common The only include of Makefile.common is the Makefile. Combine the two files in Makefile. Signed-off-by: Prarit Bhargava diff --git a/redhat/Makefile b/redhat/Makefile index blahblah..blahblah 100644 --- a/redhat/Makefile +++

[OS-BUILD PATCHv2 3/24] redhat/Makefile: Move HEAD to Makefile.variables.

2022-03-12 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava redhat/Makefile: Move HEAD to Makefile.variables. Move HEAD to Makefile.variables. Signed-off-by: Prarit Bhargava diff --git a/redhat/Makefile b/redhat/Makefile index blahblah..blahblah 100644 --- a/redhat/Makefile +++ b/redhat/Makefile @@ -9,7 +9,6 @@ RPMBUILD :=

[OS-BUILD PATCHv2 0/24] redhat/Makefile: Cleanup variables

2022-03-12 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava on gitlab.com Merge Request: https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1641 For a long time we have complained about disorganization in the redhat/Makefile. This was because the code was separated into several Makefiles (Makefile.cross, Makefile.rhpkg,

[OS-BUILD PATCHv2 1/24] redhat/koji/Makefile: Decouple koji Makefile from Makefile.common

2022-03-12 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava redhat/koji/Makefile: Decouple koji Makefile from Makefile.common The koji Makefile uses the GIT and PACKAGE_NAME variables which are currently defined in Makefile.common. Since these are configurable by a user they should actually be defined in Makefile.variables. Move

Re: [OS-BUILD PATCH 0/24] redhat/Makefile: Cleanup variables

2022-03-12 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1641#note_872561098 v2: DISTRO_BUILD must be evaluated after the VERSION_ON_UPSTREAM check as DISTRO_BUILD depends on PREBUILD. Move DISTRO_BUILD, KABI_TARBALL, and the KABIDW* variables after the

[OS-BUILD PATCH] redhat/Makefile: Silence dist-clean-configs output

2022-03-11 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava redhat/Makefile: Silence dist-clean-configs output Silence dist-clean-configs output. Signed-off-by: Prarit Bhargava diff --git a/redhat/Makefile b/redhat/Makefile index blahblah..blahblah 100644 --- a/redhat/Makefile +++ b/redhat/Makefile @@ -155,9 +155,7 @@

[OS-BUILD PATCH] redhat/configs: Disable watchdog components

2022-03-11 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava redhat/configs: Disable watchdog components These watchdog components are not necessary for RHEL9. CONFIG_IB700_WDT CONFIG_ALIM1535_WDT CONFIG_ALIM7101_WDT CONFIG_I6300ESB_WDT CONFIG_IT8712F_WDT CONFIG_IT87_WDT CONFIG_MACHZ_WDT CONFIG_PCIPCWATCHDOG CONFIG_SMSC_SCH311X_WDT

[OS-BUILD PATCH 24/24] redhat/Makefile: Reorganize variables

2022-03-11 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava redhat/Makefile: Reorganize variables Reorganize the variables from simple variables to complex variables. Signed-off-by: Prarit Bhargava diff --git a/redhat/Makefile b/redhat/Makefile index blahblah..blahblah 100644 --- a/redhat/Makefile +++ b/redhat/Makefile @@ -35,8

[OS-BUILD PATCH 23/24] redhat/Makefile: Add some descriptions

2022-03-11 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava redhat/Makefile: Add some descriptions Add some descriptive text about some of the Makefile sections. Signed-off-by: Prarit Bhargava diff --git a/redhat/Makefile b/redhat/Makefile index blahblah..blahblah 100644 --- a/redhat/Makefile +++ b/redhat/Makefile @@ -1,4 +1,8

[OS-BUILD PATCH 22/24] redhat/Makfile: Move SNAPSHOT check

2022-03-11 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava redhat/Makfile: Move SNAPSHOT check Move the SNAPSHOT check to the only place where it can actually be "1". Signed-off-by: Prarit Bhargava diff --git a/redhat/Makefile b/redhat/Makefile index blahblah..blahblah 100644 --- a/redhat/Makefile +++ b/redhat/Makefile @@

[OS-BUILD PATCH 20/24] redhat/genspec.sh: Rework RPMVERSION variable

2022-03-11 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava redhat/genspec.sh: Rework RPMVERSION variable The redhat/genspec.sh file contains $RPMVERSION and $RPM_VERSION variables which don't match the Makefile variables. Create a new KVERSION variable and replace $RPMVERSION with KVERSION, and $RPM_VERSION with $RPMVERSION.

[OS-BUILD PATCH 21/24] redhat/Makfile: Deprecate BREW_FLAGS, KOJI_FLAGS, and TEST_FLAGS

2022-03-11 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava redhat/Makfile: Deprecate BREW_FLAGS, KOJI_FLAGS, and TEST_FLAGS The BREW_FLAGS, KOJI_FLAGS, and TEST_FLAGS variables can be replaced with BUILD_FLAGS. Mark these three variables for later deprecation and warn users about their usage. Signed-off-by: Prarit Bhargava

[OS-BUILD PATCH 18/24] redhat/Makefile: Cleanup KABI* variables.

2022-03-11 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava redhat/Makefile: Cleanup KABI* variables. There is no need for both TARBALL and TARFILE variables. Cleanup the KABI* variables. Extra fix: Move KABIDW to the other KABI variables. Signed-off-by: Prarit Bhargava diff --git a/redhat/Makefile b/redhat/Makefile index

[OS-BUILD PATCH 19/24] redhat/Makefile: Remove dead comment

2022-03-11 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava redhat/Makefile: Remove dead comment This comment no longer applies and can be dropped. Signed-off-by: Prarit Bhargava diff --git a/redhat/Makefile b/redhat/Makefile index blahblah..blahblah 100644 --- a/redhat/Makefile +++ b/redhat/Makefile @@ -96,10 +96,6 @@ ifeq

[OS-BUILD PATCH 15/24] redhat/Makefile: Remove extra DIST_BRANCH

2022-03-11 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava redhat/Makefile: Remove extra DIST_BRANCH This is already declared in Makefile.variables. Signed-off-by: Prarit Bhargava diff --git a/redhat/Makefile b/redhat/Makefile index blahblah..blahblah 100644 --- a/redhat/Makefile +++ b/redhat/Makefile @@ -547,7 +547,6 @@

[OS-BUILD PATCH 17/24] redhat/Makefile.variables: Default RHGITCOMMIT to HEAD

2022-03-11 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava redhat/Makefile.variables: Default RHGITCOMMIT to HEAD RHGITCOMMIT is equal to HEAD. Rather than recalculating it, just set it to HEAD by default. Signed-off-by: Prarit Bhargava diff --git a/redhat/Makefile.variables b/redhat/Makefile.variables index blahblah..blahblah

[OS-BUILD PATCH 16/24] redhat/scripts/create-tarball.sh: Use Makefile TARBALL variable

2022-03-11 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava redhat/scripts/create-tarball.sh: Use Makefile TARBALL variable Use the Makefile TARBALL variable instead of passing it as an argument. Signed-off-by: Prarit Bhargava diff --git a/redhat/Makefile b/redhat/Makefile index blahblah..blahblah 100644 --- a/redhat/Makefile

[OS-BUILD PATCH 14/24] redhat/Makefile: Remove STAMP_VERSION

2022-03-11 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava redhat/Makefile: Remove STAMP_VERSION STAMP_VERSION can be replaced with KVERSION. Remove STAMP_VERSION. Signed-off-by: Prarit Bhargava diff --git a/redhat/Makefile b/redhat/Makefile index blahblah..blahblah 100644 --- a/redhat/Makefile +++ b/redhat/Makefile @@ -5,10

[OS-BUILD PATCH 13/24] redhat/Makefile: Move NO_CONFIGCHECKS to Makefile.variables

2022-03-11 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava redhat/Makefile: Move NO_CONFIGCHECKS to Makefile.variables Move the NO_CONFIGCHECKS variable to Makefile.variables. Signed-off-by: Prarit Bhargava diff --git a/redhat/Makefile b/redhat/Makefile index blahblah..blahblah 100644 --- a/redhat/Makefile +++ b/redhat/Makefile

[OS-BUILD PATCH 11/24] redhat/Makefile: Move RHGIT* variables to Makefile.variables

2022-03-11 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava redhat/Makefile: Move RHGIT* variables to Makefile.variables Mmove the RHGITURL and RHGITCOMMIT variables to Makefile.variables. Signed-off-by: Prarit Bhargava diff --git a/redhat/Makefile b/redhat/Makefile index blahblah..blahblah 100644 --- a/redhat/Makefile +++

[OS-BUILD PATCH 10/24] redhat/Makefile: Move PREBUILD_GIT_ONLY to Makefile.variables

2022-03-11 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava redhat/Makefile: Move PREBUILD_GIT_ONLY to Makefile.variables Move PREBUILD_GIT_ONLY to Makefile.variables. Signed-off-by: Prarit Bhargava diff --git a/redhat/Makefile b/redhat/Makefile index blahblah..blahblah 100644 --- a/redhat/Makefile +++ b/redhat/Makefile @@

[OS-BUILD PATCH 12/24] redhat/Makefile: Move RHJOBS to Makefile.variables

2022-03-11 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava redhat/Makefile: Move RHJOBS to Makefile.variables Move RHJOBS to Makefile.variables. Signed-off-by: Prarit Bhargava diff --git a/redhat/Makefile b/redhat/Makefile index blahblah..blahblah 100644 --- a/redhat/Makefile +++ b/redhat/Makefile @@ -222,13 +222,15 @@ KABIDW

[OS-BUILD PATCH 9/24] redhat/Makefile: Move BUILD to Makefile.variables

2022-03-11 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava redhat/Makefile: Move BUILD to Makefile.variables Move BUILD to Makefile.variables. Signed-off-by: Prarit Bhargava diff --git a/redhat/Makefile b/redhat/Makefile index blahblah..blahblah 100644 --- a/redhat/Makefile +++ b/redhat/Makefile @@ -101,7 +101,9 @@ endif

[OS-BUILD PATCH 5/24] redhat/Makefile: Remove RHPRODUCT variable

2022-03-11 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava redhat/Makefile: Remove RHPRODUCT variable The only use of RHPRODUCT is to set the RHDISTGIT_BRANCH variable. Remove the RHPRODUCT variable and just use RHDISTGIT_BRANCH. This will make future change easier. Signed-off-by: Prarit Bhargava diff --git a/redhat/Makefile

[OS-BUILD PATCH 8/24] redhat/Makefile: Move BUILD_FLAGS to Makefile.variables.

2022-03-11 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava redhat/Makefile: Move BUILD_FLAGS to Makefile.variables. Move BUILD_FLAGS to Makefile.variables. Signed-off-by: Prarit Bhargava diff --git a/redhat/Makefile b/redhat/Makefile index blahblah..blahblah 100644 --- a/redhat/Makefile +++ b/redhat/Makefile @@ -229,6 +229,16

[OS-BUILD PATCH 7/24] redhat/Makefile: Move BUILD_PROFILE to Makefile.variables

2022-03-11 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava redhat/Makefile: Move BUILD_PROFILE to Makefile.variables Move BUILD_PROFILE to Makefile.variables. Signed-off-by: Prarit Bhargava diff --git a/redhat/Makefile b/redhat/Makefile index blahblah..blahblah 100644 --- a/redhat/Makefile +++ b/redhat/Makefile @@ -140,7 +140,9

[OS-BUILD PATCH 6/24] redhat/Makefile: Move BUILD_TARGET and BUILD_SCRATCH_TARGET to Makefile.variables

2022-03-11 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava redhat/Makefile: Move BUILD_TARGET and BUILD_SCRATCH_TARGET to Makefile.variables Move BUILD_TARGET and BUILD_SCRATCH_TARGET to Makefile.variables. Signed-off-by: Prarit Bhargava diff --git a/redhat/Makefile b/redhat/Makefile index blahblah..blahblah 100644 ---

[OS-BUILD PATCH 4/24] redhat/Makefile: Cleanup DISTRO variable

2022-03-11 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava redhat/Makefile: Cleanup DISTRO variable Move the DISTRO variable to Makefile.variables and clean up its usage in the Makfile. This creates separate fedora-specific, centos-specific, and 'other'-specific variable sections. Signed-off-by: Prarit Bhargava diff --git

[OS-BUILD PATCH 2/24] redhat: Combine Makefile and Makefile.common

2022-03-11 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava redhat: Combine Makefile and Makefile.common The only include of Makefile.common is the Makefile. Combine the two files in Makefile. Signed-off-by: Prarit Bhargava diff --git a/redhat/Makefile b/redhat/Makefile index blahblah..blahblah 100644 --- a/redhat/Makefile +++

[OS-BUILD PATCH 1/24] redhat/koji/Makefile: Decouple koji Makefile from Makefile.common

2022-03-11 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava redhat/koji/Makefile: Decouple koji Makefile from Makefile.common The koji Makefile uses the GIT and PACKAGE_NAME variables which are currently defined in Makefile.common. Since these are configurable by a user they should actually be defined in Makefile.variables. Move

[OS-BUILD PATCH 3/24] redhat/Makefile: Move HEAD to Makefile.variables.

2022-03-11 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava redhat/Makefile: Move HEAD to Makefile.variables. Move HEAD to Makefile.variables. Signed-off-by: Prarit Bhargava diff --git a/redhat/Makefile b/redhat/Makefile index blahblah..blahblah 100644 --- a/redhat/Makefile +++ b/redhat/Makefile @@ -9,7 +9,6 @@ RPMBUILD :=

[OS-BUILD PATCH 0/24] redhat/Makefile: Cleanup variables

2022-03-11 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava on gitlab.com Merge Request: https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1641 For a long time we have complained about disorganization in the redhat/Makefile. This was because the code was separated into several Makefiles (Makefile.cross, Makefile.rhpkg,

Re: [OS-BUILD PATCHv7 0/9] process_configs.sh: Add parallel processing of configs in dist-configs

2022-03-08 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1635#note_867424818 @jmflinuxtx can you pull and try your sequence of commands again? ___ kernel mailing list -- kernel@lists.fedoraproject.org To

Re: [OS-BUILD PATCHv7 0/9] process_configs.sh: Add parallel processing of configs in dist-configs

2022-03-07 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1635#note_865862896 Good idea. I've added ``` The next line is throwaway code for transition to parallel processing. Leaving this line in place is harmless, but it can be removed the next time

[OS-BUILD PATCHv7 6/9] redhat/configs/build_configs.sh: Create unique output files

2022-03-07 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava redhat/configs/build_configs.sh: Create unique output files Create unique output files from merge_configs(). Signed-off-by: Prarit Bhargava diff --git a/redhat/configs/build_configs.sh b/redhat/configs/build_configs.sh index blahblah..blahblah 100755 ---

[OS-BUILD PATCHv7 7/9] redhat/configs/build_configs.sh: Provide better messages

2022-03-07 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava redhat/configs/build_configs.sh: Provide better messages Provide better error messages. Signed-off-by: Prarit Bhargava diff --git a/redhat/configs/build_configs.sh b/redhat/configs/build_configs.sh index blahblah..blahblah 100755 --- a/redhat/configs/build_configs.sh

[OS-BUILD PATCHv7 8/9] redhat/configs/build_configs.sh: Parallelize execution

2022-03-07 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava redhat/configs/build_configs.sh: Parallelize execution Parallelize the execution of each config building. The '+' adds job processing to 'non-make' commands [1]. [1] https://www.gnu.org/software/make/manual/html_node/Error-Messages.html Signed-off-by: Prarit Bhargava

[OS-BUILD PATCHv7 9/9] redhat/configs/process_configs.sh: Fix issue with old error files

2022-03-07 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava redhat/configs/process_configs.sh: Fix issue with old error files Previous to this changeset, running process_configs.sh would result in an .mismatches file being left after execution. If someone has done make dist-configs \# update to latest make -j10 dist-configs the

[OS-BUILD PATCHv7 4/9] redhat/configs/process_configs.sh: Parallelize execution

2022-03-07 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava redhat/configs/process_configs.sh: Parallelize execution Parallelize the execution of each config processing. The '+' adds job processing to 'non-make' commands [1]. [1] https://www.gnu.org/software/make/manual/html_node/Error-Messages.html Signed-off-by: Prarit

[OS-BUILD PATCHv7 5/9] redhat/configs/build_configs.sh: Add local variables

2022-03-07 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava redhat/configs/build_configs.sh: Add local variables Add local variables to the merge_configs function. This will make future changes for parallel processing easier. Signed-off-by: Prarit Bhargava diff --git a/redhat/configs/build_configs.sh

[OS-BUILD PATCHv7 3/9] redhat/configs/process_configs.sh: Provide better messages

2022-03-07 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava redhat/configs/process_configs.sh: Provide better messages Provide better error messages. Signed-off-by: Prarit Bhargava diff --git a/redhat/configs/process_configs.sh b/redhat/configs/process_configs.sh index blahblah..blahblah 100755 ---

[OS-BUILD PATCHv7 1/9] redhat/configs/process_configs.sh: Add processing config function

2022-03-07 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava redhat/configs/process_configs.sh: Add processing config function Move the code to process a config into its own function. This will make future changes easier. Signed-off-by: Prarit Bhargava diff --git a/redhat/configs/process_configs.sh

[OS-BUILD PATCHv7 2/9] redhat/configs/process_configs.sh: Create unique output files

2022-03-07 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava redhat/configs/process_configs.sh: Create unique output files Create unique output files from process_config(). Signed-off-by: Prarit Bhargava diff --git a/redhat/configs/process_configs.sh b/redhat/configs/process_configs.sh index blahblah..blahblah 100755 ---

[OS-BUILD PATCHv7 0/9] process_configs.sh: Add parallel processing of configs in dist-configs

2022-03-07 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava on gitlab.com Merge Request: https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1635 The dist-configs target takes an annoying long time. Add parallel processing of configs in dist-configs. Testing Info make dist-configs time 1m22.909s

Re: [OS-BUILD PATCHv6 0/2] redhat/genspec.sh: Remove options and use Makefile variables

2022-03-07 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1638#note_865814597 Fixed. ___ kernel mailing list -- kernel@lists.fedoraproject.org To unsubscribe send an email to kernel-le...@lists.fedoraproject.org

[OS-BUILD PATCHv6 2/2] redhat: Unify genspec.sh and kernel.spec variable names

2022-03-07 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava redhat: Unify genspec.sh and kernel.spec variable names Use common variable names between genspec.sh and kernel.spec. Signed-off-by: Prarit Bhargava diff --git a/redhat/genspec.sh b/redhat/genspec.sh index blahblah..blahblah 100755 --- a/redhat/genspec.sh +++

[OS-BUILD PATCHv6 0/2] redhat/genspec.sh: Remove options and use Makefile variables

2022-03-07 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava on gitlab.com Merge Request: https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1638 genspec.sh has _22_ parameters that must be specified on the command line which are generated by the Makefile. Instead of passing these parameters on the command line, export them

[OS-BUILD PATCHv6 1/2] redhat/genspec.sh: Remove options and use Makefile variables

2022-03-07 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava redhat/genspec.sh: Remove options and use Makefile variables genspec.sh has 22 parameters that must be specified on the command line which are generated by the Makefile. Instead of passing these parameters on the command line, export them directly from the Makefile.

Re: [OS-BUILD PATCHv6 0/9] process_configs.sh: Add parallel processing of configs in dist-configs

2022-03-07 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1635#note_865801544 It's hard to explain. The *ONLY* reason for the last commit is to avoid the issue @jmflinuxtx hit because he executed both the old code and the new code in the same tree. If you do

Re: [OS-BUILD PATCHv5 0/2] redhat/genspec.sh: Remove options and use Makefile variables

2022-03-07 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1638#note_865690949 I've updated the MR description. Fixed. ___ kernel mailing list -- kernel@lists.fedoraproject.org To unsubscribe send an email to

[OS-BUILD PATCHv5 2/2] redhat: Unify genspec.sh and kernel.spec variable names

2022-03-07 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava redhat: Unify genspec.sh and kernel.spec variable names Use common variable names between genspec.sh and kernel.spec. Signed-off-by: Prarit Bhargava diff --git a/redhat/genspec.sh b/redhat/genspec.sh index blahblah..blahblah 100755 --- a/redhat/genspec.sh +++

[OS-BUILD PATCHv5 0/2] redhat/genspec.sh: Remove options and use Makefile variables

2022-03-07 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava on gitlab.com Merge Request: https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1638 genspec.sh has _22_ parameters that must be specified on the command line which are generated by the Makefile. These parameters can be set in the script by using the output of the

[OS-BUILD PATCHv5 1/2] redhat/genspec.sh: Remove options and use Makefile variables

2022-03-07 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava redhat/genspec.sh: Remove options and use Makefile variables genspec.sh has _22_ parameters that must be specified on the command line which are generated by the Makefile. These parameters can be set in the script by using the output of the dist-dump-variables target

Re: [OS-BUILD PATCHv4 0/2] redhat/genspec.sh: Remove options and use Makefile variables

2022-03-07 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1638#note_865630233 Actually, just a -f "$SOURCES/$SPECFILE" will work here. If something is wrong we'll know it ;) ___ kernel mailing list --

Re: [OS-BUILD PATCHv4 0/2] redhat/genspec.sh: Remove options and use Makefile variables

2022-03-07 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1638#note_865625524 Yes, but the test itself needs to change to not only check for NULL but also check if the file exists. I will make that change now. ___

[OS-BUILD PATCHv6 6/9] redhat/configs/build_configs.sh: Create unique output files

2022-03-07 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava redhat/configs/build_configs.sh: Create unique output files Create unique output files from merge_configs(). Signed-off-by: Prarit Bhargava diff --git a/redhat/configs/build_configs.sh b/redhat/configs/build_configs.sh index blahblah..blahblah 100755 ---

[OS-BUILD PATCHv6 9/9] redhat/configs/process_configs.sh: Fix issue with old error files

2022-03-07 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava redhat/configs/process_configs.sh: Fix issue with old error files Previous to this changeset, running process_configs.sh would result in an .mismatches file being left after execution. If someone has done make dist-configs \# update to latest make -j10 dist-configs the

[OS-BUILD PATCHv6 8/9] redhat/configs/build_configs.sh: Parallelize execution

2022-03-07 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava redhat/configs/build_configs.sh: Parallelize execution Parallelize the execution of each config building. The '+' adds job processing to 'non-make' commands [1]. [1] https://www.gnu.org/software/make/manual/html_node/Error-Messages.html Signed-off-by: Prarit Bhargava

[OS-BUILD PATCHv6 7/9] redhat/configs/build_configs.sh: Provide better messages

2022-03-07 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava redhat/configs/build_configs.sh: Provide better messages Provide better error messages. Signed-off-by: Prarit Bhargava diff --git a/redhat/configs/build_configs.sh b/redhat/configs/build_configs.sh index blahblah..blahblah 100755 --- a/redhat/configs/build_configs.sh

[OS-BUILD PATCHv6 4/9] redhat/configs/process_configs.sh: Parallelize execution

2022-03-07 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava redhat/configs/process_configs.sh: Parallelize execution Parallelize the execution of each config processing. The '+' adds job processing to 'non-make' commands [1]. [1] https://www.gnu.org/software/make/manual/html_node/Error-Messages.html Signed-off-by: Prarit

[OS-BUILD PATCHv6 5/9] redhat/configs/build_configs.sh: Add local variables

2022-03-07 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava redhat/configs/build_configs.sh: Add local variables Add local variables to the merge_configs function. This will make future changes for parallel processing easier. Signed-off-by: Prarit Bhargava diff --git a/redhat/configs/build_configs.sh

[OS-BUILD PATCHv6 3/9] redhat/configs/process_configs.sh: Provide better messages

2022-03-07 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava redhat/configs/process_configs.sh: Provide better messages Provide better error messages. Signed-off-by: Prarit Bhargava diff --git a/redhat/configs/process_configs.sh b/redhat/configs/process_configs.sh index blahblah..blahblah 100755 ---

[OS-BUILD PATCHv6 2/9] redhat/configs/process_configs.sh: Create unique output files

2022-03-07 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava redhat/configs/process_configs.sh: Create unique output files Create unique output files from process_config(). Signed-off-by: Prarit Bhargava diff --git a/redhat/configs/process_configs.sh b/redhat/configs/process_configs.sh index blahblah..blahblah 100755 ---

[OS-BUILD PATCHv6 0/9] process_configs.sh: Add parallel processing of configs in dist-configs

2022-03-07 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava on gitlab.com Merge Request: https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1635 The dist-configs target takes an annoying long time. Add parallel processing of configs in dist-configs. Testing Info make dist-configs time 1m22.909s

<    8   9   10   11   12   13   14   15   16   >