[OS-BUILD PATCHv6 10/11] redhat/Makefile.rhpkg: Remove quotes for RHDISTGIT

2022-04-15 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava redhat/Makefile.rhpkg: Remove quotes for RHDISTGIT Remove the quotes around RHDISTGIT. This causes problems with the bash scripts in the dist-git-test target. Signed-off-by: Justin M. Forbes Signed-off-by: Prarit Bhargava diff --git a/redhat/Makefile.rhpkg

[OS-BUILD PATCHv6 8/11] redhat/scripts/create-tarball.sh: Use Makefile variables

2022-04-15 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava redhat/scripts/create-tarball.sh: Use Makefile variables Use Makefile variables in redhat/scripts/create-tarball.sh. Signed-off-by: Prarit Bhargava diff --git a/redhat/Makefile b/redhat/Makefile index blahblah..blahblah 100644 --- a/redhat/Makefile +++ b/redhat/Makefile

[OS-BUILD PATCHv6 3/11] redhat/configs/process_configs.sh: Use Makefile variables

2022-04-15 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava redhat/configs/process_configs.sh: Use Makefile variables Cleanup up parameters and use Makefile variables in process_config.sh. Signed-off-by: Prarit Bhargava diff --git a/redhat/Makefile b/redhat/Makefile index blahblah..blahblah 100644 --- a/redhat/Makefile +++

[OS-BUILD PATCHv6 6/11] redhat/Makefile: Use RPMVERSION

2022-04-15 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava redhat/Makefile: Use RPMVERSION Use RPMVERSION where appropriate in the Makefile. Signed-off-by: Prarit Bhargava diff --git a/redhat/Makefile b/redhat/Makefile index blahblah..blahblah 100644 --- a/redhat/Makefile +++ b/redhat/Makefile @@ -199,7 +199,7 @@

[OS-BUILD PATCHv6 5/11] redhat/scripts/rh-dist-git.sh: Use Makefile variables

2022-04-15 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava redhat/scripts/rh-dist-git.sh: Use Makefile variables Use Makefile variables in rh-dist-git.sh. Signed-off-by: Prarit Bhargava diff --git a/redhat/Makefile b/redhat/Makefile index blahblah..blahblah 100644 --- a/redhat/Makefile +++ b/redhat/Makefile @@ -637,7 +637,7 @@

[OS-BUILD PATCHv6 4/11] redhat/configs/build_configs.sh: Use Makefile variables

2022-04-15 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava redhat/configs/build_configs.sh: Use Makefile variables Use Makefile variables in build_configs.sh. Signed-off-by: Prarit Bhargava diff --git a/redhat/Makefile b/redhat/Makefile index blahblah..blahblah 100644 --- a/redhat/Makefile +++ b/redhat/Makefile @@ -363,8 +363,8

[OS-BUILD PATCHv6 2/11] redhat/kernel.spec.template: Use RPM_BUILD_NCPUS

2022-04-15 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava redhat/kernel.spec.template: Use RPM_BUILD_NCPUS RPM_BUILD_NCPUS allows users to modify the max number of cpus used by the RPM build. Use the RPM_BUILD_NCPUS variable in the spec file. Signed-off-by: Prarit Bhargava diff --git a/redhat/kernel.spec.template

[OS-BUILD PATCHv6 1/11] redhat/configs/generate_all_configs.sh: Use Makefile variables

2022-04-15 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava redhat/configs/generate_all_configs.sh: Use Makefile variables Use Makefile variables in generate_all_configs.sh. Signed-off-by: Prarit Bhargava diff --git a/redhat/Makefile b/redhat/Makefile index blahblah..blahblah 100644 --- a/redhat/Makefile +++ b/redhat/Makefile @@

[OS-BUILD PATCHv6 0/11] redhat: Use Makefile variables in scripts

2022-04-15 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava on gitlab.com Merge Request: https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1647 Use Makefile variables in scripts that are called from the Makefile. Signed-off-by: Prarit Bhargava --- redhat/configs/build_configs.sh | 18 ++---

Re: [OS-BUILD PATCHv5 0/11] redhat: Use Makefile variables in scripts

2022-04-14 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1647#note_913432212 Updated with new commit. ___ kernel mailing list -- kernel@lists.fedoraproject.org To unsubscribe send an email to

[OS-BUILD PATCHv5 9/11] redhat/self-test: Clean up data set

2022-04-14 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava redhat/self-test: Clean up data set After running 'make dist-self-test-data' it was noticed that there have been changes made to the kernel.spec file since the self-test data was introduced and a few more variables need to be changed for testing purposes. Clean up the

[OS-BUILD PATCHv5 11/11] redhat/Makefile: Deprecate SINGLE_TARBALL

2022-04-14 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava redhat/Makefile: Deprecate SINGLE_TARBALL jforbes points out that the removal of the SINGLE_TARBALL may affect some SIGs. Since the users of the variable are unknown and maybe zero, mark it as deprecated. This commit can be reverted if anyone requests it be kept in

[OS-BUILD PATCHv5 10/11] redhat/Makefile.rhpkg: Remove quotes for RHDISTGIT

2022-04-14 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava redhat/Makefile.rhpkg: Remove quotes for RHDISTGIT Remove the quotes around RHDISTGIT. This causes problems with the bash scripts in the dist-git-test target. Signed-off-by: Justin M. Forbes Signed-off-by: Prarit Bhargava diff --git a/redhat/Makefile.rhpkg

[OS-BUILD PATCHv5 4/11] redhat/configs/build_configs.sh: Use Makefile variables

2022-04-14 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava redhat/configs/build_configs.sh: Use Makefile variables Use Makefile variables in build_configs.sh. Signed-off-by: Prarit Bhargava diff --git a/redhat/Makefile b/redhat/Makefile index blahblah..blahblah 100644 --- a/redhat/Makefile +++ b/redhat/Makefile @@ -363,8 +363,8

[OS-BUILD PATCHv5 7/11] redhat/Makefile: Cleanup TARBALL target

2022-04-14 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava redhat/Makefile: Cleanup TARBALL target The TARBALL target can be cleaned up by using GITID everywhere. This results in no changes, so the SINGLE_TARBALL variable can be dropped. Additional fix: Use GITID directly in create-tarball.sh. GITID is already GITID_NORMALIZE

[OS-BUILD PATCHv5 8/11] redhat/scripts/create-tarball.sh: Use Makefile variables

2022-04-14 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava redhat/scripts/create-tarball.sh: Use Makefile variables Use Makefile variables in redhat/scripts/create-tarball.sh. Signed-off-by: Prarit Bhargava diff --git a/redhat/Makefile b/redhat/Makefile index blahblah..blahblah 100644 --- a/redhat/Makefile +++ b/redhat/Makefile

[OS-BUILD PATCHv5 5/11] redhat/scripts/rh-dist-git.sh: Use Makefile variables

2022-04-14 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava redhat/scripts/rh-dist-git.sh: Use Makefile variables Use Makefile variables in rh-dist-git.sh. Signed-off-by: Prarit Bhargava diff --git a/redhat/Makefile b/redhat/Makefile index blahblah..blahblah 100644 --- a/redhat/Makefile +++ b/redhat/Makefile @@ -637,7 +637,7 @@

[OS-BUILD PATCHv5 6/11] redhat/Makefile: Use RPMVERSION

2022-04-14 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava redhat/Makefile: Use RPMVERSION Use RPMVERSION where appropriate in the Makefile. Signed-off-by: Prarit Bhargava diff --git a/redhat/Makefile b/redhat/Makefile index blahblah..blahblah 100644 --- a/redhat/Makefile +++ b/redhat/Makefile @@ -199,7 +199,7 @@

[OS-BUILD PATCHv5 1/11] redhat/configs/generate_all_configs.sh: Use Makefile variables

2022-04-14 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava redhat/configs/generate_all_configs.sh: Use Makefile variables Use Makefile variables in generate_all_configs.sh. Signed-off-by: Prarit Bhargava diff --git a/redhat/Makefile b/redhat/Makefile index blahblah..blahblah 100644 --- a/redhat/Makefile +++ b/redhat/Makefile @@

[OS-BUILD PATCHv5 3/11] redhat/configs/process_configs.sh: Use Makefile variables

2022-04-14 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava redhat/configs/process_configs.sh: Use Makefile variables Cleanup up parameters and use Makefile variables in process_config.sh. Signed-off-by: Prarit Bhargava diff --git a/redhat/Makefile b/redhat/Makefile index blahblah..blahblah 100644 --- a/redhat/Makefile +++

[OS-BUILD PATCHv5 2/11] redhat/kernel.spec.template: Use RPM_BUILD_NCPUS

2022-04-14 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava redhat/kernel.spec.template: Use RPM_BUILD_NCPUS RPM_BUILD_NCPUS allows users to modify the max number of cpus used by the RPM build. Use the RPM_BUILD_NCPUS variable in the spec file. Signed-off-by: Prarit Bhargava diff --git a/redhat/kernel.spec.template

[OS-BUILD PATCHv5 0/11] redhat: Use Makefile variables in scripts

2022-04-14 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava on gitlab.com Merge Request: https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1647 Use Makefile variables in scripts that are called from the Makefile. Signed-off-by: Prarit Bhargava --- redhat/configs/build_configs.sh | 18 ++---

Re: [OS-BUILD PATCHv4 0/10] redhat: Use Makefile variables in scripts

2022-04-14 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1647#note_913421324 @jmflinuxtx, good point. I'm going to try something a bit wacky :smile: I can see you're a bit unsure about the variables usage and I don't have a good of determining if anyone is

Re: [OS-BUILD PATCHv4 0/10] redhat: Use Makefile variables in scripts

2022-04-14 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1647#note_913413991 Fixed. ___ kernel mailing list -- kernel@lists.fedoraproject.org To unsubscribe send an email to kernel-le...@lists.fedoraproject.org

Re: [OS-BUILD PATCHv4 0/10] redhat: Use Makefile variables in scripts

2022-04-14 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1647#note_913412572 Fixed. ___ kernel mailing list -- kernel@lists.fedoraproject.org To unsubscribe send an email to kernel-le...@lists.fedoraproject.org

Re: [OS-BUILD PATCHv4 0/10] redhat: Use Makefile variables in scripts

2022-04-14 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1647#note_913412488 Fixed. ___ kernel mailing list -- kernel@lists.fedoraproject.org To unsubscribe send an email to kernel-le...@lists.fedoraproject.org

Re: [OS-BUILD PATCHv4 0/10] redhat: Use Makefile variables in scripts

2022-04-14 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1647#note_913284820 Pushed v4 with changes from jforbes. ___ kernel mailing list -- kernel@lists.fedoraproject.org To unsubscribe send an email to

[OS-BUILD PATCHv4 9/10] redhat/self-test: Clean up data set

2022-04-14 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava redhat/self-test: Clean up data set After running 'make dist-self-test-data' it was noticed that there have been changes made to the kernel.spec file since the self-test data was introduced and a few more variables need to be changed for testing purposes. Clean up the

[OS-BUILD PATCHv4 10/10] redhat/Makefile.rhpkg: Remove quotes for RHDISTGIT

2022-04-14 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava redhat/Makefile.rhpkg: Remove quotes for RHDISTGIT Remove the quotes around RHDISTGIT. This causes problems with the bash scripts in the dist-git-test target. Signed-off-by: Justin M. Forbes Signed-off-by: Prarit Bhargava diff --git a/redhat/Makefile.rhpkg

[OS-BUILD PATCHv4 7/10] redhat/Makefile: Cleanup TARBALL target

2022-04-14 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava redhat/Makefile: Cleanup TARBALL target The TARBALL target can be cleaned up by using GITID everywhere. This results in no changes, so the SINGLE_TARBALL variable can be dropped. Additional fix: Use GITID directly in create-tarball.sh. GITID is already GITID_NORMALIZE

[OS-BUILD PATCHv4 8/10] redhat/scripts/create-tarball.sh: Use Makefile variables

2022-04-14 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava redhat/scripts/create-tarball.sh: Use Makefile variables Use Makefile variables is redhat/scripts/create-tarball.sh. Signed-off-by: Prarit Bhargava diff --git a/redhat/Makefile b/redhat/Makefile index blahblah..blahblah 100644 --- a/redhat/Makefile +++ b/redhat/Makefile

[OS-BUILD PATCHv4 6/10] redhat/Makefile: Use RPMVERSION

2022-04-14 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava redhat/Makefile: Use RPMVERSION Use RPMVERSION where appropriate in the Makefile. Signed-off-by: Prarit Bhargava diff --git a/redhat/Makefile b/redhat/Makefile index blahblah..blahblah 100644 --- a/redhat/Makefile +++ b/redhat/Makefile @@ -199,7 +199,7 @@

[OS-BUILD PATCHv4 5/10] redhat/scripts/rh-dist-git.sh: Use Makefile variables

2022-04-14 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava redhat/scripts/rh-dist-git.sh: Use Makefile variables Use Makefile variables in rh-dist-git.sh. Signed-off-by: Prarit Bhargava diff --git a/redhat/Makefile b/redhat/Makefile index blahblah..blahblah 100644 --- a/redhat/Makefile +++ b/redhat/Makefile @@ -637,7 +637,7 @@

[OS-BUILD PATCHv4 2/10] redhat/kernel.spec.template: Use RPM_BUILD_NCPUS

2022-04-14 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava redhat/kernel.spec.template: Use RPM_BUILD_NCPUS RPM_BUILD_NCPUS allows users to modify the max number of cpus used by the RPM build. Use the RPM_BUILD_NCPUS variable in the spec file. Signed-off-by: Prarit Bhargava diff --git a/redhat/kernel.spec.template

[OS-BUILD PATCHv4 3/10] redhat/configs/process_configs.sh: Use Makefile variables

2022-04-14 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava redhat/configs/process_configs.sh: Use Makefile variables Cleanup up parameters and use Makefile variables in process_config.sh. Signed-off-by: Prarit Bhargava diff --git a/redhat/Makefile b/redhat/Makefile index blahblah..blahblah 100644 --- a/redhat/Makefile +++

[OS-BUILD PATCHv4 4/10] redhat/configs/build_configs.sh: Use Makefile variables

2022-04-14 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava redhat/configs/build_configs.sh: Use Makefile variables Use Makefile variables in build_configs.sh. Signed-off-by: Prarit Bhargava diff --git a/redhat/Makefile b/redhat/Makefile index blahblah..blahblah 100644 --- a/redhat/Makefile +++ b/redhat/Makefile @@ -363,8 +363,8

[OS-BUILD PATCHv4 1/10] redhat/configs/generate_all_configs.sh: Use Makefile variables

2022-04-14 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava redhat/configs/generate_all_configs.sh: Use Makefile variables Use Makefile variables in generate_all_configs.sh. Signed-off-by: Prarit Bhargava diff --git a/redhat/Makefile b/redhat/Makefile index blahblah..blahblah 100644 --- a/redhat/Makefile +++ b/redhat/Makefile @@

[OS-BUILD PATCHv4 0/10] redhat: Use Makefile variables in scripts

2022-04-14 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava on gitlab.com Merge Request: https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1647 Use Makefile variables in scripts that are called from the Makefile. Signed-off-by: Prarit Bhargava --- redhat/configs/build_configs.sh | 18 ++---

[OS-BUILD PATCHv3 9/9] redhat/self-test: Clean up data set

2022-04-07 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava redhat/self-test: Clean up data set After running 'make dist-self-test-data' it was noticed that there have been changes made to the kernel.spec file since the self-test data was introduced and a few more variables need to be changed for testing purposes. Clean up the

[OS-BUILD PATCHv3 8/9] redhat/scripts/create-tarball.sh: Use Makefile variables

2022-04-07 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava redhat/scripts/create-tarball.sh: Use Makefile variables Use Makefile variables is redhat/scripts/create-tarball.sh. Signed-off-by: Prarit Bhargava diff --git a/redhat/Makefile b/redhat/Makefile index blahblah..blahblah 100644 --- a/redhat/Makefile +++ b/redhat/Makefile

[OS-BUILD PATCHv3 6/9] redhat/Makefile: Use RPMVERSION

2022-04-07 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava redhat/Makefile: Use RPMVERSION Use RPMVERSION where appropriate in the Makefile. Signed-off-by: Prarit Bhargava diff --git a/redhat/Makefile b/redhat/Makefile index blahblah..blahblah 100644 --- a/redhat/Makefile +++ b/redhat/Makefile @@ -199,7 +199,7 @@

[OS-BUILD PATCHv3 7/9] redhat/Makefile: Cleanup TARBALL target

2022-04-07 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava redhat/Makefile: Cleanup TARBALL target The TARBALL target can be cleaned up by using GITID everywhere. This results in no changes, so the SINGLE_TARBALL variable can be dropped. Additional fix: Use GITID directly in create-tarball.sh. GITID is already GITID_NORMALIZE

[OS-BUILD PATCHv3 5/9] redhat/scripts/rh-dist-git.sh: Use Makefile variables

2022-04-07 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava redhat/scripts/rh-dist-git.sh: Use Makefile variables Use Makefile variables in rh-dist-git.sh. Signed-off-by: Prarit Bhargava diff --git a/redhat/Makefile b/redhat/Makefile index blahblah..blahblah 100644 --- a/redhat/Makefile +++ b/redhat/Makefile @@ -637,7 +637,7 @@

[OS-BUILD PATCHv3 3/9] redhat/configs/process_configs.sh: Use Makefile variables

2022-04-07 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava redhat/configs/process_configs.sh: Use Makefile variables Cleanup up parameters and use Makefile variables in process_config.sh. Signed-off-by: Prarit Bhargava diff --git a/redhat/Makefile b/redhat/Makefile index blahblah..blahblah 100644 --- a/redhat/Makefile +++

[OS-BUILD PATCHv3 2/9] redhat/kernel.spec.template: Use RPM_BUILD_NCPUS

2022-04-07 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava redhat/kernel.spec.template: Use RPM_BUILD_NCPUS RPM_BUILD_NCPUS allows users to modify the max number of cpus used by the RPM build. Use the RPM_BUILD_NCPUS variable in the spec file. Signed-off-by: Prarit Bhargava diff --git a/redhat/kernel.spec.template

[OS-BUILD PATCHv3 4/9] redhat/configs/build_configs.sh: Use Makefile variables

2022-04-07 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava redhat/configs/build_configs.sh: Use Makefile variables Use Makefile variables in build_configs.sh. Signed-off-by: Prarit Bhargava diff --git a/redhat/Makefile b/redhat/Makefile index blahblah..blahblah 100644 --- a/redhat/Makefile +++ b/redhat/Makefile @@ -363,8 +363,8

[OS-BUILD PATCHv3 1/9] redhat/configs/generate_all_configs.sh: Use Makefile variables

2022-04-07 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava redhat/configs/generate_all_configs.sh: Use Makefile variables Use Makefile variables in generate_all_configs.sh. Signed-off-by: Prarit Bhargava diff --git a/redhat/Makefile b/redhat/Makefile index blahblah..blahblah 100644 --- a/redhat/Makefile +++ b/redhat/Makefile @@

[OS-BUILD PATCHv3 0/9] redhat: Use Makefile variables in scripts

2022-04-07 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava on gitlab.com Merge Request: https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1647 Use Makefile variables in scripts that are called from the Makefile. Signed-off-by: Prarit Bhargava --- redhat/configs/build_configs.sh | 18 ++---

Re: [OS-BUILD PATCHv2 0/8] redhat: Use Makefile variables in scripts

2022-04-07 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1647#note_905215318 @jwilsonrh @jmflinuxtx @ptalbert, reviews please. ___ kernel mailing list -- kernel@lists.fedoraproject.org To unsubscribe send an email

Re: [OS-BUILD PATCHv2] redhat: indicate HEAD state in tarball/rpm name

2022-04-06 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1735#note_903188503 This time on the right MR: @jwilsonrh, since this changes the Makefile variables and possibly the spec file, can you run 'make dist-self-test-data', confirm the changes, and commit

Re: [OS-BUILD PATCHv2] tools/power/x86/intel-speed-select: fix build failure when using -Wl,--as-needed

2022-04-06 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1721#note_903184315 @jwilsonrh, since this changes the Makefile variables and possibly the spec file, can you run 'make self-test-data', confirm the changes, and commit those changes as well?

[OS-BUILD PATCH] redhat/kernel.spec.template: Add intel_sdsi utility

2022-04-05 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava redhat/kernel.spec.template: Add intel_sdsi utility Add the intel_sdsi utility to the kernel-tools subpackage. Signed-off-by: Prarit Bhargava diff --git a/redhat/kernel.spec.template b/redhat/kernel.spec.template index blahblah..blahblah 100755 ---

Re: [OS-BUILD PATCH] redhat: indicate HEAD state in tarball/rpm name

2022-04-05 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1735#note_901549107 Oops. Sorry @jwilsonrh. We definitely could gate on $(DISTRO), but I'm curious if the $(PKGRELEASE) tag has any value at all for a tarball?

Re: [OS-BUILD PATCH] redhat: indicate HEAD state in tarball/rpm name

2022-04-05 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1735#note_901544580 "Perhaps we could make this a feature based on a flag in Makefile.variables? That way I could turn it off for Fedora." We could but does the $(PKGRELEASE) string really add any

[OS-BUILD PATCHv2] tools/power/x86/intel-speed-select: fix build failure when using -Wl,--as-needed

2022-04-05 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava tools/power/x86/intel-speed-select: fix build failure when using -Wl,--as-needed Upstream Status: https://www.spinics.net/lists/platform-driver-x86/msg31958.html Build of intel-speed-select will fail if you run: $ LDFLAGS="-Wl,--as-needed" /usr/bin/make V=1 ... gcc -O2

Re: [OS-BUILD PATCH] redhat/configs: enable Maxlinear GPY115/21x/24x driver

2022-04-05 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1738#note_901282523 Enable this only for aarch64 then, and possibly only for ARK. Fedora and the other arches don't need this. ___ kernel mailing list --

Re: [OS-BUILD PATCH] redhat: indicate HEAD state in tarball/rpm name

2022-04-05 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1735#note_901224348 The problem IIUC (@jmflinuxtx can confirm) is that this leads to multiple sources tarballs being uploaded into koji. ___ kernel mailing

Re: [OS-BUILD PATCH] redhat/configs: enable Maxlinear GPY115/21x/24x driver

2022-04-05 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1738#note_901077862 Why should this be enabled across all arches and OSes? ___ kernel mailing list -- kernel@lists.fedoraproject.org To unsubscribe send an

[OS-BUILD PATCHv2 2/8] redhat/kernel.spec.template: Use RPM_BUILD_NCPUS

2022-04-01 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava redhat/kernel.spec.template: Use RPM_BUILD_NCPUS RPM_BUILD_NCPUS allows users to modify the max number of cpus used by the RPM build. Use the RPM_BUILD_NCPUS variable in the spec file. Signed-off-by: Prarit Bhargava diff --git a/redhat/kernel.spec.template

[OS-BUILD PATCHv2 5/8] redhat/scripts/rh-dist-git.sh: Use Makefile variables

2022-04-01 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava redhat/scripts/rh-dist-git.sh: Use Makefile variables Use Makefile variables in rh-dist-git.sh. Signed-off-by: Prarit Bhargava diff --git a/redhat/Makefile b/redhat/Makefile index blahblah..blahblah 100644 --- a/redhat/Makefile +++ b/redhat/Makefile @@ -637,7 +637,7 @@

[OS-BUILD PATCHv2 7/8] redhat/Makefile: Cleanup TARBALL target

2022-04-01 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava redhat/Makefile: Cleanup TARBALL target The TARBALL target can be cleaned up by using GITID everywhere. This results in no changes, so the SINGLE_TARBALL variable can be dropped. Additional fix: Use GITID directly in create-tarball.sh. GITID is already GITID_NORMALIZE

[OS-BUILD PATCHv2 8/8] redhat/scripts/create-tarball.sh: Use Makefile variables

2022-04-01 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava redhat/scripts/create-tarball.sh: Use Makefile variables Use Makefile variables is redhat/scripts/create-tarball.sh. Signed-off-by: Prarit Bhargava diff --git a/redhat/Makefile b/redhat/Makefile index blahblah..blahblah 100644 --- a/redhat/Makefile +++ b/redhat/Makefile

[OS-BUILD PATCHv2 3/8] redhat/configs/process_configs.sh: Use Makefile variables

2022-04-01 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava redhat/configs/process_configs.sh: Use Makefile variables Cleanup up parameters and use Makefile variables in process_config.sh. Signed-off-by: Prarit Bhargava diff --git a/redhat/Makefile b/redhat/Makefile index blahblah..blahblah 100644 --- a/redhat/Makefile +++

[OS-BUILD PATCHv2 4/8] redhat/configs/build_configs.sh: Use Makefile variables

2022-04-01 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava redhat/configs/build_configs.sh: Use Makefile variables Use Makefile variables in build_configs.sh. Signed-off-by: Prarit Bhargava diff --git a/redhat/Makefile b/redhat/Makefile index blahblah..blahblah 100644 --- a/redhat/Makefile +++ b/redhat/Makefile @@ -363,8 +363,8

[OS-BUILD PATCHv2 0/8] redhat: Use Makefile variables in scripts

2022-04-01 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava on gitlab.com Merge Request: https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1647 Use Makefile variables in scripts that are called from the Makefile. Signed-off-by: Prarit Bhargava --- redhat/configs/build_configs.sh | 18 ++---

[OS-BUILD PATCHv2 1/8] redhat/configs/generate_all_configs.sh: Use Makefile variables

2022-04-01 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava redhat/configs/generate_all_configs.sh: Use Makefile variables Use Makefile variables in generate_all_configs.sh. Signed-off-by: Prarit Bhargava diff --git a/redhat/Makefile b/redhat/Makefile index blahblah..blahblah 100644 --- a/redhat/Makefile +++ b/redhat/Makefile @@

[OS-BUILD PATCHv2 6/8] redhat/Makefile: Use RPMVERSION

2022-04-01 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava redhat/Makefile: Use RPMVERSION Use RPMVERSION where appropriate in the Makefile. Signed-off-by: Prarit Bhargava diff --git a/redhat/Makefile b/redhat/Makefile index blahblah..blahblah 100644 --- a/redhat/Makefile +++ b/redhat/Makefile @@ -199,7 +199,7 @@

[OS-BUILD PATCHv6 16/16] redhat/scripts/create-tarball.sh: Use Makefile variables

2022-03-31 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava redhat/scripts/create-tarball.sh: Use Makefile variables Use Makefile variables is redhat/scripts/create-tarball.sh. Signed-off-by: Prarit Bhargava diff --git a/redhat/Makefile b/redhat/Makefile index blahblah..blahblah 100644 --- a/redhat/Makefile +++ b/redhat/Makefile

[OS-BUILD PATCHv6 15/16] redhat/Makefile: Cleanup TARBALL target

2022-03-31 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava redhat/Makefile: Cleanup TARBALL target The TARBALL target can be cleaned up by using GITID everywhere. This results in no changes, so the SINGLE_TARBALL variable can be dropped. Additional fix: Use GITID directly in create-tarball.sh. GITID is already GITID_NORMALIZE

[OS-BUILD PATCHv6 9/16] redhat/configs/generate_all_configs.sh: Use Makefile variables

2022-03-31 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava redhat/configs/generate_all_configs.sh: Use Makefile variables Use Makefile variables in generate_all_configs.sh. Signed-off-by: Prarit Bhargava diff --git a/redhat/Makefile b/redhat/Makefile index blahblah..blahblah 100644 --- a/redhat/Makefile +++ b/redhat/Makefile @@

[OS-BUILD PATCHv6 14/16] redhat/Makefile: Use RPMVERSION

2022-03-31 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava redhat/Makefile: Use RPMVERSION Use RPMVERSION where appropriate in the Makefile. Signed-off-by: Prarit Bhargava diff --git a/redhat/Makefile b/redhat/Makefile index blahblah..blahblah 100644 --- a/redhat/Makefile +++ b/redhat/Makefile @@ -199,7 +199,7 @@

[OS-BUILD PATCHv6 12/16] redhat/configs/build_configs.sh: Use Makefile variables

2022-03-31 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava redhat/configs/build_configs.sh: Use Makefile variables Use Makefile variables in build_configs.sh. Signed-off-by: Prarit Bhargava diff --git a/redhat/Makefile b/redhat/Makefile index blahblah..blahblah 100644 --- a/redhat/Makefile +++ b/redhat/Makefile @@ -363,8 +363,8

[OS-BUILD PATCHv6 6/16] redhat/Makefile.variables: Extend git hash length to 15

2022-03-31 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava redhat/Makefile.variables: Extend git hash length to 15 While testing the dist-self-test-data target, dzickus noticed that the git hash lengths were 13 and not 12 on his output. After discussion, and to avoid future problems, we have decided to default the hash length to

[OS-BUILD PATCHv6 11/16] redhat/configs/process_configs.sh: Use Makefile variables

2022-03-31 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava redhat/configs/process_configs.sh: Use Makefile variables Cleanup up parameters and use Makefile variables in process_config.sh. Signed-off-by: Prarit Bhargava diff --git a/redhat/Makefile b/redhat/Makefile index blahblah..blahblah 100644 --- a/redhat/Makefile +++

[OS-BUILD PATCHv6 13/16] redhat/scripts/rh-dist-git.sh: Use Makefile variables

2022-03-31 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava redhat/scripts/rh-dist-git.sh: Use Makefile variables Use Makefile variables in rh-dist-git.sh. Signed-off-by: Prarit Bhargava diff --git a/redhat/Makefile b/redhat/Makefile index blahblah..blahblah 100644 --- a/redhat/Makefile +++ b/redhat/Makefile @@ -637,7 +637,7 @@

[OS-BUILD PATCHv6 10/16] redhat/kernel.spec.template: Use RPM_BUILD_NCPUS

2022-03-31 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava redhat/kernel.spec.template: Use RPM_BUILD_NCPUS RPM_BUILD_NCPUS allows users to modify the max number of cpus used by the RPM build. Use the RPM_BUILD_NCPUS variable in the spec file. Signed-off-by: Prarit Bhargava diff --git a/redhat/kernel.spec.template

[OS-BUILD PATCHv6 1/16] redhat/self-test: Add variable test data

2022-03-31 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava redhat/self-test: Add variable test data Add test data for various release types, a script to create the data, and a Makefile target. This data will be used as a baseline for testing of Makefile changes. Note: By default, 'make self-test-data' outputs absolute paths.

[OS-BUILD PATCHv6 7/16] redhat/self-tests: Ignore RHGITURL

2022-03-31 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava redhat/self-tests: Ignore RHGITURL While testing, dzickus noticed that his RHGITURL was different from the RHGITURL in the default data. This is because RHGITURL is dependent on the user's local git configuration and therefore cannot be guaranteed to be unique across all

[OS-BUILD PATCHv6 8/16] redhat/self-tests: Ignore UPSTREAM

2022-03-31 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava redhat/self-tests: Ignore UPSTREAM While testing, dzickus noticed that his UPSTREAM was different from the UPSTREAM in the default data. This is because UPSTREAM is the base merge commit and will change as the repository is updated. Ignore UPSTREAM from the data set.

[OS-BUILD PATCHv6 5/16] redhat/self-test: Remove changelog from spec files

2022-03-31 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava redhat/self-test: Remove changelog from spec files Remove the changelog entries from spec files and replace it with a generic one line entry. We currently do not have changelog tests, and removing them at this time will make testing easier. Signed-off-by: Prarit Bhargava

[OS-BUILD PATCHv6 2/16] redhat/self-test: Add better dist-dump-variables test

2022-03-31 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava redhat/self-test: Add better dist-dump-variables test The current dist-dump-variables test is not adequate in that it only tests a small number of fields. Add a test to run create-data.sh and compare that data against the stored "known good" output in self-test/data.

[OS-BUILD PATCHv6 3/16] redhat/self-test: Add spec file data

2022-03-31 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava redhat/self-test: Add spec file data Add spec file examples for various release types and modify create-data.sh to create the data. This data will be used as a baseline for testing of Makefile changes. Signed-off-by: Prarit Bhargava diff --git

[OS-BUILD PATCHv6 4/16] redhat/genspec.sh: Rearrange genspec.sh

2022-03-31 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava redhat/genspec.sh: Rearrange genspec.sh genspec.sh takes a long time to run when executed to create test examples. The script does three things: creates a changelog, creates a patch file, and creates the specfile. Reorganize the code so that the specfile is created

[OS-BUILD PATCHv6 0/16] redhat/self-test: Add new tests

2022-03-31 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava on gitlab.com Merge Request: https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1706 Making changes to the Makefiles has been difficult and revealed minor issues with even the simplest of changes. Having a test that compares the Makefile variables to a "known good"

[OS-BUILD PATCH] redhat/kernel.spec.template: Fix intel-speed-select compile

2022-03-30 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava redhat/kernel.spec.template: Fix intel-speed-select compile The intel-speed-select utility needs the libnl3 library to compile. Signed-off-by: Prarit Bhargava diff --git a/redhat/kernel.spec.template b/redhat/kernel.spec.template index blahblah..blahblah 100755 ---

Re: [OS-BUILD PATCHv5 0/8] redhat/self-test: Add new tests

2022-03-29 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1706#note_893655753 Oops. Bad typo. Fixed. ___ kernel mailing list -- kernel@lists.fedoraproject.org To unsubscribe send an email to

[OS-BUILD PATCHv5 7/8] redhat/self-tests: Ignore RHGITURL

2022-03-29 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava redhat/self-tests: Ignore RHGITURL While testing, dzickus noticed that his RHGITURL was different from the RHGITURL in the default data. This is because RHGITURL is dependent on the user's local git configuration and therefore cannot be guaranteed to be unique across all

[OS-BUILD PATCHv5 8/8] redhat/self-tests: Ignore UPSTREAM

2022-03-29 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava redhat/self-tests: Ignore UPSTREAM While testing, dzickus noticed that his UPSTREAM was different from the UPSTREAM in the default data. This is because UPSTREAM is the base merge commit and will change as the repository is updated. Ignore UPSTREAM from the data set.

[OS-BUILD PATCHv5 6/8] redhat/Makefile.variables: Extend git hash length to 15

2022-03-29 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava redhat/Makefile.variables: Extend git hash length to 15 While testing the dist-self-test-data target, dzickus noticed that the git hash lengths were 13 and not 12 on his output. After discussion, and to avoid future problems, we have decided to default the hash length to

[OS-BUILD PATCHv5 4/8] redhat/genspec.sh: Rearrange genspec.sh

2022-03-29 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava redhat/genspec.sh: Rearrange genspec.sh genspec.sh takes a long time to run when executed to create test examples. The script does three things: creates a changelog, creates a patch file, and creates the specfile. Reorganize the code so that the specfile is created

[OS-BUILD PATCHv5 1/8] redhat/self-test: Add variable test data

2022-03-29 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava redhat/self-test: Add variable test data Add test data for various release types, a script to create the data, and a Makefile target. This data will be used as a baseline for testing of Makefile changes. Note: By default, 'make self-test-data' outputs absolute paths.

[OS-BUILD PATCHv5 0/8] redhat/self-test: Add new tests

2022-03-29 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava on gitlab.com Merge Request: https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1706 Making changes to the Makefiles has been difficult and revealed minor issues with even the simplest of changes. Having a test that compares the Makefile variables to a "known good"

[OS-BUILD PATCHv5 5/8] redhat/self-test: Remove changelog from spec files

2022-03-29 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava redhat/self-test: Remove changelog from spec files Remove the changelog entries from spec files and replace it with a generic one line entry. We currently do not have changelog tests, and removing them at this time will make testing easier. Signed-off-by: Prarit Bhargava

[OS-BUILD PATCHv5 3/8] redhat/self-test: Add spec file data

2022-03-29 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava redhat/self-test: Add spec file data Add spec file examples for various release types and modify create-data.sh to create the data. This data will be used as a baseline for testing of Makefile changes. Signed-off-by: Prarit Bhargava diff --git

[OS-BUILD PATCHv5 2/8] redhat/self-test: Add better dist-dump-variables test

2022-03-29 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava redhat/self-test: Add better dist-dump-variables test The current dist-dump-variables test is not adequate in that it only tests a small number of fields. Add a test to run create-data.sh and compare that data against the stored "known good" output in self-test/data.

Re: [OS-BUILD PATCHv4 0/8] redhat/self-test: Add new tests

2022-03-29 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1706#note_893244573 >privately sent log output with failures. My UPSTREAM var is different than the commits. Thanks. I cleaned up the shellcheck warning(s) in the commits, and then added a new commit

[OS-BUILD PATCHv4 1/8] redhat/self-test: Add variable test data

2022-03-29 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava redhat/self-test: Add variable test data Add test data for various release types, a script to create the data, and a Makefile target. This data will be used as a baseline for testing of Makefile changes. Note: By default, 'make self-test-data' outputs absolute paths.

[OS-BUILD PATCHv4 4/8] redhat/genspec.sh: Rearrange genspec.sh

2022-03-29 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava redhat/genspec.sh: Rearrange genspec.sh genspec.sh takes a long time to run when executed to create test examples. The script does three things: creates a changelog, creates a patch file, and creates the specfile. Reorganize the code so that the specfile is created

[OS-BUILD PATCHv4 8/8] redhat/self-tests: Ignore UPSTREAM

2022-03-29 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava redhat/self-tests: Ignore UPSTREAM While testing, dzickus noticed that his UPSTREAM was different from the UPSTREAM in the default data. This is because UPSTREAM is the base merge commit and will change as the repository is updated. Ignore UPSTREAM from the data set.

[OS-BUILD PATCHv4 6/8] redhat/Makefile.variables: Extend git hash length to 15

2022-03-29 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava redhat/Makefile.variables: Extend git hash length to 15 While testing the dist-self-test-data target, dzickus noticed that the git hash lengths were 13 and not 12 on his output. After discussion, and to avoid future problems, we have decided to default the hash length to

<    6   7   8   9   10   11   12   13   14   15   >