[OS-BUILD PATCHv4 3/8] redhat/self-test: Add spec file data

2022-03-29 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava redhat/self-test: Add spec file data Add spec file examples for various release types and modify create-data.sh to create the data. This data will be used as a baseline for testing of Makefile changes. Signed-off-by: Prarit Bhargava diff --git

[OS-BUILD PATCHv4 7/8] redhat/self-tests: Ignore RHGITURL

2022-03-29 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava redhat/self-tests: Ignore RHGITURL While testing, dzickus noticed that his RHGITURL was different from the RHGITURL in the default data. This is because RHGITURL is dependent on the user's local git configuration and therefore cannot be guaranteed to be unique across all

[OS-BUILD PATCHv4 2/8] redhat/self-test: Add better dist-dump-variables test

2022-03-29 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava redhat/self-test: Add better dist-dump-variables test The current dist-dump-variables test is not adequate in that it only tests a small number of fields. Add a test to run create-data.sh and compare that data against the stored "known good" output in self-test/data.

[OS-BUILD PATCHv4 5/8] redhat/self-test: Remove changelog from spec files

2022-03-29 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava redhat/self-test: Remove changelog from spec files Remove the changelog entries from spec files and replace it with a generic one line entry. We currently do not have changelog tests, and removing them at this time will make testing easier. Signed-off-by: Prarit Bhargava

[OS-BUILD PATCHv4 0/8] redhat/self-test: Add new tests

2022-03-29 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava on gitlab.com Merge Request: https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1706 Making changes to the Makefiles has been difficult and revealed minor issues with even the simplest of changes. Having a test that compares the Makefile variables to a "known good"

Re: [OS-BUILD PATCHv3 0/7] redhat/self-test: Add new tests

2022-03-29 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1706#note_892978755 >I like the spirit of the approach. On the surface things make sense and don't look to intrusive. Unfortunately, playing with your MR caused test failures. > >The biggest issues

[OS-BUILD PATCHv3 6/7] redhat/Makefile.variables: Extend git hash length to 15

2022-03-28 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava redhat/Makefile.variables: Extend git hash length to 15 While testing the dist-self-test-data target, dzickus noticed that the git hash lengths were 13 and not 12 on his output. After discussion, and to avoid future problems, we have decided to default the hash length to

[OS-BUILD PATCHv3 4/7] redhat/genspec.sh: Rearrange genspec.sh

2022-03-28 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava redhat/genspec.sh: Rearrange genspec.sh genspec.sh takes a long time to run when executed to create test examples. The script does three things: creates a changelog, creates a patch file, and creates the specfile. Reorganize the code so that the specfile is created

[OS-BUILD PATCHv3 7/7] redhat/self-tests: Ignore RHGITURL

2022-03-28 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava redhat/self-tests: Ignore RHGITURL While testing, dzickus noticed that his RHGITURL was different from the RHGITURL in the default data. This is because RHGITURL is dependent on the user's local git configuration and therefore cannot be guaranteed to be unique across all

[OS-BUILD PATCHv3 0/7] redhat/self-test: Add new tests

2022-03-28 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava on gitlab.com Merge Request: https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1706 Making changes to the Makefiles has been difficult and revealed minor issues with even the simplest of changes. Having a test that compares the Makefile variables to a "known good"

[OS-BUILD PATCHv3 1/7] redhat/self-test: Add variable test data

2022-03-28 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava redhat/self-test: Add variable test data Add test data for various release types, a script to create the data, and a Makefile target. This data will be used as a baseline for testing of Makefile changes. Note: By default, 'make self-test-data' outputs absolute paths.

[OS-BUILD PATCHv3 5/7] redhat/self-test: Remove changelog from spec files

2022-03-28 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava redhat/self-test: Remove changelog from spec files Remove the changelog entries from spec files and replace it with a generic one line entry. We currently do not have changelog tests, and removing them at this time will make testing easier. Signed-off-by: Prarit Bhargava

[OS-BUILD PATCHv3 2/7] redhat/self-test: Add better dist-dump-variables test

2022-03-28 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava redhat/self-test: Add better dist-dump-variables test The current dist-dump-variables test is not adequate in that it only tests a small number of fields. Add a test to run create-data.sh and compare that data against the stored "known good" output in self-test/data.

[OS-BUILD PATCHv3 3/7] redhat/self-test: Add spec file data

2022-03-28 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava redhat/self-test: Add spec file data Add spec file examples for various release types and modify create-data.sh to create the data. This data will be used as a baseline for testing of Makefile changes. Signed-off-by: Prarit Bhargava diff --git

[OS-BUILD PATCH 2/2] redhat/configs/process_configs.sh: Avoid race with find

2022-03-28 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava redhat/configs/process_configs.sh: Avoid race with find The find command interferes with other commands that get executed and results in errors like "find: './.tmp_6391763917': No such file or directory" being output during process_configs.sh. This can be avoided by only

[OS-BUILD PATCH 0/2] redhat/configs/process_configs.sh: Fix empty output error

2022-03-28 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava on gitlab.com Merge Request: https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1712 The CONTINUEONERROR code contained an 'exit 1' which brought the whole script to a halt when a config mismatch was detected. CONTINUEONERROR has no purpose in the parallel

[OS-BUILD PATCH 1/2] redhat/configs/process_configs.sh: Remove CONTINUEONERROR

2022-03-28 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava redhat/configs/process_configs.sh: Remove CONTINUEONERROR Back when process_configs.sh was serial, CONTINUEONERROR allowed the process_configs.sh script to continue to the next config even when there was a fatal error with the current analysis. This is no longer needed in

[OS-BUILD PATCHv2 1/5] redhat/self-test: Add variable test data

2022-03-28 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava redhat/self-test: Add variable test data Add test data for various release types, a script to create the data, and a Makefile target. This data will be used as a baseline for testing of Makefile changes. Note: By default, 'make self-test-data' outputs absolute paths.

Re: [OS-BUILD PATCHv2 0/5] redhat/self-test: Add new tests

2022-03-28 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1706#note_891772895 New version: Fixed comment about 5.16-rc5 + 2 commits ___ kernel mailing list -- kernel@lists.fedoraproject.org To unsubscribe send an

[OS-BUILD PATCHv2 0/5] redhat/self-test: Add new tests

2022-03-28 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava on gitlab.com Merge Request: https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1706 Making changes to the Makefiles has been difficult and revealed minor issues with even the simplest of changes. Having a test that compares the Makefile variables to a "known good"

[OS-BUILD PATCHv2 4/5] redhat/genspec.sh: Rearrange genspec.sh

2022-03-28 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava redhat/genspec.sh: Rearrange genspec.sh genspec.sh takes a long time to run when executed to create test examples. The script does three things: creates a changelog, creates a patch file, and creates the specfile. Reorganize the code so that the specfile is created

[OS-BUILD PATCHv2 5/5] redhat/self-test: Remove changelog from spec files

2022-03-28 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava redhat/self-test: Remove changelog from spec files Remove the changelog entries from spec files and replace it with a generic one line entry. We currently do not have changelog tests, and removing them at this time will make testing easier. Signed-off-by: Prarit Bhargava

[OS-BUILD PATCHv2 2/5] redhat/self-test: Add better dist-dump-variables test

2022-03-28 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava redhat/self-test: Add better dist-dump-variables test The current dist-dump-variables test is not adequate in that it only tests a small number of fields. Add a test to run create-data.sh and compare that data against the stored "known good" output in self-test/data.

[OS-BUILD PATCHv2 3/5] redhat/self-test: Add spec file data

2022-03-28 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava redhat/self-test: Add spec file data Add spec file examples for various release types and modify create-data.sh to create the data. This data will be used as a baseline for testing of Makefile changes. Signed-off-by: Prarit Bhargava diff --git

[OS-BUILD PATCHv2] redhat/configs: Set CONFIG_X86_AMD_PSTATE built-in on Fedora

2022-03-28 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava redhat/configs: Set CONFIG_X86_AMD_PSTATE built-in on Fedora In order to use the amd-pstate driver on AMD systems, users must first unload the acpi-cpufreq driver and then load the amd-pstate driver. Another option is to denylist the acpi-cpufreq driver but this also

[OS-BUILD PATCH 4/5] redhat/genspec.sh: Rearrange genspec.sh

2022-03-28 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava redhat/genspec.sh: Rearrange genspec.sh genspec.sh takes a long time to run when executed to create test examples. The script does three things: creates a changelog, creates a patch file, and creates the specfile. Reorganize the code so that the specfile is created

[OS-BUILD PATCH 3/5] redhat/self-test: Add spec file data

2022-03-28 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava redhat/self-test: Add spec file data Add spec file examples for various release types and modify create-data.sh to create the data. This data will be used as a baseline for testing of Makefile changes. Signed-off-by: Prarit Bhargava diff --git

[OS-BUILD PATCH 5/5] redhat/self-test: Remove changelog from spec files

2022-03-28 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava redhat/self-test: Remove changelog from spec files Remove the changelog entries from spec files and replace it with a generic one line entry. We currently do not have changelog tests, and removing them at this time will make testing easier. Signed-off-by: Prarit Bhargava

[OS-BUILD PATCH 1/5] redhat/self-test: Add variable test data

2022-03-28 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava redhat/self-test: Add variable test data Add test data for various release types, a script to create the data, and a Makefile target. This data will be used as a baseline for testing of Makefile changes. Note: By default, 'make self-test-data' outputs absolute paths.

[OS-BUILD PATCH 2/5] redhat/self-test: Add better dist-dump-variables test

2022-03-28 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava redhat/self-test: Add better dist-dump-variables test The current dist-dump-variables test is not adequate in that it only tests a small number of fields. Add a test to run create-data.sh and compare that data against the stored "known good" output in self-test/data.

[OS-BUILD PATCH 0/5] redhat/self-test: Add new tests

2022-03-28 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava on gitlab.com Merge Request: https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1706 Making changes to the Makefiles has been difficult and revealed minor issues with even the simplest of changes. Having a test that compares the Makefile variables to a "known good"

[OS-BUILD PATCH] redhat/configs: Set CONFIG_X86_AMD_PSTATE built-in on Fedora

2022-03-27 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava redhat/configs: Set CONFIG_X86_AMD_PSTATE built-in on Fedora In order to use the amd-pstate driver on AMD systems, users must first unload the acpi-cpufreq driver and then load the amd-pstate driver. Another option is to denylist the acpi-cpufreq driver but this also

Re: [OS-BUILD PATCH 0/7] redhat: Use Makefile variables in scripts

2022-03-25 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1647#note_889471767 Sorry everyone, I took this MR out of draft accidentally. I'm still working on it. Please ignore this version. ___ kernel mailing list

[OS-BUILD PATCH 4/7] redhat/scripts/rh-dist-git.sh: Use Makefile variables

2022-03-25 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava redhat/scripts/rh-dist-git.sh: Use Makefile variables Use Makefile variables in rh-dist-git.sh. Signed-off-by: Prarit Bhargava diff --git a/redhat/Makefile b/redhat/Makefile index blahblah..blahblah 100644 --- a/redhat/Makefile +++ b/redhat/Makefile @@ -625,7 +625,7 @@

[OS-BUILD PATCH 2/7] redhat/configs/process_configs.sh: Use Makefile variables

2022-03-25 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava redhat/configs/process_configs.sh: Use Makefile variables Cleanup up parameters and use Makefile variables in process_config.sh. Signed-off-by: Prarit Bhargava diff --git a/redhat/Makefile b/redhat/Makefile index blahblah..blahblah 100644 --- a/redhat/Makefile +++

[OS-BUILD PATCH 0/7] redhat: Use Makefile variables in scripts

2022-03-25 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava on gitlab.com Merge Request: https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1647 Use Makefile variables in scripts that are called from the Makefile. Signed-off-by: Prarit Bhargava --- redhat/configs/build_configs.sh| 18 +++--

[OS-BUILD PATCH 7/7] redhat/scripts/create-tarball.sh: Use Makefile variables

2022-03-25 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava redhat/scripts/create-tarball.sh: Use Makefile variables Use Makefile variables is redhat/scripts/create-tarball.sh. Signed-off-by: Prarit Bhargava diff --git a/redhat/Makefile b/redhat/Makefile index blahblah..blahblah 100644 --- a/redhat/Makefile +++ b/redhat/Makefile

[OS-BUILD PATCH 6/7] redhat/Makefile: Cleanup TARBALL target

2022-03-25 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava redhat/Makefile: Cleanup TARBALL target The TARBALL target can be cleaned up by setting GITID depending on the distro. As a result the SINGLE_TARBALL can be dropped. Signed-off-by: Prarit Bhargava diff --git a/redhat/Makefile b/redhat/Makefile index blahblah..blahblah

[OS-BUILD PATCH 5/7] redhat/Makefile: Use RPMVERSION

2022-03-25 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava redhat/Makefile: Use RPMVERSION Use RPMVERSION where appropriate in the Makefile. Signed-off-by: Prarit Bhargava diff --git a/redhat/Makefile b/redhat/Makefile index blahblah..blahblah 100644 --- a/redhat/Makefile +++ b/redhat/Makefile @@ -191,7 +191,7 @@

[OS-BUILD PATCH 3/7] redhat/configs/build_configs.sh: Use Makefile variables

2022-03-25 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava redhat/configs/build_configs.sh: Use Makefile variables Use Makefile variables in build_configs.sh. Signed-off-by: Prarit Bhargava diff --git a/redhat/Makefile b/redhat/Makefile index blahblah..blahblah 100644 --- a/redhat/Makefile +++ b/redhat/Makefile @@ -355,8 +355,8

[OS-BUILD PATCH 1/7] redhat/configs/generate_all_configs.sh: Use Makefile variables

2022-03-25 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava redhat/configs/generate_all_configs.sh: Use Makefile variables Use FLAVOR and change the behavior of the DEBUGBUILDSENABLED so that adding any parameter to the generate_all_configs.sh script results in no debug build config generation. Use Makefile variables in

[OS-BUILD PATCHv3] redhat/configs/process_configs.sh: Fix race with tools generation

2022-03-24 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava redhat/configs/process_configs.sh: Fix race with tools generation Kernel builds are occasionally failing with (for example): Processing /home/prarit/rpmbuild/BUILD/kernel-5.17/linux-5.17.0-0.test.fc35.x86_64/configs/kernel-5.17.0-s390x.config ... Processing

Re: [OS-BUILD PATCHv2] redhat/configs/process_configs.sh: Fix race with tools generation

2022-03-24 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1673#note_887624123 Yeah, there was clearly something wonky in the merge. Rebase seems to have fixed it. I've also tested it here in a centos-stream-9, which is a bit more robust with build

Re: [OS-BUILD PATCHv2] redhat/configs/process_configs.sh: Fix race with tools generation

2022-03-24 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1673#note_887571887 It failed in merge. I've rebased and repushed. ___ kernel mailing list -- kernel@lists.fedoraproject.org To unsubscribe send an email to

[OS-BUILD PATCHv2] redhat/configs/process_configs.sh: Fix race with tools generation

2022-03-24 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava redhat/configs/process_configs.sh: Fix race with tools generation Kernel builds are occasionally failing with (for example): Processing /home/prarit/rpmbuild/BUILD/kernel-5.17/linux-5.17.0-0.test.fc35.x86_64/configs/kernel-5.17.0-s390x.config ... Processing

Re: [OS-BUILD PATCHv2 0/5] redhat: Fix self-tests

2022-03-24 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1642#note_887486465 Maybe another way to state this is: At this time, my intention is only to fix the existing tests. Later commits will introduce new tests. Does that explain it? /me isn't sure if

Re: [OS-BUILD PATCHv2 0/5] redhat: Fix self-tests

2022-03-24 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1642#note_887483612 > Or are you just trying to fix up a test that you have no idea why it exists (because it may not be obvious)? :D LOL yes. I don't want to change anything until I get more commits

[OS-BUILD PATCH] redhat/configs/process_configs.sh: Fix race with tools generation

2022-03-24 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava redhat/configs/process_configs.sh: Fix race with tools generation Kernel builds are occasionally failing with (for example): Processing /home/prarit/rpmbuild/BUILD/kernel-5.17/linux-5.17.0-0.test.fc35.x86_64/configs/kernel-5.17.0-s390x.config ... Processing

[OS-BUILD PATCH] redhat/Makefile: Fix dist-git

2022-03-23 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava redhat/Makefile: Fix dist-git dist-git is failing to construct an SRPM on ark-latest with error: Bad file: /data/src/redhat/kernel-ark/redhat/rpm/SOURCES/kernel-kabi-dw-5.18.0-0.rc0.20220322git519129040766.4.tar.bz2: No such file or directory error: Bad file:

[OS-BUILD PATCHv2] RHMAINTAINERS: Update for Mar 18 2022

2022-03-22 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava RHMAINTAINERS: Update for Mar 18 2022 Update RHMAINTAINERS to latest. Signed-off-by: Prarit Bhargava diff --git a/redhat/rhdocs/MAINTAINERS/RHMAINTAINERS b/redhat/rhdocs/MAINTAINERS/RHMAINTAINERS index blahblah..blahblah 100644 ---

Re: [OS-BUILD PATCHv5 0/2] redhat: Add a Makefile README

2022-03-22 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1652#note_884053687 >Alright. The new push seems to be built on top of cki-project/kernel- ark!1642. Was that intentional? Whoops. My bad, I fat fingered that. I've pushed a new branch with only the

[OS-BUILD PATCHv5 2/2] redhat/README.Makefile: Add a Makefile README file

2022-03-22 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava redhat/README.Makefile: Add a Makefile README file Add a Makefile README file that explains the layout of the Makefiles, and the policies for modifying the Makefiles. Signed-off-by: Prarit Bhargava diff --git a/redhat/docs/index.rst b/redhat/docs/index.rst index

[OS-BUILD PATCHv5 1/2] redhat/Makefile: Remove duplicated code

2022-03-22 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava redhat/Makefile: Remove duplicated code This code was left in place when the variables were reorganized. It can be safely removed. Signed-off-by: Prarit Bhargava diff --git a/redhat/Makefile b/redhat/Makefile index blahblah..blahblah 100644 --- a/redhat/Makefile +++

[OS-BUILD PATCHv5 0/2] redhat: Add a Makefile README

2022-03-22 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava on gitlab.com Merge Request: https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1652 Add a MAkefile README that details what the redhat/Makefiles are and how they are to be modified. Signed-off-by: Prarit Bhargava --- redhat/docs/index.rst|

Re: [OS-BUILD PATCHv4 0/7] redhat: Add a Makefile README

2022-03-21 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1652#note_883064354 Thanks, I didn't know that was necessary. Fixed. ___ kernel mailing list -- kernel@lists.fedoraproject.org To unsubscribe send an email

[OS-BUILD PATCHv4 5/7] redhat: Fix release tagging

2022-03-21 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava redhat: Fix release tagging The release is tagged into the changelog and the git log. The changelog tags were missing the $(RPMKSUBLEVEL) variable which caused the self-tests to fail when manually run. Fix the release tagging so the same tag is in the git log and

[OS-BUILD PATCHv4 7/7] redhat/README.Makefile: Add a Makefile README file

2022-03-21 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava redhat/README.Makefile: Add a Makefile README file Add a Makefile README file that explains the layout of the Makefiles, and the policies for modifying the Makefiles. Signed-off-by: Prarit Bhargava diff --git a/redhat/docs/index.rst b/redhat/docs/index.rst index

[OS-BUILD PATCHv4 6/7] redhat/Makefile: Remove duplicated code

2022-03-21 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava redhat/Makefile: Remove duplicated code This code was left in place when the variables were reorganized. It can be safely removed. Signed-off-by: Prarit Bhargava diff --git a/redhat/Makefile b/redhat/Makefile index blahblah..blahblah 100644 --- a/redhat/Makefile +++

[OS-BUILD PATCHv4 3/7] redhat/self-test: Fix BUILD verification test

2022-03-21 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava redhat/self-test: Fix BUILD verification test This test fails because it assumes that the top commit will be a "[redhat]: kernel-version" commit. This is true for the main tree but isn't true for development branches. Change the test to look for the latest "[redhat]:

[OS-BUILD PATCHv4 2/7] redhat/self-test: Cleanup SRPM related self-tests

2022-03-21 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava redhat/self-test: Cleanup SRPM related self-tests The self-tests fail messily and loudly when a single SRPM is not present in the directory. Fix these tests to skip instead of loudly failing. [Aside: I could have added a call to dist-srpm in the dist-self-test target,

[OS-BUILD PATCHv4 4/7] redhat/self-test: Fix version tag test

2022-03-21 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava redhat/self-test: Fix version tag test The version tag test is using an incorrect changelog ID and doesn't look for the last '[redhat] kernel-*' commit. Fix both of these problems so the test runs correctly. Signed-off-by: Prarit Bhargava diff --git

[OS-BUILD PATCHv4 1/7] redhat/self-test: Fix shellcheck test

2022-03-21 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava redhat/self-test: Fix shellcheck test Fix shellcheck errors and the shellcheck test. Signed-off-by: Prarit Bhargava diff --git a/redhat/configs/build_configs.sh b/redhat/configs/build_configs.sh index blahblah..blahblah 100755 --- a/redhat/configs/build_configs.sh +++

[OS-BUILD PATCHv4 0/7] redhat: Add a Makefile README

2022-03-21 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava on gitlab.com Merge Request: https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1652 Add a MAkefile README that details what the redhat/Makefiles are and how they are to be modified. Signed-off-by: Prarit Bhargava --- redhat/configs/build_configs.sh

[OS-BUILD PATCHv2 1/5] redhat/self-test: Fix shellcheck test

2022-03-21 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava redhat/self-test: Fix shellcheck test Fix shellcheck errors and the shellcheck test. Signed-off-by: Prarit Bhargava diff --git a/redhat/configs/build_configs.sh b/redhat/configs/build_configs.sh index blahblah..blahblah 100755 --- a/redhat/configs/build_configs.sh +++

[OS-BUILD PATCHv2 3/5] redhat/self-test: Fix BUILD verification test

2022-03-21 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava redhat/self-test: Fix BUILD verification test This test fails because it assumes that the top commit will be a "[redhat]: kernel-version" commit. This is true for the main tree but isn't true for development branches. Change the test to look for the latest "[redhat]:

[OS-BUILD PATCHv2 4/5] redhat/self-test: Fix version tag test

2022-03-21 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava redhat/self-test: Fix version tag test The version tag test is using an incorrect changelog ID and doesn't look for the last '[redhat] kernel-*' commit. Fix both of these problems so the test runs correctly. Signed-off-by: Prarit Bhargava diff --git

[OS-BUILD PATCHv2 5/5] redhat: Fix release tagging

2022-03-21 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava redhat: Fix release tagging The release is tagged into the changelog and the git log. The changelog tags were missing the $(RPMKSUBLEVEL) variable which caused the self-tests to fail when manually run. Fix the release tagging so the same tag is in the git log and

[OS-BUILD PATCHv2 2/5] redhat/self-test: Cleanup SRPM related self-tests

2022-03-21 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava redhat/self-test: Cleanup SRPM related self-tests The self-tests fail messily and loudly when a single SRPM is not present in the directory. Fix these tests to skip instead of loudly failing. [Aside: I could have added a call to dist-srpm in the dist-self-test target,

[OS-BUILD PATCHv2 0/5] redhat: Fix self-tests

2022-03-21 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava on gitlab.com Merge Request: https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1642 Fix the tests in redhat/self-test. Signed-off-by: Prarit Bhargava --- redhat/configs/build_configs.sh | 42 ++ redhat/configs/process_configs.sh

[OS-BUILD PATCHv2] redhat/configs: Disable watchdog components

2022-03-21 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava redhat/configs: Disable watchdog components These watchdog components are not necessary for RHEL9. CONFIG_IB700_WDT CONFIG_ALIM1535_WDT CONFIG_ALIM7101_WDT CONFIG_I6300ESB_WDT CONFIG_IT8712F_WDT CONFIG_IT87_WDT CONFIG_MACHZ_WDT CONFIG_PCIPCWATCHDOG CONFIG_SMSC_SCH311X_WDT

[OS-BUILD PATCHv3 2/2] redhat/README.Makefile: Add a Makefile README file

2022-03-18 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava redhat/README.Makefile: Add a Makefile README file Add a Makefile README file that explains the layout of the Makefiles, and the policies for modifying the Makefiles. Signed-off-by: Prarit Bhargava diff --git a/redhat/docs/makefile-changes.rst

[OS-BUILD PATCHv3 0/2] redhat: Add a Makefile README

2022-03-18 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava on gitlab.com Merge Request: https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1652 Add a MAkefile README that details what the redhat/Makefiles are and how they are to be modified. Signed-off-by: Prarit Bhargava --- redhat/docs/makefile-changes.rst |

[OS-BUILD PATCHv3 1/2] redhat/Makefile: Remove duplicated code

2022-03-18 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava redhat/Makefile: Remove duplicated code This code was left in place when the variables were reorganized. It can be safely removed. Signed-off-by: Prarit Bhargava diff --git a/redhat/Makefile b/redhat/Makefile index blahblah..blahblah 100644 --- a/redhat/Makefile +++

[OS-BUILD PATCHv2 1/2] redhat/Makefile: Remove duplicated code

2022-03-18 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava redhat/Makefile: Remove duplicated code This code was left in place when the variables were reorganized. It can be safely removed. Signed-off-by: Prarit Bhargava diff --git a/redhat/Makefile b/redhat/Makefile index blahblah..blahblah 100644 --- a/redhat/Makefile +++

[OS-BUILD PATCHv2 2/2] redhat/README.Makefile: Add a Makefile README file

2022-03-18 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava redhat/README.Makefile: Add a Makefile README file Add a Makefile README file that explains the layout of the Makefiles, and the policies for modifying the Makefiles. Signed-off-by: Prarit Bhargava diff --git a/redhat/docs/makefile-changes.rst

[OS-BUILD PATCHv2 0/2] redhat: Add a Makefile README

2022-03-18 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava on gitlab.com Merge Request: https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1652 Add a MAkefile README that details what the redhat/Makefiles are and how they are to be modified. Signed-off-by: Prarit Bhargava --- redhat/docs/makefile-changes.rst |

[OS-BUILD PATCH 2/2] redhat/README.Makefile: Add a Makefile README file

2022-03-18 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava redhat/README.Makefile: Add a Makefile README file Add a Makefile README file that explains the layout of the Makefiles, and the policies for modifying the Makefiles. Signed-off-by: Prarit Bhargava diff --git a/redhat/README.Makefile b/redhat/README.Makefile new file

[OS-BUILD PATCH] RHMAINTAINERS: Update for Mar 18 2022

2022-03-18 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava RHMAINTAINERS: Update for Mar 18 2022 Update RHMAINTAINERS to latest. Signed-off-by: Prarit Bhargava diff --git a/redhat/rhdocs/MAINTAINERS/RHMAINTAINERS b/redhat/rhdocs/MAINTAINERS/RHMAINTAINERS index blahblah..blahblah 100644 ---

[OS-BUILD PATCH 0/2] redhat: Add a Makefile README

2022-03-18 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava on gitlab.com Merge Request: https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1652 Add a MAkefile README that details what the redhat/Makefiles are and how they are to be modified. Signed-off-by: Prarit Bhargava --- redhat/Makefile| 22

[OS-BUILD PATCH 1/2] redhat/Makefile: Remove duplicated code

2022-03-18 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava redhat/Makefile: Remove duplicated code This code was left in place when the variables were reorganized. It can be safely removed. Signed-off-by: Prarit Bhargava diff --git a/redhat/Makefile b/redhat/Makefile index blahblah..blahblah 100644 --- a/redhat/Makefile +++

[OS-BUILD PATCH 1/5] redhat/self-test: Fix shellcheck test

2022-03-18 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava redhat/self-test: Fix shellcheck test Fix shellcheck errors and the shellcheck test. Signed-off-by: Prarit Bhargava diff --git a/redhat/configs/build_configs.sh b/redhat/configs/build_configs.sh index blahblah..blahblah 100755 --- a/redhat/configs/build_configs.sh +++

[OS-BUILD PATCH 5/5] redhat: Fix release tagging

2022-03-18 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava redhat: Fix release tagging The release is tagged into the changelog and the git log. The changelog tags were missing the $(RPMKSUBLEVEL) variable which caused the self-tests to fail when manually run. Fix the release tagging so the same tag is in the git log and

[OS-BUILD PATCH 4/5] redhat/self-test: Fix version tag test

2022-03-18 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava redhat/self-test: Fix version tag test The version tag test is using an incorrect changelog ID and doesn't look for the last '[redhat] kernel-*' commit. Fix both of these problems so the test runs correctly. Signed-off-by: Prarit Bhargava diff --git

[OS-BUILD PATCH 2/5] redhat/self-test: Cleanup SRPM related self-tests

2022-03-18 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava redhat/self-test: Cleanup SRPM related self-tests The self-tests fail messily and loudly when a single SRPM is not present in the directory. Fix these tests to skip instead of loudly failing. [Aside: I could have added a call to dist-srpm in the dist-self-test target,

[OS-BUILD PATCH 0/5] redhat: Fix self-tests

2022-03-18 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava on gitlab.com Merge Request: https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1642 Fix the tests in redhat/self-test. Signed-off-by: Prarit Bhargava --- redhat/configs/build_configs.sh | 42 ++ redhat/configs/process_configs.sh

[OS-BUILD PATCH 3/5] redhat/self-test: Fix BUILD verification test

2022-03-18 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava redhat/self-test: Fix BUILD verification test This test fails because it assumes that the top commit will be a "[redhat]: kernel-version" commit. This is true for the main tree but isn't true for development branches. Change the test to look for the latest "[redhat]:

[OS-BUILD PATCHv3 24/24] redhat/Makefile: Reorganize variables

2022-03-12 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava redhat/Makefile: Reorganize variables Reorganize the variables from simple variables to complex variables. Signed-off-by: Prarit Bhargava diff --git a/redhat/Makefile b/redhat/Makefile index blahblah..blahblah 100644 --- a/redhat/Makefile +++ b/redhat/Makefile @@ -35,8

[OS-BUILD PATCHv3 23/24] redhat/Makefile: Add some descriptions

2022-03-12 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava redhat/Makefile: Add some descriptions Add some descriptive text about some of the Makefile sections. Signed-off-by: Prarit Bhargava diff --git a/redhat/Makefile b/redhat/Makefile index blahblah..blahblah 100644 --- a/redhat/Makefile +++ b/redhat/Makefile @@ -1,4 +1,8

[OS-BUILD PATCHv3 22/24] redhat/Makefile: Move SNAPSHOT check

2022-03-12 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava redhat/Makefile: Move SNAPSHOT check Move the SNAPSHOT check to the only place where it can actually be "1". Signed-off-by: Prarit Bhargava diff --git a/redhat/Makefile b/redhat/Makefile index blahblah..blahblah 100644 --- a/redhat/Makefile +++ b/redhat/Makefile @@

[OS-BUILD PATCHv3 21/24] redhat/Makefile: Deprecate BREW_FLAGS, KOJI_FLAGS, and TEST_FLAGS

2022-03-12 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava redhat/Makefile: Deprecate BREW_FLAGS, KOJI_FLAGS, and TEST_FLAGS The BREW_FLAGS, KOJI_FLAGS, and TEST_FLAGS variables can be replaced with BUILD_FLAGS. Mark these three variables for later deprecation and warn users about their usage. Signed-off-by: Prarit Bhargava

[OS-BUILD PATCHv3 20/24] redhat/genspec.sh: Rework RPMVERSION variable

2022-03-12 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava redhat/genspec.sh: Rework RPMVERSION variable The redhat/genspec.sh file contains $RPMVERSION and $RPM_VERSION variables which don't match the Makefile variables. Create a new KVERSION variable and replace $RPMVERSION with KVERSION, and $RPM_VERSION with $RPMVERSION.

[OS-BUILD PATCHv3 19/24] redhat/Makefile: Remove dead comment

2022-03-12 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava redhat/Makefile: Remove dead comment This comment no longer applies and can be dropped. Signed-off-by: Prarit Bhargava diff --git a/redhat/Makefile b/redhat/Makefile index blahblah..blahblah 100644 --- a/redhat/Makefile +++ b/redhat/Makefile @@ -96,10 +96,6 @@ ifeq

[OS-BUILD PATCHv3 15/24] redhat/Makefile: Remove extra DIST_BRANCH

2022-03-12 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava redhat/Makefile: Remove extra DIST_BRANCH This is already declared in Makefile.variables. Signed-off-by: Prarit Bhargava diff --git a/redhat/Makefile b/redhat/Makefile index blahblah..blahblah 100644 --- a/redhat/Makefile +++ b/redhat/Makefile @@ -547,7 +547,6 @@

[OS-BUILD PATCHv3 17/24] redhat/Makefile.variables: Default RHGITCOMMIT to HEAD

2022-03-12 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava redhat/Makefile.variables: Default RHGITCOMMIT to HEAD RHGITCOMMIT is equal to HEAD. Rather than recalculating it, just set it to HEAD by default. Signed-off-by: Prarit Bhargava diff --git a/redhat/Makefile.variables b/redhat/Makefile.variables index blahblah..blahblah

[OS-BUILD PATCHv3 18/24] redhat/Makefile: Cleanup KABI* variables.

2022-03-12 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava redhat/Makefile: Cleanup KABI* variables. There is no need for both TARBALL and TARFILE variables. Cleanup the KABI* variables. Extra fix: Move KABIDW to the other KABI variables. Signed-off-by: Prarit Bhargava diff --git a/redhat/Makefile b/redhat/Makefile index

[OS-BUILD PATCHv3 16/24] redhat/scripts/create-tarball.sh: Use Makefile TARBALL variable

2022-03-12 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava redhat/scripts/create-tarball.sh: Use Makefile TARBALL variable Use the Makefile TARBALL variable instead of passing it as an argument. Signed-off-by: Prarit Bhargava diff --git a/redhat/Makefile b/redhat/Makefile index blahblah..blahblah 100644 --- a/redhat/Makefile

[OS-BUILD PATCHv3 13/24] redhat/Makefile: Move NO_CONFIGCHECKS to Makefile.variables

2022-03-12 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava redhat/Makefile: Move NO_CONFIGCHECKS to Makefile.variables Move the NO_CONFIGCHECKS variable to Makefile.variables. Signed-off-by: Prarit Bhargava diff --git a/redhat/Makefile b/redhat/Makefile index blahblah..blahblah 100644 --- a/redhat/Makefile +++ b/redhat/Makefile

[OS-BUILD PATCHv3 14/24] redhat/Makefile: Remove STAMP_VERSION

2022-03-12 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava redhat/Makefile: Remove STAMP_VERSION STAMP_VERSION can be replaced with KVERSION. Remove STAMP_VERSION. Signed-off-by: Prarit Bhargava diff --git a/redhat/Makefile b/redhat/Makefile index blahblah..blahblah 100644 --- a/redhat/Makefile +++ b/redhat/Makefile @@ -5,10

[OS-BUILD PATCHv3 12/24] redhat/Makefile: Move RHJOBS to Makefile.variables

2022-03-12 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava redhat/Makefile: Move RHJOBS to Makefile.variables Move RHJOBS to Makefile.variables. Signed-off-by: Prarit Bhargava diff --git a/redhat/Makefile b/redhat/Makefile index blahblah..blahblah 100644 --- a/redhat/Makefile +++ b/redhat/Makefile @@ -222,13 +222,15 @@ KABIDW

[OS-BUILD PATCHv3 10/24] redhat/Makefile: Move PREBUILD_GIT_ONLY to Makefile.variables

2022-03-12 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava redhat/Makefile: Move PREBUILD_GIT_ONLY to Makefile.variables Move PREBUILD_GIT_ONLY to Makefile.variables. Signed-off-by: Prarit Bhargava diff --git a/redhat/Makefile b/redhat/Makefile index blahblah..blahblah 100644 --- a/redhat/Makefile +++ b/redhat/Makefile @@

<    7   8   9   10   11   12   13   14   15   16   >