From: Prarit Bhargava
redhat/docs: Add a description of kernel naming
Add a file that describes how kernel NVRs are constructed.
Signed-off-by: Prarit Bhargava
diff --git a/redhat/docs/index.rst b/redhat/docs/index.rst
index blahblah..blahblah 100644
--- a/redhat/docs/index.rst
+++
From: Prarit Bhargava
redhat/configs: Fix rm warning on error
When an unset config is found, process_configs.sh cleans up and returns an
error. In this case the .newconfigs file is not created and errors
like
rm: cannot remove '.newoptions18': No such file or directory
rm: cannot remove
From: Prarit Bhargava on gitlab.com
https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1757#note_945045363
>I quickly took a look at the state of things after this patchset and noticed
a few odd things I thought I mention; some or all of them are from before this
patchset, but with all
From: Prarit Bhargava
redhat/kernel.spec.template: Move genspec variables into one section
Move the genspec variables into one section. This re-introduces the
SPECKVERSION variable into the specfile.
Additional fix: add a tarfile_release variable that maps to
SPECTARFILE_RELEASE.
From: Prarit Bhargava
redhat/Makefile: Rename PREBUILD to UPSTREAMBUILD
PREBUILD isn't a good name for this variable. It is the portion of the
string that references upstream build information. Rename it to
UPSTREAMBUILD.
Signed-off-by: Prarit Bhargava
diff --git a/redhat/Makefile
From: Prarit Bhargava
self-test/data/create-data.sh: Avoid SINGLE_TARBALL warning
'make dist-self-test-data' outputs the warning "Makefile:25: WARNING:
SINGLE_TARBALL will be deprecated in a later release."
Unset the parameter before the make calls.
Signed-off-by: Prarit Bhargava
diff --git
From: Prarit Bhargava
redhat/Makefile: Fix dist-brew & distg-brew targets
The dist-brew and distg-brew targets always require some variable
manipulation on the command line. Hardcode DIST, DISTRO, and
SCRATCH_TARGET to always create a "RHEL9" brew build.
Signed-off-by: Prarit Bhargava
diff
From: Prarit Bhargava
redhat/scripts/new_release.sh: Use Makefile variables
Use Makefile variables in new_release.sh.
Signed-off-by: Prarit Bhargava
diff --git a/redhat/Makefile b/redhat/Makefile
index blahblah..blahblah 100644
--- a/redhat/Makefile
+++ b/redhat/Makefile
@@ -607,7 +607,7 @@
From: Prarit Bhargava
redhat/Makefile: Rename BUILDID to LOCALVERSION
BUILDID isn't a very descriptive name. Rename the variable to
LOCALVERSION.
Signed-off-by: Prarit Bhargava
diff --git a/redhat/Makefile b/redhat/Makefile
index blahblah..blahblah 100644
--- a/redhat/Makefile
+++
From: Prarit Bhargava
redhat/Makefile: Reorganize MARKER code
Reorganize the MARKER code. MARKER is always UPSTREAM_TARBALL_NAME
prefixed with a 'v'.
Signed-off-by: Prarit Bhargava
diff --git a/redhat/Makefile b/redhat/Makefile
index blahblah..blahblah 100644
--- a/redhat/Makefile
+++
From: Prarit Bhargava
redhat/Makefile: Rename __YSTREAM and __ZSTREAM
The __YSTREAM and __ZSTREAM names can be replaced with YSTREAM_FLAG and
ZSTREAM_FLAG. This makes future changes easier.
Signed-off-by: Prarit Bhargava
diff --git a/redhat/Makefile b/redhat/Makefile
index
From: Prarit Bhargava
redhat/genspec.sh: Add comment about SPECBUILDID variable
Add a comment about the non-obvious use of SPECBUILDID in
the specfile. Move the definition of SPECRELEASE to a
better location.
Signed-off-by: Prarit Bhargava
diff --git a/redhat/genspec.sh b/redhat/genspec.sh
From: Prarit Bhargava
redhat/kernel.spec.template: Remove kversion
Remove kversion. It is unused.
Signed-off-by: Prarit Bhargava
diff --git a/redhat/kernel.spec.template b/redhat/kernel.spec.template
index blahblah..blahblah 100755
--- a/redhat/kernel.spec.template
+++
From: Prarit Bhargava
redhat/Makefile: Add SPECTARFILE_RELEASE comment
Add comment about the SPECTARFILE_RELEASE variable.
Signed-off-by: Prarit Bhargava
diff --git a/redhat/Makefile b/redhat/Makefile
index blahblah..blahblah 100644
--- a/redhat/Makefile
+++ b/redhat/Makefile
@@ -246,11
From: Prarit Bhargava
redhat/Makefile: Move SPECRELEASE to genspec.sh
Move SPECRELEASE to genspec.sh. It is the only place it is used.
Signed-off-by: Prarit Bhargava
diff --git a/redhat/Makefile b/redhat/Makefile
index blahblah..blahblah 100644
--- a/redhat/Makefile
+++ b/redhat/Makefile
@@
From: Prarit Bhargava
redhat/Makefile: Rename RPMVERSION to BASEVERSION
RPMVERSION is the rpm NVR without the dist tag. It is not the RPM
version so RPMVERSION is not an accurate name for this field.
Rename RPMVERSION to BASEVERSION.
Signed-off-by: Prarit Bhargava
diff --git
From: Prarit Bhargava
redhat/Makefile: Add kernel-NVR comment
Add a comment explaining the variables used in constructing the kernel
package's NVR, and reorganize the variables.
Signed-off-by: Prarit Bhargava
diff --git a/redhat/Makefile b/redhat/Makefile
index blahblah..blahblah 100644
---
From: Prarit Bhargava
redhat/Makefile: Target whitespace cleanup
Some simple whitespace cleanups.
Signed-off-by: Prarit Bhargava
diff --git a/redhat/Makefile b/redhat/Makefile
index blahblah..blahblah 100644
--- a/redhat/Makefile
+++ b/redhat/Makefile
@@ -442,7 +442,6 @@ $(KABIDW_TARBALL):
From: Prarit Bhargava
redhat/Makefile: Use SPECFILE variable
Use the SPECFILE variable throughout the Makefiles.
Signed-off-by: Prarit Bhargava
diff --git a/redhat/Makefile b/redhat/Makefile
index blahblah..blahblah 100644
--- a/redhat/Makefile
+++ b/redhat/Makefile
@@ -548,7 +548,7 @@
From: Prarit Bhargava
redhat/Makefile: Remove KEXTRAVERSION
KEXTRAVERSION isn't used for anything and can be removed.
Signed-off-by: Prarit Bhargava
diff --git a/redhat/Makefile b/redhat/Makefile
index blahblah..blahblah 100644
--- a/redhat/Makefile
+++ b/redhat/Makefile
@@ -147,11 +147,9 @@
From: Prarit Bhargava on gitlab.com
Merge Request: https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1757
Depends: https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1728
This is a collection of various improvements and fixes for the redhat/Makefile
variables. These fixes
From: Prarit Bhargava on gitlab.com
https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1757#note_944835271
>- [3/17] `030f50682c27` ("redhat/Makefile: Add kernel-NVR comment")
>
> Is there any reason to make RELEASETAG variable a recursively expanded
variable instead of simply expanded
From: Prarit Bhargava
redhat/kernel.spec.template: Move genspec variables into one section
Move the genspec variables into one section.
Additional fix: add a tarfile_release variable that maps to
SPECTARFILE_RELEASE.
Signed-off-by: Prarit Bhargava
diff --git a/redhat/kernel.spec.template
From: Prarit Bhargava
redhat/Makefile: Rename PREBUILD to UPSTREAMBUILD
PREBUILD isn't a good name for this variable. It is the portion of the
string that references upstream build information. Rename it to
UPSTREAMBUILD.
Signed-off-by: Prarit Bhargava
diff --git a/redhat/Makefile
From: Prarit Bhargava
self-test/data/create-data.sh: Avoid SINGLE_TARBALL warning
'make dist-self-test-data' outputs the warning "Makefile:25: WARNING:
SINGLE_TARBALL will be deprecated in a later release."
Unset the parameter before the make calls.
Signed-off-by: Prarit Bhargava
diff --git
From: Prarit Bhargava
redhat/Makefile: Rename BUILDID to LOCALVERSION
BUILDID isn't a very descriptive name. Rename the variable to
LOCALVERSION.
Signed-off-by: Prarit Bhargava
diff --git a/redhat/Makefile b/redhat/Makefile
index blahblah..blahblah 100644
--- a/redhat/Makefile
+++
From: Prarit Bhargava
redhat/Makefile: Reorganize MARKER code
Reorganize the MARKER code. MARKER is always UPSTREAM_TARBALL_NAME
prefixed with a 'v'.
Signed-off-by: Prarit Bhargava
diff --git a/redhat/Makefile b/redhat/Makefile
index blahblah..blahblah 100644
--- a/redhat/Makefile
+++
From: Prarit Bhargava
redhat/Makefile: Rename __YSTREAM and __ZSTREAM
The __YSTREAM and __ZSTREAM names can be replaced with YSTREAM_FLAG and
ZSTREAM_FLAG. This makes future changes easier.
Signed-off-by: Prarit Bhargava
diff --git a/redhat/Makefile b/redhat/Makefile
index
From: Prarit Bhargava
redhat/genspec.sh: Remove SPECBUILDID
The buildid variable isn't used in the spec file. The variable
declaration and the SPECBUILDID variable can be safely removed.
Signed-off-by: Prarit Bhargava
diff --git a/redhat/genspec.sh b/redhat/genspec.sh
index
From: Prarit Bhargava
redhat/kernel.spec.template: Remove kversion
Remove kversion. It is unused.
Signed-off-by: Prarit Bhargava
diff --git a/redhat/kernel.spec.template b/redhat/kernel.spec.template
index blahblah..blahblah 100755
--- a/redhat/kernel.spec.template
+++
From: Prarit Bhargava
redhat/Makefile: Move SPECRELEASE to genspec.sh
Move SPECRELEASE to genspec.sh. It is the only place it is used.
Signed-off-by: Prarit Bhargava
diff --git a/redhat/Makefile b/redhat/Makefile
index blahblah..blahblah 100644
--- a/redhat/Makefile
+++ b/redhat/Makefile
@@
From: Prarit Bhargava
redhat/Makefile: Rename RPMVERSION to BASEVERSION
RPMVERSION is the rpm NVR without the dist tag. It is not the RPM
version so RPMVERSION is not an accurate name for this field.
Rename RPMVERSION to BASEVERSION.
Signed-off-by: Prarit Bhargava
diff --git
From: Prarit Bhargava
redhat/Makefile: General cleanup
Signed-off-by: Prarit Bhargava
diff --git a/redhat/Makefile b/redhat/Makefile
index blahblah..blahblah 100644
--- a/redhat/Makefile
+++ b/redhat/Makefile
@@ -246,11 +246,14 @@
From: Prarit Bhargava
redhat/Makefile: Target whitespace cleanup
Some simple whitespace cleanups.
Signed-off-by: Prarit Bhargava
diff --git a/redhat/Makefile b/redhat/Makefile
index blahblah..blahblah 100644
--- a/redhat/Makefile
+++ b/redhat/Makefile
@@ -442,7 +442,6 @@ $(KABIDW_TARBALL):
From: Prarit Bhargava
redhat/Makefile: Add kernel-NVR comment
Add a comment explaining the variables used in constructing the kernel
package's NVR, and reorganize the variables.
Signed-off-by: Prarit Bhargava
diff --git a/redhat/Makefile b/redhat/Makefile
index blahblah..blahblah 100644
---
From: Prarit Bhargava on gitlab.com
Merge Request: https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1757
Depends: https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1728
This is a collection of various improvements and fixes for the redhat/Makefile
variables. These fixes
From: Prarit Bhargava
redhat/Makefile: Use SPECFILE variable
Use the SPECFILE variable throughout the Makefiles.
Signed-off-by: Prarit Bhargava
diff --git a/redhat/Makefile b/redhat/Makefile
index blahblah..blahblah 100644
--- a/redhat/Makefile
+++ b/redhat/Makefile
@@ -548,7 +548,7 @@
From: Prarit Bhargava
redhat/Makefile: Remove KEXTRAVERSION
KEXTRAVERSION isn't used for anything and can be removed.
Signed-off-by: Prarit Bhargava
diff --git a/redhat/Makefile b/redhat/Makefile
index blahblah..blahblah 100644
--- a/redhat/Makefile
+++ b/redhat/Makefile
@@ -147,11 +147,9 @@
From: Prarit Bhargava
RHMAINTAINERS: Update for May 6 2022
Update RHMAINTAINERS to latest.
Signed-off-by: Prarit Bhargava
diff --git a/redhat/rhdocs/MAINTAINERS/RHMAINTAINERS
b/redhat/rhdocs/MAINTAINERS/RHMAINTAINERS
index blahblah..blahblah 100644
---
From: Prarit Bhargava
redhat/Makefile: Add RHTEST
For a long time we have wanted a mechanism by which we could do a 'test
run' of Makefile targets. Make has built-in options '-n, --just-print,
--dry-run, --recon' that can be added on the command line that allow users
to show the output for
From: Prarit Bhargava
redhat/self-test: Add test to verify Makefile declarations.
The Makefiles have been organized such that only Makefile.variables
contain external variables that can be set on the command line, and
the Makefile only contains variables that can set within the Makefile
itself.
From: Prarit Bhargava on gitlab.com
Merge Request: https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1728
Depends: https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1727
Add a test to verify Makefile declarations, and add the RHTEST variable.
The latter of these changes allows
From: Prarit Bhargava
redhat/self-test/data: Cleanup data
There have been some additional redhat/Makefile changes that modified
variables. Run 'make dist-self-test-data' to clean these changes up.
Signed-off-by: Prarit Bhargava
diff --git a/redhat/self-test/data/centos-2585cf9dfaad.el7
From: Prarit Bhargava
redhat/Makefile: Rename TARFILE_RELEASE to SPECTARFILE_RELEASE
Change TARFILE_RELEASE to SPECTARFILE_RELEASE so that readers
understand it is passed into the spec file.
Rename TARFILE_RELEASE to SPECTARFILE_RELEASE.
Signed-off-by: Prarit Bhargava
diff --git
From: Prarit Bhargava
redhat: shellcheck cleanup
Some shellcheck cleanups.
Signed-off-by: Prarit Bhargava
diff --git a/redhat/genspec.sh b/redhat/genspec.sh
index blahblah..blahblah 100755
--- a/redhat/genspec.sh
+++ b/redhat/genspec.sh
@@ -114,7 +114,7 @@ cdate="$(LC_ALL=C date +"%a %b %d
From: Prarit Bhargava
redhat/Makefile: Add 'duplicate' SPEC entries for user set variables
INCLUDE_FEDORA_FILES, INCLUDE_RHEL_FILES, and RELEASED_KERNEL are
specified in Makefile.variables as they can be set in userspace.
Create duplicate entries for these variables that begin with SPEC. This
From: Prarit Bhargava
redhat/self-test: Add test to verify SPEC variables
This test looks at the spec file variable replacement code in
redhat/genspec.sh and confirms that each variable begins with "SPEC".
Signed-off-by: Prarit Bhargava
diff --git a/redhat/docs/makefile-changes.rst
From: Prarit Bhargava
redhat/Makefile: Rename PKGRELEASE to SPECBUILD
PKGRELEASE is a confusing variable name, and it really is the BUILD string
for the specfile.
Rename PKGRELEASE to SPECBUILD.
Signed-off-by: Prarit Bhargava
diff --git a/redhat/Makefile b/redhat/Makefile
index
From: Prarit Bhargava
redhat/Makefile: Rename CHANGELOG to SPECCHANGELOG
Change CHANGELOG to SPECCHANGELOG so that readers understand it is passed
into the spec file. While the CHANGELOG does have use other than in the
spec file it is useful to know that the string is used in the spec file.
From: Prarit Bhargava
redhat/genspec: Rename PATCHLIST_CHANGELOG to SPECPATCHLIST_CHANGELOG
Change PATCHLIST_CHANGELOG to SPECPATCHLIST_CHANGELOG so that readers
understand it is passed into the spec file.
Rename PATCHLIST_CHANGELOG to SPECPATCHLIST_CHANGELOG.
Signed-off-by: Prarit Bhargava
From: Prarit Bhargava
redhat/genspec: Rename DEBUG_BUILDS_ENABLED to SPECDEBUG_BUILDS_ENABLED
Change DEBUG_BUILDS_ENABLED to SPECDEBUG_BUILDS_ENABLED so that readers
understand it is passed into the spec file.
Rename DEBUG_BUILDS_ENABLED to SPECDEBUG_BUILDS_ENABLED.
Signed-off-by: Prarit
From: Prarit Bhargava
redhat/genspec: Rename BUILDID_DEFINE to SPECBUILDID
Change BUILDID_DEFINE to SPECBUILDID so that readers understand it is passed
into the spec file.
Rename BUILDID_DEFINE to SPECBUILDID.
Signed-off-by: Prarit Bhargava
diff --git a/redhat/genspec.sh b/redhat/genspec.sh
From: Prarit Bhargava
redhat/Makefile: Rename RPMKEXTRAVERSION to SPECKEXTRAVERSION
Change RPMKEXTRAVERSION to SPECEXTRAVERSION so that readers understand it is
passed
into the spec file.
Rename RPMKEXTRAVERSION to SPECKEXTRAVERSION.
Signed-off-by: Prarit Bhargava
diff --git
From: Prarit Bhargava
redhat/Makefile: Rename RPMKPATCHLEVEL to SPECKPATCHLEVEL
Change RPMKPATCHLEVEL to SPECPATCHLEVEL so that readers understand it is passed
into the spec file.
Rename RPMKPATCHLEVEL to SPECKPATCHLEVEL.
Signed-off-by: Prarit Bhargava
diff --git a/redhat/Makefile
From: Prarit Bhargava
redhat/Makefile: Rename KVERSION to SPECVERSION
KVERSION is passed into the spec file and is easy to confuse with the
kernel KVERSION. Change the name to SPECVERSION so that readers
understand it is the %Version field of the specfile.
As a result RPMKSUBLEVEL can be
From: Prarit Bhargava
redhat/Makefile: Rename RPMKSUBLEVEL to SPECKSUBLEVEL
Change RPMKSUBLEVEL to SPECSUBLEVEL so that readers understand it is passed
into the spec file.
Rename RPMKSUBLEVEL to SPECKSUBLEVEL.
Signed-off-by: Prarit Bhargava
diff --git a/redhat/Makefile b/redhat/Makefile
From: Prarit Bhargava
redhat/Makefile: Rename RPMKVERSION to SPECKVERSION
Change RPMKVERSION to SPECVERSION so that readers understand it is passed
into the spec file.
Rename RPMKVERSION to SPECKVERSION.
Signed-off-by: Prarit Bhargava
diff --git a/redhat/Makefile b/redhat/Makefile
index
From: Prarit Bhargava
redhat/Makefile: Deprecate some simple targets
Deprecate some simple targets.
Signed-off-by: Prarit Bhargava
diff --git a/redhat/Makefile b/redhat/Makefile
index blahblah..blahblah 100644
--- a/redhat/Makefile
+++ b/redhat/Makefile
@@ -420,15 +420,23 @@
From: Prarit Bhargava
redhat/Makefile: Use KVERSION
Use KVERSION where appropriate in the Makefile.
Signed-off-by: Prarit Bhargava
diff --git a/redhat/Makefile b/redhat/Makefile
index blahblah..blahblah 100644
--- a/redhat/Makefile
+++ b/redhat/Makefile
@@ -144,6 +144,9 @@ else
From: Prarit Bhargava on gitlab.com
Merge Request: https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1727
Depends: https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1647
One of the common complaints about the redhat Makefiles, genspec.sh, and
kernel.spec.template is that it is
From: Prarit Bhargava
redhat/genspec: Rename DEBUG_BUILDS_ENABLED to SPECDEBUG_BUILDS_ENABLED
Change DEBUG_BUILDS_ENABLED to SPECDEBUG_BUILDS_ENABLED so that readers
understand it is passed into the spec file.
Rename DEBUG_BUILDS_ENABLED to SPECDEBUG_BUILDS_ENABLED.
Signed-off-by: Prarit
From: Prarit Bhargava
redhat/Makefile: Rename KVERSION to SPECVERSION
KVERSION is passed into the spec file and is easy to confuse with the
kernel KVERSION. Change the name to SPECVERSION so that readers
understand it is the %Version field of the specfile.
As a result RPMKSUBLEVEL can be
From: Prarit Bhargava
redhat/Makefile: Rename PKGRELEASE to SPECBUILD
PKGRELEASE is a confusing variable name, and it really is the BUILD string
for the specfile.
Rename PKGRELEASE to SPECBUILD.
Signed-off-by: Prarit Bhargava
diff --git a/redhat/Makefile b/redhat/Makefile
index
From: Prarit Bhargava
redhat/Makefile: Rename CHANGELOG to SPECCHANGELOG
Change CHANGELOG to SPECCHANGELOG so that readers understand it is passed
into the spec file. While the CHANGELOG does have use other than in the
spec file it is useful to know that the string is used in the spec file.
From: Prarit Bhargava
redhat/genspec: Rename BUILDID_DEFINE to SPECBUILDID
Change BUILDID_DEFINE to SPECBUILDID so that readers understand it is passed
into the spec file.
Rename BUILDID_DEFINE to SPECBUILDID.
Signed-off-by: Prarit Bhargava
diff --git a/redhat/genspec.sh b/redhat/genspec.sh
From: Prarit Bhargava
redhat/Makefile: Rename RPMKEXTRAVERSION to SPECKEXTRAVERSION
Change RPMKEXTRAVERSION to SPECEXTRAVERSION so that readers understand it is
passed
into the spec file.
Rename RPMKEXTRAVERSION to SPECKEXTRAVERSION.
Signed-off-by: Prarit Bhargava
diff --git
From: Prarit Bhargava
redhat/Makefile: Rename RPMKSUBLEVEL to SPECKSUBLEVEL
Change RPMKSUBLEVEL to SPECSUBLEVEL so that readers understand it is passed
into the spec file.
Rename RPMKSUBLEVEL to SPECKSUBLEVEL.
Signed-off-by: Prarit Bhargava
diff --git a/redhat/Makefile b/redhat/Makefile
From: Prarit Bhargava
redhat/Makefile: Rename RPMKPATCHLEVEL to SPECKPATCHLEVEL
Change RPMKPATCHLEVEL to SPECPATCHLEVEL so that readers understand it is passed
into the spec file.
Rename RPMKPATCHLEVEL to SPECKPATCHLEVEL.
Signed-off-by: Prarit Bhargava
diff --git a/redhat/Makefile
From: Prarit Bhargava on gitlab.com
Merge Request: https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1727
Depends: https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1647
One of the common complaints about the redhat Makefiles, genspec.sh, and
kernel.spec.template is that it is
From: Prarit Bhargava
redhat/Makefile: Rename RPMKVERSION to SPECKVERSION
Change RPMKVERSION to SPECVERSION so that readers understand it is passed
into the spec file.
Rename RPMKVERSION to SPECKVERSION.
Signed-off-by: Prarit Bhargava
diff --git a/redhat/Makefile b/redhat/Makefile
index
From: Prarit Bhargava
redhat/Makefile: Deprecate some simple targets
Deprecate some simple targets.
Signed-off-by: Prarit Bhargava
diff --git a/redhat/Makefile b/redhat/Makefile
index blahblah..blahblah 100644
--- a/redhat/Makefile
+++ b/redhat/Makefile
@@ -420,15 +420,23 @@
From: Prarit Bhargava
redhat/Makefile: Use KVERSION
Use KVERSION where appropriate in the Makefile.
Signed-off-by: Prarit Bhargava
diff --git a/redhat/Makefile b/redhat/Makefile
index blahblah..blahblah 100644
--- a/redhat/Makefile
+++ b/redhat/Makefile
@@ -144,6 +144,9 @@ else
From: Prarit Bhargava on gitlab.com
https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1727#note_936452973
Oops. I forgot to commit those. Added now and fixed.
___
kernel mailing list -- kernel@lists.fedoraproject.org
To unsubscribe send an
From: Prarit Bhargava
redhat/Makefile: Rename TARFILE_RELEASE to SPECTARFILE_RELEASE
Change TARFILE_RELEASE to SPECTARFILE_RELEASE so that readers
understand it is passed into the spec file.
Rename TARFILE_RELEASE to SPECTARFILE_RELEASE.
Signed-off-by: Prarit Bhargava
diff --git
From: Prarit Bhargava
redhat/self-test/data: Cleanup data
There have been some additional redhat/Makefile changes that modified
variables. Run 'make dist-self-test-data' to clean these changes up.
Signed-off-by: Prarit Bhargava
diff --git a/redhat/self-test/data/centos-2585cf9dfaad.el7
From: Prarit Bhargava
redhat: shellcheck cleanup
Some shellcheck cleanups.
Signed-off-by: Prarit Bhargava
diff --git a/redhat/genspec.sh b/redhat/genspec.sh
index blahblah..blahblah 100755
--- a/redhat/genspec.sh
+++ b/redhat/genspec.sh
@@ -114,7 +114,7 @@ cdate="$(LC_ALL=C date +"%a %b %d
From: Prarit Bhargava
redhat/self-test: Add test to verify SPEC variables
This test looks at the spec file variable replacement code in
redhat/genspec.sh and confirms that each variable begins with "SPEC".
Signed-off-by: Prarit Bhargava
diff --git a/redhat/docs/makefile-changes.rst
From: Prarit Bhargava
redhat/Makefile: Add 'duplicate' SPEC entries for user set variables
INCLUDE_FEDORA_FILES, INCLUDE_RHEL_FILES, and RELEASED_KERNEL are
specified in Makefile.variables as they can be set in userspace.
Create duplicate entries for these variables that begin with SPEC. This
From: Prarit Bhargava
redhat/genspec: Rename DEBUG_BUILDS_ENABLED to SPECDEBUG_BUILDS_ENABLED
Change DEBUG_BUILDS_ENABLED to SPECDEBUG_BUILDS_ENABLED so that readers
understand it is passed into the spec file.
Rename DEBUG_BUILDS_ENABLED to SPECDEBUG_BUILDS_ENABLED.
Signed-off-by: Prarit
From: Prarit Bhargava
redhat/Makefile: Rename RPMKEXTRAVERSION to SPECKEXTRAVERSION
Change RPMKEXTRAVERSION to SPECEXTRAVERSION so that readers understand it is
passed
into the spec file.
Rename RPMKEXTRAVERSION to SPECKEXTRAVERSION.
Signed-off-by: Prarit Bhargava
diff --git
From: Prarit Bhargava
redhat/genspec: Rename PATCHLIST_CHANGELOG to SPECPATCHLIST_CHANGELOG
Change PATCHLIST_CHANGELOG to SPECPATCHLIST_CHANGELOG so that readers
understand it is passed into the spec file.
Rename PATCHLIST_CHANGELOG to SPECPATCHLIST_CHANGELOG.
Signed-off-by: Prarit Bhargava
From: Prarit Bhargava
redhat/Makefile: Rename PKGRELEASE to SPECBUILD
PKGRELEASE is a confusing variable name, and it really is the BUILD string
for the specfile.
Rename PKGRELEASE to SPECBUILD.
Signed-off-by: Prarit Bhargava
diff --git a/redhat/Makefile b/redhat/Makefile
index
From: Prarit Bhargava
redhat/Makefile: Rename CHANGELOG to SPECCHANGELOG
Change CHANGELOG to SPECCHANGELOG so that readers understand it is passed
into the spec file. While the CHANGELOG does have use other than in the
spec file it is useful to know that the string is used in the spec file.
From: Prarit Bhargava
redhat/genspec: Rename BUILDID_DEFINE to SPECBUILDID
Change BUILDID_DEFINE to SPECBUILDID so that readers understand it is passed
into the spec file.
Rename BUILDID_DEFINE to SPECBUILDID.
Signed-off-by: Prarit Bhargava
diff --git a/redhat/genspec.sh b/redhat/genspec.sh
From: Prarit Bhargava
redhat/Makefile: Rename KVERSION to SPECVERSION
KVERSION is passed into the spec file and is easy to confuse with the
kernel KVERSION. Change the name to SPECVERSION so that readers
understand it is the %Version field of the specfile.
As a result RPMKSUBLEVEL can be
From: Prarit Bhargava
redhat/Makefile: Rename RPMKSUBLEVEL to SPECKSUBLEVEL
Change RPMKSUBLEVEL to SPECSUBLEVEL so that readers understand it is passed
into the spec file.
Rename RPMKSUBLEVEL to SPECKSUBLEVEL.
Signed-off-by: Prarit Bhargava
diff --git a/redhat/Makefile b/redhat/Makefile
From: Prarit Bhargava
redhat/Makefile: Rename RPMKPATCHLEVEL to SPECKPATCHLEVEL
Change RPMKPATCHLEVEL to SPECPATCHLEVEL so that readers understand it is passed
into the spec file.
Rename RPMKPATCHLEVEL to SPECKPATCHLEVEL.
Signed-off-by: Prarit Bhargava
diff --git a/redhat/Makefile
From: Prarit Bhargava
redhat/Makefile: Rename RPMKVERSION to SPECKVERSION
Change RPMKVERSION to SPECVERSION so that readers understand it is passed
into the spec file.
Rename RPMKVERSION to SPECKVERSION.
Signed-off-by: Prarit Bhargava
diff --git a/redhat/Makefile b/redhat/Makefile
index
From: Prarit Bhargava
redhat/Makefile: Use KVERSION
Use KVERSION where appropriate in the Makefile.
Signed-off-by: Prarit Bhargava
diff --git a/redhat/Makefile b/redhat/Makefile
index blahblah..blahblah 100644
--- a/redhat/Makefile
+++ b/redhat/Makefile
@@ -144,6 +144,9 @@ else
From: Prarit Bhargava
redhat/Makefile: Deprecate some simple targets
Deprecate some simple targets.
Signed-off-by: Prarit Bhargava
diff --git a/redhat/Makefile b/redhat/Makefile
index blahblah..blahblah 100644
--- a/redhat/Makefile
+++ b/redhat/Makefile
@@ -420,15 +420,23 @@
From: Prarit Bhargava on gitlab.com
Merge Request: https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1727
Depends: https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1647
One of the common complaints about the redhat Makefiles, genspec.sh, and
kernel.spec.template is that it is
From: Prarit Bhargava on gitlab.com
https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1727#note_935080527
Y'know, you busted me on this last time too. I swear I was careful this
time and verified that the bodies all had "Makefile" instead of "Makfile".
I guess I didn't check the
From: Prarit Bhargava on gitlab.com
https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1727#note_935078977
Thanks, fixed.
___
kernel mailing list -- kernel@lists.fedoraproject.org
To unsubscribe send an email to
From: Prarit Bhargava on gitlab.com
https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1727#note_935078416
Thanks, fixed.
___
kernel mailing list -- kernel@lists.fedoraproject.org
To unsubscribe send an email to
From: Prarit Bhargava on gitlab.com
https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1728#note_932324020
Updated due to merge conflict from Herton's CHANGELOG modifications.
Rebased on top of !1727.
___
kernel mailing list --
From: Prarit Bhargava
redhat/self-test: Add test to verify Makefile declarations.
The Makefiles have been organized such that only Makefile.variables
contain external variables that can be set on the command line, and
the Makefile only contains variables that can set within the Makefile
itself.
From: Prarit Bhargava
redhat/self-test/data: Cleanup data
There have been some additional redhat/Makefile changes that modified
variables. Run 'make dist-self-test-data' to clean these changes up.
Signed-off-by: Prarit Bhargava
diff --git a/redhat/self-test/data/centos-2585cf9dfaad.el7
From: Prarit Bhargava
redhat/Makefile: Add RHTEST
For a long time we have wanted a mechanism by which we could do a 'test
run' of Makefile targets. Make has built-in options '-n, --just-print,
--dry-run, --recon' that can be added on the command line that allow users
to show the output for
From: Prarit Bhargava
redhat: shellcheck cleanup
Some shellcheck cleanups.
Signed-off-by: Prarit Bhargava
diff --git a/redhat/genspec.sh b/redhat/genspec.sh
index blahblah..blahblah 100755
--- a/redhat/genspec.sh
+++ b/redhat/genspec.sh
@@ -114,7 +114,7 @@ cdate="$(LC_ALL=C date +"%a %b %d
From: Prarit Bhargava
redhat/self-test: Add test to verify SPEC variables
This test looks at the spec file variable replacement code in
redhat/genspec.sh and confirms that each variable begins with "SPEC".
Signed-off-by: Prarit Bhargava
diff --git a/redhat/docs/makefile-changes.rst
801 - 900 of 1565 matches
Mail list logo
