Re: [OS-BUILD PATCH] redhat: relax configchecks for gcov build

2021-10-20 Thread Jan Stancek (via Email Bridge)
From: Jan Stancek on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1433#note_709281351 > I am not sure if that hides other things that should be enabled It does, but gcov was always best-effort kind of feature. It's not built by default in ARK or RHEL. So I didn't think

Re: [OS-BUILD PATCH] redhat: relax configchecks for gcov build

2021-10-19 Thread Don Zickus (via Email Bridge)
From: Don Zickus on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1433#note_708131064 @jstancek - i tried to spend about a half hour thinking about this. As I saw other config changes using 'sed' in the kernel.spec file, I thought about using something like kernel.local

Re: [OS-BUILD PATCH] redhat: relax configchecks for gcov build

2021-10-19 Thread Jan Stancek (via Email Bridge)
From: Jan Stancek on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1433#note_707987552 I'm exploring the idea of new config variant, so far ran into !1436 and !1437 ___ kernel mailing list -- kernel@lists.fedoraproject.org To

Re: [OS-BUILD PATCH] redhat: relax configchecks for gcov build

2021-10-18 Thread Jan Stancek (via Email Bridge)
From: Jan Stancek on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1433#note_706658593 I think reason for handling this as build option (in spec file) was that you could build everything from one srpm. Right now we have 'generic' and 'debug' config variants, we could add

Re: [OS-BUILD PATCH] redhat: relax configchecks for gcov build

2021-10-18 Thread Don Zickus (via Email Bridge)
From: Don Zickus on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1433#note_706578162 I ran into this too. I am not a fan of this approach. It solves the problem, sure. However, part of the problem is that the gcov stuff is hidden behind the spec file magic. This makes

[OS-BUILD PATCH] redhat: relax configchecks for gcov build

2021-10-18 Thread Jan Stancek (via Email Bridge)
From: Jan Stancek redhat: relax configchecks for gcov build gcov build patches config file during build, which can lead to configchecks failing with either unset variable or because it finds a difference between options in source tree and buildroot. Relax the check for gcov builds to prevent