Re: [OS-BUILD PATCH 0/2] spec: fix building and packaging of resolve_btfids

From: Artem Savkov on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/2490#note_1410092160 Ah, makes sense then. Thanks for clarification. ___ kernel mailing list -- kernel@lists.fedoraproject.org To unsubscribe send an email to ker

Re: [OS-BUILD PATCH 0/2] spec: fix building and packaging of resolve_btfids

From: Viktor Malik on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/2490#note_1410090540 The `override` directive doesn't propagate into sub-make so it doesn't work here (already tried). Also, the variable name is not arbitrary, it's used this way in [tools/build/Build.inc

Re: [OS-BUILD PATCH 0/2] spec: fix building and packaging of resolve_btfids

From: Artem Savkov on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/2490#note_1410072985 Why new variable name? It is possible to override the override in gnu make: https://www.gnu.org/software/make/manual/html_node/Override-Directive.html __

Re: [OS-BUILD PATCH 0/2] spec: fix building and packaging of resolve_btfids

From: Viktor Malik on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/2490#note_1409839033 Good point, I'll send it upstream. ___ kernel mailing list -- kernel@lists.fedoraproject.org To unsubscribe send an email to kernel-le...@lis

Re: [OS-BUILD PATCH 0/2] spec: fix building and packaging of resolve_btfids

From: Jiri Benc on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/2490#note_1409821891 That looks much better. And yes, I think it's something for upstream. IMHO Documentation/kbuild/kbuild.rst documents HOSTCFLAGS as something that can be overriden from the make command li

Re: [OS-BUILD PATCH 0/2] spec: fix building and packaging of resolve_btfids

From: Viktor Malik on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/2490#note_1409781457 I agree that it's a mess, but this part has been overridden by 56a2df7615 ("tools/resolve_btfids: Compile resolve_btfids as host program"). I believe that the actual problem is that `r

Re: [OS-BUILD PATCH 0/2] spec: fix building and packaging of resolve_btfids

From: Jiri Benc on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/2490#note_1409378737 I wonder whether it's not a problem in the upstream commits playing weird games with the makefile variables. For example, this sentence in upstream commit 13e07691a16f ("tools/resolve_btfi

[OS-BUILD PATCH 0/2] spec: fix building and packaging of resolve_btfids

From: Viktor Malik on gitlab.com Merge Request: https://gitlab.com/cki-project/kernel-ark/-/merge_requests/2490 Commit 56a2df7615fa changed the `resolve_btfids` tool to be built as a host program. This causes selftests compilation error as we override `HOSTCFLAGS` when calling `make` from the spec