Re: [OS-BUILD PATCH 1/3] redhat: Use kspdx-tool output for the License: field

2023-08-30 Thread Vitaly Kuznetsov (via Email Bridge)
From: Vitaly Kuznetsov on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/2648#note_1535110057 Added "Redistributable, no modification permitted" back, better safe than sorry. We may have some other firmware-looking pieces in the kernel. We need some audit to make sure we

Re: [OS-BUILD PATCH 1/3] redhat: Use kspdx-tool output for the License: field

2023-08-30 Thread Vitaly Kuznetsov (via Email Bridge)
From: Vitaly Kuznetsov on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/2648#note_1535057039 @prarit We can add it manually, the question is how to make it a 'lesser hack'. Unfortunately, "Redistributable, no modification permitted" is not a valid SPDX tag so e.g. adding a

Re: [OS-BUILD PATCH 1/3] redhat: Use kspdx-tool output for the License: field

2023-08-28 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/2648#note_1532361366 Let's just add it back? @vkuznets what do you think? ___ kernel mailing list -- kernel@lists.fedoraproject.org To unsubscribe send an

Re: [OS-BUILD PATCH 1/3] redhat: Use kspdx-tool output for the License: field

2023-08-28 Thread Thorsten Leemhuis (via Email Bridge)
From: Thorsten Leemhuis on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/2648#note_1532352259 > ongoing discussion on making the resulting list of licenses way more readable That would be really nice! > My guess is that this was a leftover from the times when kernel was

Re: [OS-BUILD PATCH 1/3] redhat: Use kspdx-tool output for the License: field

2023-08-25 Thread Vitaly Kuznetsov (via Email Bridge)
From: Vitaly Kuznetsov on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/2648#note_1529889341 Fixed, pushed, MR updated. Thanks! ___ kernel mailing list -- kernel@lists.fedoraproject.org To unsubscribe send an email to

Re: [OS-BUILD PATCH 1/3] redhat: Use kspdx-tool output for the License: field

2023-08-25 Thread Vitaly Kuznetsov (via Email Bridge)
From: Vitaly Kuznetsov on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/2648#note_1529883107 Oh, this is very unfortunate and deserves an upstream discussion. Luckily, CONFIG_COPS/CONFIG_COPS_DANYA are not enabled on our configs. Post-MR, the list of licenses is formed

Re: [OS-BUILD PATCH 1/3] redhat: Use kspdx-tool output for the License: field

2023-08-24 Thread Herton R. Krzesinski (via Email Bridge)
From: Herton R. Krzesinski on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/2648#note_1527728838 Well there are still firmware being included in the linux sources, one example: ```drivers/net/appletalk/cops_ffdrv.h``` But probably cases like this should be handled

Re: [OS-BUILD PATCH 1/3] redhat: Use kspdx-tool output for the License: field

2023-08-24 Thread Jan Stancek (via Email Bridge)
From: Jan Stancek on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/2648#note_1526841131 ok, since it seems unlikely, I'm going to resolve this thread, I opened you first issue :-) https://gitlab.com/vkuznets/kspdx-tool/-/issues/1

Re: [OS-BUILD PATCH 1/3] redhat: Use kspdx-tool output for the License: field

2023-08-24 Thread Vitaly Kuznetsov (via Email Bridge)
From: Vitaly Kuznetsov on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/2648#note_1526606091 Indeed! ___ kernel mailing list -- kernel@lists.fedoraproject.org To unsubscribe send an email to kernel-le...@lists.fedoraproject.org

Re: [OS-BUILD PATCH 1/3] redhat: Use kspdx-tool output for the License: field

2023-08-24 Thread Vitaly Kuznetsov (via Email Bridge)
From: Vitaly Kuznetsov on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/2648#note_1526605878 Not that it is not allowed, just not present in the source :-) There's code to drop unneeded highest level parentheses so e.g. `(GPL-2.0-only)` becomes `GPL-2.0-only`, it can

Re: [OS-BUILD PATCH 1/3] redhat: Use kspdx-tool output for the License: field

2023-08-24 Thread Jan Stancek (via Email Bridge)
From: Jan Stancek on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/2648#note_1526334920 This `pass` looks redundant ___ kernel mailing list -- kernel@lists.fedoraproject.org To unsubscribe send an email to

Re: [OS-BUILD PATCH 1/3] redhat: Use kspdx-tool output for the License: field

2023-08-24 Thread Jan Stancek (via Email Bridge)
From: Jan Stancek on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/2648#note_1526318798 Should these replacements also match deprecated licenses that end with ')'? Or is my format not allowed? ``` ]$ cat test/test.c // SPDX-License-Identifier: GPL-2.0 OR (GPL-1.0) $

Re: [OS-BUILD PATCH 1/3] redhat: Use kspdx-tool output for the License: field

2023-08-24 Thread Vitaly Kuznetsov (via Email Bridge)
From: Vitaly Kuznetsov on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/2648#note_1526314134 FWIW, there's an ongoing discussion on making the resulting list of licenses way more readable by ignoring dual licensing, e.g. if a file is licensed under "(GPL-2.0-only WITH

Re: [OS-BUILD PATCH 1/3] redhat: Use kspdx-tool output for the License: field

2023-08-24 Thread Vitaly Kuznetsov (via Email Bridge)
From: Vitaly Kuznetsov on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/2648#note_1526295217 Yes, this is intentional. I (and the script which actually builds the 'License:' field now) didn't find anything under 'Redistributable' in the kernel. My guess is that this was a

Re: [OS-BUILD PATCH 1/3] redhat: Use kspdx-tool output for the License: field

2023-08-23 Thread Thorsten Leemhuis (via Email Bridge)
From: Thorsten Leemhuis on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/2648#note_1525439020 The "and Redistributable, no modification permitted" seems to be dropped (or easy to miss in this noisy License tag). Is this international? I wonder why it's there in the fist

[OS-BUILD PATCH 1/3] redhat: Use kspdx-tool output for the License: field

2023-08-23 Thread Vitaly Kuznetsov (via Email Bridge)
From: Vitaly Kuznetsov redhat: Use kspdx-tool output for the License: field Use kspdx-tool (https://gitlab.com/vkuznets/kspdx-tool) to find all licenses in the source code and its output to the License: field of the specfile. Package the tool and its current output. Signed-off-by: Vitaly