Re: [OS-BUILD PATCHv2] [redhat] spec: Add %bcond_with toolchain_clang option

2021-03-22 Thread Justin Forbes (via Email Bridge)
From: Justin Forbes on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/894#note_535065257 That seems comical ___ kernel mailing list -- kernel@lists.fedoraproject.org To unsubscribe send an email to

Re: [OS-BUILD PATCHv2] [redhat] spec: Add %bcond_with toolchain_clang option

2021-03-22 Thread Justin Forbes (via Email Bridge)
From: Justin Forbes on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/894#note_535063843 Ugh, sorry, I thought I did, but that was when I accidentally closed it instead. I failed hard that day. Acked-by: Justin Forbes ___

Re: [OS-BUILD PATCHv2] [redhat] spec: Add %bcond_with toolchain_clang option

2021-03-22 Thread Don Zickus (via Email Bridge)
From: Don Zickus on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/894#note_535061814 @jmflinuxtx - do you want to ACK this? ___ kernel mailing list -- kernel@lists.fedoraproject.org To unsubscribe send an email to

Re: [OS-BUILD PATCHv2] [redhat] spec: Add %bcond_with toolchain_clang option

2021-02-25 Thread cki-gitlab
From: Don Zickus on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/894#note_517406597 The only thing that makes me frown is the with_configcheck=0. However, the uniqueness of this situation does not have a solution inside the config generation logic. So I don't seeing be

Re: [OS-BUILD PATCHv2] [redhat] spec: Add %bcond_with toolchain_clang option

2021-02-25 Thread cki-gitlab
From: Justin Forbes on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/894#note_517097782 @dzickusrh Not particularly. The spec was written many years ago, and updated as needed, but no one has really been motivated towards such a change before.

Re: [OS-BUILD PATCHv2] [redhat] spec: Add %bcond_with toolchain_clang option

2021-02-22 Thread cki-gitlab
From: Don Zickus on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/894#note_514643012 @jmflinuxtx - is there a reason why the kernel.spec doesn't use %bcond more? It appears we use the exploded macro with --with and --without definitions.

Re: [OS-BUILD PATCHv2] [redhat] spec: Add %bcond_with toolchain_clang option

2021-02-19 Thread cki-gitlab
From: Tom Stellard on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/894#note_513497336 I've added a description and a signoff line to the commit message now. ___ kernel mailing list -- kernel@lists.fedoraproject.org To

[OS-BUILD PATCHv2] [redhat] spec: Add %bcond_with toolchain_clang option

2021-02-19 Thread Tom Stellard (via Email Bridge)
From: Tom Stellard [redhat] spec: Add %bcond_with toolchain_clang option This option can be enabled by passing --with toolchain_clang to rpmbuild or mock. Enabling this option will cause the kernel to be built with clang instead of gcc. Signed-off-by: Tom Stellard diff