Re: [OS-BUILD PATCHv2] redhat/configs/common: Turn on CONFIG_IKCONFIG_PROC

2022-10-07 Thread Andrew Halaney (via Email Bridge)
From: Andrew Halaney on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/2041#note_1128644792 Closing this MR since it isn't considered favorable by many. Thanks all for the input ___ kernel mailing list -- kernel@lists.fedoraproject

Re: [OS-BUILD PATCHv2] redhat/configs/common: Turn on CONFIG_IKCONFIG_PROC

2022-10-07 Thread Justin M. Forbes (via Email Bridge)
From: Justin M. Forbes on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/2041#note_1128275734 I might argue when working a bug report, the uname tells you exactly which config it is, and you don't need their /boot to get it. It is in our rpm, if not, they wouldn't have a val

Re: [OS-BUILD PATCHv2] redhat/configs/common: Turn on CONFIG_IKCONFIG_PROC

2022-10-04 Thread Jiri Benc (via Email Bridge)
From: Jiri Benc on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/2041#note_1124642864 I find this useful when working on a bug report. By getting /proc/config.gz, I'm 100% sure I've got the correct config. No space for mishandling a script fetching from /boot, no space for

Re: [OS-BUILD PATCHv2] redhat/configs/common: Turn on CONFIG_IKCONFIG_PROC

2022-10-04 Thread Jiri Benc (via Email Bridge)
From: Jiri Benc on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/2041#note_1124638254 I'd argue that if you're running 1000 VMs, 50 MB hardly matters. The kernels are what, 30 GB at that point? 0.1% is still 0.1%. ___ kernel maili

Re: [OS-BUILD PATCHv2] redhat/configs/common: Turn on CONFIG_IKCONFIG_PROC

2022-10-04 Thread Andrew Halaney (via Email Bridge)
From: Andrew Halaney on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/2041#note_1124355243 I'm arguing this for fedora/rhel out of personal interest at the moment, but there's been enough push back here that this MR is probably destined to be closed unless some advocates fo

Re: [OS-BUILD PATCHv2] redhat/configs/common: Turn on CONFIG_IKCONFIG_PROC

2022-10-04 Thread Jonathan Toppins (via Email Bridge)
From: Jonathan Toppins on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/2041#note_1124315349 All of these reasons are why I do not recommend using the `/proc` config entry unless the system has a non-standard storage configuration that prevents the storage of the config in

Re: [OS-BUILD PATCHv2] redhat/configs/common: Turn on CONFIG_IKCONFIG_PROC

2022-10-04 Thread pbrobinson (via Email Bridge)
From: pbrobinson on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/2041#note_1124306308 Do we have an explicit customer request for this or a RHBZ to provide more context? ___ kernel mailing list -- kernel@lists.fedoraproject.org T

Re: [OS-BUILD PATCHv2] redhat/configs/common: Turn on CONFIG_IKCONFIG_PROC

2022-10-04 Thread Andrew Halaney (via Email Bridge)
From: Andrew Halaney on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/2041#note_1124300349 The virt situation is one I had not considered, thanks ___ kernel mailing list -- kernel@lists.fedoraproject.org To unsubscribe send an ema

Re: [OS-BUILD PATCHv2] redhat/configs/common: Turn on CONFIG_IKCONFIG_PROC

2022-10-04 Thread Andrew Halaney (via Email Bridge)
From: Andrew Halaney on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/2041#note_1124299346 I unfortunately don't have an objective way of countering this, in the commit I tried to capture the increase in size I've seen (just shy of 50 KB out of the 30 MB kernel image) but I

Re: [OS-BUILD PATCHv2] redhat/configs/common: Turn on CONFIG_IKCONFIG_PROC

2022-10-04 Thread Donald Dutile (via Email Bridge)
From: Donald Dutile on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/2041#note_1124293339 50KB * 1000 VMs == 50 MB and I'm also wondering if this increases a container size, and slows down boot time, which there is a push to reduce, not increase (by a death of a thousan

Re: [OS-BUILD PATCHv2] redhat/configs/common: Turn on CONFIG_IKCONFIG_PROC

2022-10-04 Thread pbrobinson (via Email Bridge)
From: pbrobinson on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/2041#note_1124290516 It also needs to be a system actually running this specific kernel for this to work so it is not perfect and it wastes memory, even it's only a small amount, it adds up on memory constrai

Re: [OS-BUILD PATCHv2] redhat/configs/common: Turn on CONFIG_IKCONFIG_PROC

2022-10-04 Thread Andrew Halaney (via Email Bridge)
From: Andrew Halaney on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/2041#note_1124283425 I get your point, but I'm trying to look at it from the otherside of someone who's used to using `/proc/config.gz`. It's a kernel standardized interface, provides the current running

Re: [OS-BUILD PATCHv2] redhat/configs/common: Turn on CONFIG_IKCONFIG_PROC

2022-10-04 Thread Andrew Halaney (via Email Bridge)
From: Andrew Halaney on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/2041#note_1124272291 I unfortunately posted this the day before the os-build rebase :shrug: I'm going to remove all the reviewers since only a tiny amount are supposed to be here _

[OS-BUILD PATCHv2] redhat/configs/common: Turn on CONFIG_IKCONFIG_PROC

2022-10-04 Thread Andrew Halaney (via Email Bridge)
From: Andrew Halaney redhat/configs/common: Turn on CONFIG_IKCONFIG_PROC Some users expect to check /proc/config.gz instead of /boot/config-$(uname -r), and both are valid approaches. In fact, one could argue it is easier to trust the contents of /proc/config.gz than it is to trust the config in