Re: [OS-BUILD PATCHv2] redhat/kernel.spec.template: Fix RHEL systemd-boot-unsigned dependency

2023-02-28 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/2333#note_1295618723 I think there was some confusion. There was another MR I closed and I somehow closed this one. I will submit a new MR to add the rhel version check.

Re: [OS-BUILD PATCHv2] redhat/kernel.spec.template: Fix RHEL systemd-boot-unsigned dependency

2023-02-28 Thread Justin M. Forbes (via Email Bridge)
From: Justin M. Forbes on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/2333#note_1295548471 It should. And that is the conditional that will eventually be required anyway once we get to the point that RHEL 10 is a thing. Though in our call yesterday, it was mentioned that

Re: [OS-BUILD PATCHv2] redhat/kernel.spec.template: Fix RHEL systemd-boot-unsigned dependency

2023-02-28 Thread Jan Stancek (via Email Bridge)
From: Jan Stancek on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/2333#note_1295539855 If we revert, it becomes broken for brew - which I think was Prarit's motivation. Does ELN buildroot define rhel == 10? ``` diff --git a/redhat/kernel.spec.template

Re: [OS-BUILD PATCHv2] redhat/kernel.spec.template: Fix RHEL systemd-boot-unsigned dependency

2023-02-28 Thread Justin M. Forbes (via Email Bridge)
From: Justin M. Forbes on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/2333#note_1295379598 Not sure how this went from closed to reopened and merged within hours (I thought we were waiting for Clark's change). This MR is wrong, and breaks ELN builds which need