Re: [OS-BUILD PATCHv2 0/17] redhat: Use SPEC variable naming

2022-05-04 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1727#note_935080527 Y'know, you busted me on this last time too. I swear I was careful this time and verified that the bodies all had "Makefile" instead of "Makfile". I guess I didn't check the

Re: [OS-BUILD PATCHv2 0/17] redhat: Use SPEC variable naming

2022-05-04 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1727#note_935078977 Thanks, fixed. ___ kernel mailing list -- kernel@lists.fedoraproject.org To unsubscribe send an email to

Re: [OS-BUILD PATCHv2 0/17] redhat: Use SPEC variable naming

2022-05-04 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1727#note_935078416 Thanks, fixed. ___ kernel mailing list -- kernel@lists.fedoraproject.org To unsubscribe send an email to

Re: [OS-BUILD PATCHv2 0/17] redhat: Use SPEC variable naming

2022-05-02 Thread Herton R. Krzesinski (via Email Bridge)
From: Herton R. Krzesinski on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1727#note_932742089 These 3 patches have a small typo in the subject title (Makfile instead of Makefile): ``` 5 21b2bf ! redhat/Makfile: Rename RPMKPATCHLEVEL to SPECKPATCHLEVEL 6 113694 !

Re: [OS-BUILD PATCHv2 0/17] redhat: Use SPEC variable naming

2022-05-02 Thread Herton R. Krzesinski (via Email Bridge)
From: Herton R. Krzesinski on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1727#note_932738615 This also needs update to use SPECKVERSION and SPECKPATCHLEVEL. Also, please edit rpminspect.yaml to update the template too, I think the ```%%...%%``` template name can be

Re: [OS-BUILD PATCHv2 0/17] redhat: Use SPEC variable naming

2022-05-02 Thread Herton R. Krzesinski (via Email Bridge)
From: Herton R. Krzesinski on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1727#note_932737147 I think you need to update the comment and use the renamed variables here too, SPECKVERSION, SPECKPATCHLEVEL and SPECKSUBLEVEL? ___

Re: [OS-BUILD PATCHv2 0/17] redhat: Use SPEC variable naming

2022-05-02 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1727#note_932320137 MR commits updated due to merge conflict. I had to rework the code for Herton's CHANGELOG modifications, and added a cleanup commit for the tests as well. Successfully tested with

[OS-BUILD PATCHv2 0/17] redhat: Use SPEC variable naming

2022-05-02 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava on gitlab.com Merge Request: https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1727 Depends: https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1647 One of the common complaints about the redhat Makefiles, genspec.sh, and kernel.spec.template is that it is