Re: [OS-BUILD PATCHv2 0/2] redhat/kernel.spec: add uki_addons to create UKI kernel cmdline addons

2024-02-06 Thread via Email Bridge
From: Daniel P. Berrangé on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/2917#note_1760942365 So IIUC, essentially each '.addon' would become a new "SourceNNN" line in the kernel.spec. I prefer that to the CSV file as it makes it more configurable during build. -- ___

Re: [OS-BUILD PATCHv2 0/2] redhat/kernel.spec: add uki_addons to create UKI kernel cmdline addons

2024-02-06 Thread Emanuele Giuseppe Esposito (via Email Bridge)
From: Emanuele Giuseppe Esposito on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/2917#note_1760866217 I am not sure I understand the question. What do you mean with where is it supposed to be needed? This is necessary in order to build the UKI addons -- ___

Re: [OS-BUILD PATCHv2 0/2] redhat/kernel.spec: add uki_addons to create UKI kernel cmdline addons

2024-02-06 Thread Emanuele Giuseppe Esposito (via Email Bridge)
From: Emanuele Giuseppe Esposito on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/2917#note_1760864399 @prudo1 what about the SBAT? we might want to add that too. But then that may be shared between all addons I guess @berrange what do you think of the filesystem based str

Re: [OS-BUILD PATCHv2 0/2] redhat/kernel.spec: add uki_addons to create UKI kernel cmdline addons

2024-02-05 Thread Philipp Rudo (via Email Bridge)
From: Philipp Rudo on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/2917#note_1758222573 I'm also not convinced that having all the addons in a single config file makes sense. I'm looking at it from an kdump perspective. There we need to have the crashkernel= parameter on t

Re: [OS-BUILD PATCHv2 0/2] redhat/kernel.spec: add uki_addons to create UKI kernel cmdline addons

2024-02-01 Thread Michael Hofmann (via Email Bridge)
From: Michael Hofmann on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/2917#note_1753957414 @eesposit this is not in the CKI buildroot yet - where is this supposed to be needed going forward? -- ___ kernel mailing list -- kernel@l

Re: [OS-BUILD PATCHv2 0/2] redhat/kernel.spec: add uki_addons to create UKI kernel cmdline addons

2024-02-01 Thread via Email Bridge
From: Daniel P. Berrangé on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/2917#note_1753784734 But at that point we might as well just use the ukify tool directly. -- ___ kernel mailing list -- kernel@lists.fedoraproject.org To un

Re: [OS-BUILD PATCHv2 0/2] redhat/kernel.spec: add uki_addons to create UKI kernel cmdline addons

2024-02-01 Thread via Email Bridge
From: Daniel P. Berrangé on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/2917#note_1753782383 Looking at this config file, I'm not entirely convinced that we benefit from having this in a config file, and it has downsides in lack of flexibility. For example, consider that

[OS-BUILD PATCHv2 0/2] redhat/kernel.spec: add uki_addons to create UKI kernel cmdline addons

2024-02-01 Thread Emanuele Giuseppe Esposito (via Email Bridge)
From: Emanuele Giuseppe Esposito on gitlab.com Merge Request: https://gitlab.com/cki-project/kernel-ark/-/merge_requests/2917 We want to enable kernel.spec to optionally ship UKI addons defined in a common config file in redhat folder. If that file is populated, and the kernel-uki-virt is built,