Re: [OS-BUILD PATCHv3] makefile: Add -Werror support for RHEL

2023-01-06 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/2240#note_1230393561 Oh it certainly does need that line. I'll add it. ___ kernel mailing list -- kernel@lists.fedoraproject.org To unsubscribe send an email

Re: [OS-BUILD PATCHv3] makefile: Add -Werror support for RHEL

2023-01-06 Thread Don Zickus (via Email Bridge)
From: Don Zickus on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/2240#note_1230246925 @prarit - hmm, ok I am torn here. I thank you for respecting the 'do not break ARK approach'. But then I wonder what is the value of this in ARK (besides the obvious don't lose changes)

Re: [OS-BUILD PATCHv3] makefile: Add -Werror support for RHEL

2023-01-06 Thread Brian Masney (via Email Bridge)
From: Brian Masney on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/2240#note_1230234958 OK, good point about not enabling it on ARK. ___ kernel mailing list -- kernel@lists.fedoraproject.org To unsubscribe send an email to kernel

Re: [OS-BUILD PATCHv3] makefile: Add -Werror support for RHEL

2023-01-06 Thread Brian Masney (via Email Bridge)
From: Brian Masney on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/2240#note_1230232997 Do you also need to add `KBUILD_CPPFLAGS += $(KBUILD_CPPFLAGS-y)`? This is from https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit /?id=efa80b028c7a9 ___

[OS-BUILD PATCHv3] makefile: Add -Werror support for RHEL

2023-01-06 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava makefile: Add -Werror support for RHEL The -Werror flag should be enabled for RHEL. In ARK, however, it is a bit tricky to enable -Werror as a build bug occasionally leaks through upstream review and into Linus' tree. As a consequence, CONFIG_WERROR cannot be enabled in A