Re: [OS-BUILD PATCHv3 0/4] redhat: update merge.py to handle merge.pl corner cases

2023-01-31 Thread Herton R. Krzesinski (via Email Bridge)
From: Herton R. Krzesinski on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/2262#note_1259584001 Yes I agree we could do improvements/changes to the script or cleanup the comments in another MR, since it's out of scope for this one, so approving this. __

Re: [OS-BUILD PATCHv3 0/4] redhat: update merge.py to handle merge.pl corner cases

2023-01-31 Thread Herton R. Krzesinski (via Email Bridge)
From: Herton R. Krzesinski on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/2262#note_1259579704 Yes indeed. I think we can keep the logic the same as .pl right now, and may be we can improve the .py script later. Since original concern is solved, resolving this thread. ___

Re: [OS-BUILD PATCHv3 0/4] redhat: update merge.py to handle merge.pl corner cases

2023-01-31 Thread Justin M. Forbes (via Email Bridge)
From: Justin M. Forbes on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/2262#note_1259574917 So this version does make the output match the output from before this MR, but that means we have our additional comments in the config files. I do not consider it a part of the sc

[OS-BUILD PATCHv3 0/4] redhat: update merge.py to handle merge.pl corner cases

2023-01-31 Thread Clark Williams (via Email Bridge)
From: Clark Williams on gitlab.com Merge Request: https://gitlab.com/cki-project/kernel-ark/-/merge_requests/2262 Change merge.py to handle input config files in similar manner to how merge.pl did it. Signed-off-by: Clark Williams --- redhat/configs/merge.pl | 72 ---