From: Justin M. Forbes on gitlab.com
https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1603#note_891563350
That should do it.
___
kernel mailing list -- kernel@lists.fedoraproject.org
To unsubscribe send an email to
From: Brian Foster on gitlab.com
https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1603#note_891548412
Ok. It seems I'm not able to ack this because of unresolved threads, but I
don't see a resolve threads button in my view. Did your previous comment
create a thread that you're able to
From: Justin M. Forbes on gitlab.com
https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1603#note_891516554
I mean all of the RHELisms are ripped out every time I do a rebased fedora-5.x
branch. This ends up being several times a year, and since os-build is
rebased, I can't simply keep a
From: Brian Foster on gitlab.com
https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1603#note_891470421
Can you elaborate? Do you mean that you prefer the ifdef because it makes
finding this code easier? Wouldn't we have to scan for callsites anyways given
that the empty inlines already
From: Justin M. Forbes on gitlab.com
https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1603#note_891415723
I would much rather it not. While things may build and function, it just makes
it easier for patches like this to get lost on the Fedora stable rebases,
where they are all ripped
From: Brian Foster on gitlab.com
https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1603#note_891384587
- [2/2] `4254c840c8f3` ("Add Partner Supported taint flag to kAFS")
Thanks for the tweaks. One more nit.. the ifdef in this patch can go away
now that patch 1 defines the empty
From: Alice Mitchell on gitlab.com
https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1603#note_889385733
@Brian Foster thank you for those comments.
1) Looking more closely it does seem you are right and this could benefit
from being marked as a per-module taint
2) my mistake, i omitted
From: Alice Mitchell on gitlab.com
Merge Request: https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1603
NOTE: Truncated patchset due to missing public @redhat.com email
address on your GitLab profile at https://gitlab.com/-/profile.
Once that is fixed, close and reopen the
