Re: [OS-BUILD PATCH 1/3] redhat/Makefile: Fix '*-configs' targets

2020-08-24 Thread Marcelo Ricardo Leitner
On Mon, Aug 24, 2020 at 04:03:27PM -0400, Prarit Bhargava wrote: > On 8/24/20 3:21 PM, Marcelo Ricardo Leitner wrote: > > On Mon, Aug 24, 2020 at 03:15:44PM -0400, Don Zickus wrote: > >> On Mon, Aug 24, 2020 at 03:24:28PM -0300, Marcelo Ricardo Leitner wrote: > >>> > >>> But yeah, some will

Re: [OS-BUILD PATCH 1/3] redhat/Makefile: Fix '*-configs' targets

2020-08-24 Thread Prarit Bhargava
On 8/24/20 3:21 PM, Marcelo Ricardo Leitner wrote: > On Mon, Aug 24, 2020 at 03:15:44PM -0400, Don Zickus wrote: >> On Mon, Aug 24, 2020 at 03:24:28PM -0300, Marcelo Ricardo Leitner wrote: >>> >>> But yeah, some will complain that now they need to copy a different >>> file to import the .config,

Re: [OS-BUILD PATCH 1/3] redhat/Makefile: Fix '*-configs' targets

2020-08-24 Thread Marcelo Ricardo Leitner
On Mon, Aug 24, 2020 at 03:15:44PM -0400, Don Zickus wrote: > On Mon, Aug 24, 2020 at 03:24:28PM -0300, Marcelo Ricardo Leitner wrote: > > > > But yeah, some will complain that now they need to copy a different > > file to import the .config, but at least they will be sure of what > > they are

Re: [OS-BUILD PATCH 1/3] redhat/Makefile: Fix '*-configs' targets

2020-08-24 Thread Don Zickus
On Mon, Aug 24, 2020 at 03:24:28PM -0300, Marcelo Ricardo Leitner wrote: > > But yeah, some will complain that now they need to copy a different > file to import the .config, but at least they will be sure of what > they are copying. Ah ok, so both rhel and fedora was built, one was tossed and

Re: [OS-BUILD PATCH 1/3] redhat/Makefile: Fix '*-configs' targets

2020-08-24 Thread Marcelo Ricardo Leitner
On Mon, Aug 24, 2020 at 01:52:19PM -0400, Don Zickus wrote: > On Mon, Aug 24, 2020 at 09:31:53AM -0500, Justin Forbes wrote: > > > Right. rh-configs and fedora-configs are nice in that they build ONLY > > > those > > > configs. > > > > > I don't see a problem with having them broken out for

Re: [OS-BUILD PATCH 1/3] redhat/Makefile: Fix '*-configs' targets

2020-08-24 Thread Don Zickus
On Mon, Aug 24, 2020 at 09:31:53AM -0500, Justin Forbes wrote: > > Right. rh-configs and fedora-configs are nice in that they build ONLY those > > configs. > > > I don't see a problem with having them broken out for specific cases, > but really by default people should be in the habit of

Re: [OS-BUILD PATCH 1/3] redhat/Makefile: Fix '*-configs' targets

2020-08-24 Thread Don Zickus
On Mon, Aug 24, 2020 at 10:25:21AM -0400, Prarit Bhargava wrote: > > dist-configs would be supported but not as an expected common command and > > would only be seen through dist-full-help? > > Yeah, I think that's what he's getting at. dist-configs would be an internal > only target.

Re: [OS-BUILD PATCH 1/3] redhat/Makefile: Fix '*-configs' targets

2020-08-24 Thread Prarit Bhargava
On 8/21/20 5:25 PM, Marcelo Ricardo Leitner wrote: > On Fri, Aug 21, 2020 at 01:37:24PM -, GitLab Bridge on behalf of prarit > wrote: >> From: Prarit Bhargava >> >> The 'dist-configs' is not working properly as it only creates ELN >> configs. The 'rh-configs' and 'fedora-configs' targets

Re: [OS-BUILD PATCH 1/3] redhat/Makefile: Fix '*-configs' targets

2020-08-24 Thread Prarit Bhargava
On 8/24/20 10:31 AM, Justin Forbes wrote: > On Mon, Aug 24, 2020 at 9:25 AM Prarit Bhargava wrote: >> >> On 8/24/20 9:49 AM, Don Zickus wrote: >>> On Sat, Aug 22, 2020 at 06:56:29AM -0400, Prarit Bhargava wrote: > and final files are not tagged with 'rhel'. That's the current way

Re: [OS-BUILD PATCH 1/3] redhat/Makefile: Fix '*-configs' targets

2020-08-24 Thread Justin Forbes
On Mon, Aug 24, 2020 at 9:25 AM Prarit Bhargava wrote: > > On 8/24/20 9:49 AM, Don Zickus wrote: > > On Sat, Aug 22, 2020 at 06:56:29AM -0400, Prarit Bhargava wrote: > >>> and final files are not tagged with 'rhel'. > >> > >> That's the current way dist-configs does things. I debated adding a

Re: [OS-BUILD PATCH 1/3] redhat/Makefile: Fix '*-configs' targets

2020-08-24 Thread Prarit Bhargava
On 8/24/20 9:49 AM, Don Zickus wrote: > On Sat, Aug 22, 2020 at 06:56:29AM -0400, Prarit Bhargava wrote: >>> and final files are not tagged with 'rhel'. >> >> That's the current way dist-configs does things. I debated adding a rename >> function to the os specific configs targets but think that

Re: [OS-BUILD PATCH 1/3] redhat/Makefile: Fix '*-configs' targets

2020-08-24 Thread Don Zickus
On Sat, Aug 22, 2020 at 06:56:29AM -0400, Prarit Bhargava wrote: > > and final files are not tagged with 'rhel'. > > That's the current way dist-configs does things. I debated adding a rename > function to the os specific configs targets but think that should be a > separate > patch. *This*

Re: [OS-BUILD PATCH 1/3] redhat/Makefile: Fix '*-configs' targets

2020-08-22 Thread Prarit Bhargava
On 8/21/20 5:25 PM, Marcelo Ricardo Leitner wrote: > On Fri, Aug 21, 2020 at 01:37:24PM -, GitLab Bridge on behalf of prarit > wrote: >> From: Prarit Bhargava >> >> The 'dist-configs' is not working properly as it only creates ELN >> configs. The 'rh-configs' and 'fedora-configs' targets

Re: [OS-BUILD PATCH 1/3] redhat/Makefile: Fix '*-configs' targets

2020-08-21 Thread Marcelo Ricardo Leitner
On Fri, Aug 21, 2020 at 01:37:24PM -, GitLab Bridge on behalf of prarit wrote: > From: Prarit Bhargava > > The 'dist-configs' is not working properly as it only creates ELN > configs. The 'rh-configs' and 'fedora-configs' targets are not > working properly and should be creating ELN and